Return-Path: Received: from mail-m2458.qiye.163.com (mail-m2458.qiye.163.com [220.194.24.58]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id DA6B04201E4 for ; Thu, 3 Mar 2022 08:11:28 +0100 (CET) From: Rui Xu To: philipp.reisner@linbit.com, drbd-dev@lists.linbit.com, joel.colledge@linbit.com Date: Thu, 3 Mar 2022 15:10:09 +0800 Message-Id: <20220303071009.1070360-1-rui.xu@easystack.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Rui Xu , dongsheng.yang@easystack.cn Subject: [Drbd-dev] [PATCH] drbd: create new uuid even we dont have quorum List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , We cant skip creating new uuid, when we are making new uuid. If there is an IO blocked by creating new uuid, but we found we dont have quorum, then NEW_CUR_UUID will be cleared but new uuid was not actually created. After one peer online, we have enough quorum to continue IO, then this IO will reach primary and the online peer. But if there is another peer join later, this peer will found same uuid, and will lose data. Signed-off-by: Rui Xu --- drbd/drbd_sender.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drbd/drbd_sender.c b/drbd/drbd_sender.c index 7238730..88d49d9 100644 --- a/drbd/drbd_sender.c +++ b/drbd/drbd_sender.c @@ -2360,7 +2360,7 @@ void drbd_check_peers_new_current_uuid(struct drbd_device *device) drbd_check_peers(resource); - if (device->have_quorum[NOW] && drbd_data_accessible(device, NOW)) + if (drbd_data_accessible(device, NOW)) drbd_uuid_new_current(device, false); } -- 1.8.3.1