Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 086AC42065E for ; Thu, 3 Mar 2022 12:19:33 +0100 (CET) From: Christoph Hellwig To: Jens Axboe Date: Thu, 3 Mar 2022 14:18:56 +0300 Message-Id: <20220303111905.321089-2-hch@lst.de> In-Reply-To: <20220303111905.321089-1-hch@lst.de> References: <20220303111905.321089-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Chris Zankel , Justin Sanders , Minchan Kim , Vishal Verma , linux-xtensa@linux-xtensa.org, Philipp Reisner , Denis Efremov , Coly Li , linux-block@vger.kernel.org, Max Filippov , linux-bcache@vger.kernel.org, nvdimm@lists.linux.dev, Lars Ellenberg , Ira Weiny , Dan Williams , Nitin Gupta , drbd-dev@lists.linbit.com Subject: [Drbd-dev] [PATCH 01/10] iss-simdisk: use bvec_kmap_local in simdisk_submit_bio List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Using local kmaps slightly reduces the chances to stray writes, and the bvec interface cleans up the code a little bit. Signed-off-by: Christoph Hellwig Reviewed-by: Ira Weiny --- arch/xtensa/platforms/iss/simdisk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index 8eb6ad1a3a1de..0f0e0724397f4 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -108,13 +108,13 @@ static void simdisk_submit_bio(struct bio *bio) sector_t sector = bio->bi_iter.bi_sector; bio_for_each_segment(bvec, bio, iter) { - char *buffer = kmap_atomic(bvec.bv_page) + bvec.bv_offset; + char *buffer = bvec_kmap_local(&bvec); unsigned len = bvec.bv_len >> SECTOR_SHIFT; simdisk_transfer(dev, sector, len, buffer, bio_data_dir(bio) == WRITE); sector += len; - kunmap_atomic(buffer); + kunmap_local(buffer); } bio_endio(bio); -- 2.30.2