Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 0EBAF421787 for ; Thu, 3 Mar 2022 12:20:16 +0100 (CET) From: Christoph Hellwig To: Jens Axboe Date: Thu, 3 Mar 2022 14:19:03 +0300 Message-Id: <20220303111905.321089-9-hch@lst.de> In-Reply-To: <20220303111905.321089-1-hch@lst.de> References: <20220303111905.321089-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Chris Zankel , Justin Sanders , Minchan Kim , Vishal Verma , linux-xtensa@linux-xtensa.org, Philipp Reisner , Denis Efremov , Coly Li , linux-block@vger.kernel.org, Max Filippov , linux-bcache@vger.kernel.org, nvdimm@lists.linux.dev, Lars Ellenberg , Ira Weiny , Dan Williams , Nitin Gupta , drbd-dev@lists.linbit.com Subject: [Drbd-dev] [PATCH 08/10] drbd: use bvec_kmap_local in drbd_csum_bio List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Using local kmaps slightly reduces the chances to stray writes, and the bvec interface cleans up the code a little bit. Signed-off-by: Christoph Hellwig Reviewed-by: Ira Weiny --- drivers/block/drbd/drbd_worker.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index a5e04b38006b6..1b48c8172a077 100644 --- a/drivers/block/drbd/drbd_worker.c +++ b/drivers/block/drbd/drbd_worker.c @@ -326,9 +326,9 @@ void drbd_csum_bio(struct crypto_shash *tfm, struct bio *bio, void *digest) bio_for_each_segment(bvec, bio, iter) { u8 *src; - src = kmap_atomic(bvec.bv_page); - crypto_shash_update(desc, src + bvec.bv_offset, bvec.bv_len); - kunmap_atomic(src); + src = bvec_kmap_local(&bvec); + crypto_shash_update(desc, src, bvec.bv_len); + kunmap_local(src); /* REQ_OP_WRITE_SAME has only one segment, * checksum the payload only once. */ -- 2.30.2