Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28F5136B for ; Thu, 3 Mar 2022 20:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646338793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W+Yb3jSVbGXS2UsBEDl+Z51/w7cVcv7OgJoaeEwhScE=; b=Q3Vu7866MDdY7xCJLeI1VGCExy3Ut+fs8dJZWMzJh9tsGFzYYkdqLn4DmIRT+3DlOty1B5 MK73fsmQ5ofG+iVsqpZODN+cHpMIW6TS96gugY+1raJD8oofN4BxBZKjQbSB4vRxUCnadg v0ymSJ1LiCls/lg28H8Xy8yjbMG5lpI= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-550-TzJ-RfTqPb6asbSY_mHAvA-1; Thu, 03 Mar 2022 15:19:50 -0500 X-MC-Unique: TzJ-RfTqPb6asbSY_mHAvA-1 Received: by mail-oi1-f200.google.com with SMTP id o124-20020aca5a82000000b002d7585f6de6so3929571oib.3 for ; Thu, 03 Mar 2022 12:19:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W+Yb3jSVbGXS2UsBEDl+Z51/w7cVcv7OgJoaeEwhScE=; b=4IpU2u33bEYKk1CHmAMCRD6RiIWBfEEUZlBS5SayDfgsWY8pjY3m5sBJBQm/7qJbeB IPj+J7cCATvCio0iJ1gh1/xTf6w3S0XFzwvsnL804SdMhPscbdEYtpxjFhv12HvlGXN+ auQ7WGzh0NOXtC6nAwaS57n2+4i/o7wtS4h3F704MVbaiPylwSk5fnh9v5yRxT2ix9BJ woSZPPgWx8OsVRHN2gWRv8L1Hydl/EbBP3AVgY8bveCObHov/ZAyLCA7RFgPAYnbMsr5 s0JxEy8ZybguZTxgMjxZJGL59pk20bbtgoEMFJaVyh3fW2S8xWO4bu50G5Pl2wawEL5/ YuSw== X-Gm-Message-State: AOAM5339QN/7kLc3K1WVjZAPWw8UFZkMxHIDKCsZgW4hjFMQGH1khdw8 nRqHTTHU0cKqHPnWbtsOXp8RAb89ZADNl99CUz/zDgGmsMoXgPJxP6IIObH7ZMOm0lPj1qYT0x8 sDiGhFt9OEDR1hw== X-Received: by 2002:a05:6870:128c:b0:ce:c0c9:5ba with SMTP id 12-20020a056870128c00b000cec0c905bamr5481234oal.12.1646338789963; Thu, 03 Mar 2022 12:19:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9UL7z0i5c0I1zBYkPbE2sDhIbft3n5S0zsg8O5Iu/S8GWiXtXSO4aUx3Hz5c0J+4lOC6M2Q== X-Received: by 2002:a05:6870:128c:b0:ce:c0c9:5ba with SMTP id 12-20020a056870128c00b000cec0c905bamr5481217oal.12.1646338789724; Thu, 03 Mar 2022 12:19:49 -0800 (PST) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id 52-20020a9d0bb7000000b005afa463d9f8sm1411532oth.19.2022.03.03.12.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 12:19:49 -0800 (PST) From: trix@redhat.com To: andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com, xji@analogixsemi.com, hsinyi@chromium.org, sam@ravnborg.org, tzungbi@google.com, pihsun@chromium.org, maxime@cerno.tech Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] drm/bridge: anx7625: check the return on anx7625_aux_trans Date: Thu, 3 Mar 2022 12:19:43 -0800 Message-Id: <20220303201943.501746-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" From: Tom Rix Clang static analysis reports this issue anx7625.c:876:13: warning: The left operand of '&' is a garbage value if (!(bcap & 0xOA01)) { ~~~~ ^ bcap is only set by a successful call to anx7625_aux_trans(). So check. Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support") Signed-off-by: Tom Rix --- drivers/gpu/drm/bridge/analogix/anx7625.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 633618bafd75d..f02ac079ed2ec 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -872,7 +872,10 @@ static int anx7625_hdcp_enable(struct anx7625_data *ctx) } /* Read downstream capability */ - anx7625_aux_trans(ctx, DP_AUX_NATIVE_READ, 0x68028, 1, &bcap); + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_READ, 0x68028, 1, &bcap); + if (ret < 0) + return ret; + if (!(bcap & 0x01)) { pr_warn("downstream not support HDCP 1.4, cap(%x).\n", bcap); return 0; -- 2.26.3