Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A40B9C433EF for ; Mon, 7 Mar 2022 15:16:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9BEAE807DC; Mon, 7 Mar 2022 16:16:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GnGm4FZJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1CDF280073; Mon, 7 Mar 2022 16:16:13 +0100 (CET) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5834080FDD for ; Mon, 7 Mar 2022 16:15:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id s16so3900789qks.4 for ; Mon, 07 Mar 2022 07:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UaYwvlSzzbzFXACkuRKVLL4dQNM5WTe0fyV29WKkPH4=; b=GnGm4FZJs2c/8U9JAss5OS3HJnogYcok4DZHPEBq1cq0rIEJLb8ow8dlwrUompLUmJ AntfKG4nCVMnLnLQnT3O1pGirApL8JytjF4Xk5h75RRdMBZvN0bg3FnmIhlB3RbJlXAL ry2nwDBRKB0g+K1U2kBNBFOuzg3L5Hzlw3YbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UaYwvlSzzbzFXACkuRKVLL4dQNM5WTe0fyV29WKkPH4=; b=z6zpT6mKL6Jj+Rq1V7dMGDK6XW72XdVrYZQuNN4/JFtDf9D+dXoG6ki/9w2bF43EJp BGPpJejAC+LK/u5k3S8HCsyXAUJoSMHnqjcqubDSMLWoTXuasOGN7naRQcHKtTLxhyCc mg+4bhcG3nIAjnquP8Eu3MKGTZYF2EapRb/OWsGJ3cxxAK76qzGdldSlscXWpYt4L+AZ KXb9p90xvHJsNAf/oGnxOCnjYCyHg8LFC6+gO9aU0Jh0Rk/CHla6DbYZdKSmQNB4hkts 8OecGqAssqtUShEyRL7POc3K55XcTwGb7OIHiqyRsEg2PAxmqBZd33kIZ99i2AD5fsX/ GUmQ== X-Gm-Message-State: AOAM531C1QcNakCx7nCHDcIGzSFq07H951J+/rgGcPt2FO1d+GHOABCW 9gnBiSsa/KA24MONiCwBBJJVdQ== X-Google-Smtp-Source: ABdhPJyCQAAdp4Cvk1NZOXhZFV0nDoDz5A0AVs6Ny/O5Pr4OuDwmK+jysziYvkDJvS7TphrEzQF6iA== X-Received: by 2002:a37:e116:0:b0:67b:34bc:9175 with SMTP id c22-20020a37e116000000b0067b34bc9175mr1777386qkm.543.1646666154997; Mon, 07 Mar 2022 07:15:54 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id f4-20020a05622a1a0400b002de1b1dda9fsm8382333qtb.94.2022.03.07.07.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 07:15:54 -0800 (PST) Date: Mon, 7 Mar 2022 10:15:51 -0500 From: Tom Rini To: Gaurav Jain Cc: Michael Walle , "sbabic@denx.de" , Varun Sethi , Adrian Alonso , Alison Wang , Andy Tang , "festevam@gmail.com" , Franck Lenormand , Horia Geanta , Ji Luo , "marex@denx.de" , Meenakshi Aggarwal , Mingkai Hu , "olteanv@gmail.com" , Pankaj Gupta , Peng Fan , Pramod Kumar , Priyanka Jain , Rajesh Bhagat , Sahil Malhotra , Shengzhou Liu , Silvano Di Ninno , "sjg@chromium.org" , "u-boot@lists.denx.de" , dl-uboot-imx , Wasim Khan , Ye Li Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model Message-ID: <20220307151551.GR5020@bill-the-cat> References: <6a620def-8189-cf26-de81-2d2fa9c6f0f1@denx.de> <20220307095819.3480138-1-michael@walle.cc> <71356e5efd2f0abe0bf98712ec1a14ba@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q42DwHUcI5a+9iZz" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --q42DwHUcI5a+9iZz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 07, 2022 at 12:03:42PM +0000, Gaurav Jain wrote: >=20 >=20 > > -----Original Message----- > > From: Michael Walle > > Sent: Monday, March 7, 2022 5:12 PM > > To: Gaurav Jain > > Cc: sbabic@denx.de; Varun Sethi ; Adrian Alonso > > ; Alison Wang ; Andy Tang > > ; festevam@gmail.com; Franck Lenormand > > ; Horia Geanta ; Ji Luo > > ; marex@denx.de; Meenakshi Aggarwal > > ; Mingkai Hu ; > > olteanv@gmail.com; Pankaj Gupta ; Peng Fan > > ; Pramod Kumar ; Priyanka > > Jain ; Rajesh Bhagat ; Sa= hil > > Malhotra ; Shengzhou Liu ; > > Silvano Di Ninno ; sjg@chromium.org; u- > > boot@lists.denx.de; dl-uboot-imx ; Wasim Khan > > ; Ye Li > > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAA= M Job > > ring driver model > >=20 > > Caution: EXT Email > >=20 > > Am 2022-03-07 12:33, schrieb Gaurav Jain: > > >> -----Original Message----- > > >> From: Michael Walle > > >> Sent: Monday, March 7, 2022 4:39 PM > > >> To: Gaurav Jain > > >> Cc: sbabic@denx.de; Varun Sethi ; Adrian Alonso > > >> ; Alison Wang ; Andy > > Tang > > >> ; festevam@gmail.com; Franck Lenormand > > >> ; Horia Geanta ; Ji > > >> Luo ; marex@denx.de; Meenakshi Aggarwal > > >> ; Mingkai Hu ; > > >> olteanv@gmail.com; Pankaj Gupta ; Peng Fan > > >> ; Pramod Kumar ; > > Priyanka > > >> Jain ; Rajesh Bhagat ; > > >> Sahil Malhotra ; Shengzhou Liu > > >> ; Silvano Di Ninno ; > > >> sjg@chromium.org; u- boot@lists.denx.de; dl-uboot-imx > > >> ; Wasim Khan ; Ye Li > > >> > > >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for > > >> CAAM Job ring driver model > > >> > > >> Caution: EXT Email > > >> > > >> Am 2022-03-07 11:56, schrieb Gaurav Jain: > > >> >> -----Original Message----- > > >> >> From: Michael Walle > > >> >> Sent: Monday, March 7, 2022 3:28 PM > > >> >> To: sbabic@denx.de > > >> >> Cc: Varun Sethi ; Adrian Alonso > > >> >> ; Alison Wang ; Andy > > >> Tang > > >> >> ; festevam@gmail.com; Franck Lenormand > > >> >> ; Gaurav Jain ; > > >> >> Horia Geanta ; Ji Luo ; > > >> >> marex@denx.de; Meenakshi Aggarwal ; > > >> >> Mingkai Hu ; olteanv@gmail.com; Pankaj Gupta > > >> >> ; Peng Fan ; Pramod > > Kumar > > >> >> ; Priyanka Jain ; > > >> >> Rajesh Bhagat ; Sahil Malhotra > > >> >> ; Shengzhou Liu ; > > >> >> Silvano Di Ninno ; sjg@chromium.org; u- > > >> >> boot@lists.denx.de; dl-uboot-imx ; Wasim Khan > > >> >> ; Ye Li ; Michael Walle > > >> >> > > >> >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support > > >> >> for CAAM Job ring driver model > > >> >> > > >> >> Caution: EXT Email > > >> >> > > >> >> > On 03.03.22 14:41, Gaurav Jain wrote: > > >> >> >> As we have not received any response from imx6dl_mamoj board > > >> maintainer. > > >> >> >> I propose the below solution > > >> >> >> > > >> >> >> --- a/arch/arm/mach-imx/Kconfig > > >> >> >> +++ b/arch/arm/mach-imx/Kconfig > > >> >> >> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN config IMX_HAB > > >> >> >> - select FSL_CAAM if HAS_CAAM > > >> >> >> - imply CMD_DEKBLOB if HAS_CAAM > > >> >> >> + imply FSL_CAAM if HAS_CAAM > > >> >> >> + imply CMD_DEKBLOB if FSL_CAAM > > >> >> >> Help > > >> >> >> > > >> >> > > > >> >> > IMO this is ok, I was also wrong, Marek is not the maintainer of > > >> >> > this board. This was the only board with broken build - let's > > >> >> > say, I will still wait a couple of days, and if there is no > > >> >> > comments, I will apply your series (but then V10). I can apply > > >> >> > this fix myself, no need to post the series again (I have not > > >> >> > seen any other comment or request to > > >> >> change). > > >> >> > > >> >> I don't understand why the solution isn't the same one as for the > > >> >> layerscape part in this series[1]: enable the config per board > > >> >> (that is your boards) and leave all others the same as before? > > >> > > > >> > imx6dl_mamoj caam driver is not enabled by any of my changes. > > >> > This board is enabling IMX_HAB which select FSL_CAAM. > > >> > Proposed changes making it imply so that FSL_CAAM can be disabled > > >> > in board defconfig. > > >> > > >> Ahh it was already selected before. But mhh, does IMX_HAB even makes > > >> sense without FSL_CAAM? Why was is a hard dependency before? > > > > > > With imply, this will still enable FSL_CAAM unless it is explicitly > > > disabled in defconfig. With select I do not have choice of disabling > > > FSL_CAAM in defconfig. Now I have disabled FSL_CAAM only for > > > imx6dl_mamoj_defconfig, as it is reporting spl size issues with caam > > > driver model approach. > >=20 > > I can see *what* you are doing, but that doesn't answer *why* it was a = hard > > dependency before and why now of a sudden can be a soft dependency. >=20 > I am not sure of any other dependency, but from the code ./arch/arm/mach-= imx/cmd_dek.c needs caam for blob_encap_dek operation for mx6, mx7, mx7ulp. > Making it soft dependency allows me to disable caam for imx6dl_mamoj. Yes, but can you reasonably, functionally, do that? Or are you just making things link but now the platform is non functional? Nothing that's an actual shell cmd should be linked in / included in the SPL binary (it should get discarded if built), but my recollection from migrating the HAB/CAAM symbols to Kconfig is that functionally you can't do what you're trying to do. --=20 Tom --q42DwHUcI5a+9iZz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmImIaQACgkQFHw5/5Y0 tyySwAv5Af1A3LLdAz3DDL0erjtNii+sVSQLx508/9Sxu0BUYkSdBHhdeZcAHhO+ 0hb9qNbiA2Aa+yxUxsHQ1gxHY3NUF0iaa00GVvxwwwSZY0imm8CEAP+E+8j6+tIZ Uy1QFGWLWJ+JQhevzOFKvn60nSlSPcV+gUV94shbDiHOO45wai0HFT51RR7lBIrT xggxjOnqPBjPUypIrafpdo+N8fm4vVpbMDQKai44bIVrwHX7RM/h7Vor7sP07ph4 gOAUUYn7npaG0iUt8+6UjnG/DlvDxH1IP0yIjymWJnEMfa7INZbIHLo9LJGxNFT4 7SPlDM2lY+6cQtu2Hq4G+EGfQVfdW7L8mcCKWGGxmkps+oExXXzd6S8NlZSyXTjb 0Rx9FdB1U3Z571pawv9O8ubcwCBNwD6lV9bCeLJkKQx65y9W62/lOqSKN/hMWPYj sjPdBFCA47FG8AGlU2CEYTnx0MNpG7YP2Le6glrMoCbKFyp8qAKZw5Ghmo+hwyFE 83rvUexX =zFgj -----END PGP SIGNATURE----- --q42DwHUcI5a+9iZz--