Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFC4CC433F5 for ; Mon, 7 Mar 2022 16:46:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2B74681277; Mon, 7 Mar 2022 17:46:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="hfauqHMq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B972881520; Mon, 7 Mar 2022 17:45:58 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EEE7E80078 for ; Mon, 7 Mar 2022 17:45:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from dellmb (unknown [IPv6:2001:1488:fffe:6:8747:7254:5571:3010]) by mail.nic.cz (Postfix) with ESMTPSA id 969C41412C4; Mon, 7 Mar 2022 17:45:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1646671554; bh=DJ8lUKrA0YsPQXDQ7Da4sxGJ3fE/iuUh2rCqQZesr+U=; h=Date:From:To; b=hfauqHMq3YKkNUmkKgIv/1gwGDk/3DNAYCPR0u4T5lnaqc54mQuIDmuAFNiXAJWXc BQnKOwAaB8Gj2c+WTegqjE90K701af1YJs66tzEy1cfn5SdYaTDx02ZmIFdD8L3+Sk HkWL7fdHdEM+FlEOfM6FVmeGIJoqZ3zWhoggh6Tg= Date: Mon, 7 Mar 2022 17:45:53 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Tony Dinh , U-Boot Mailing List Subject: Re: kwboot - positional tty argument Message-ID: <20220307174553.1a40c122@dellmb> In-Reply-To: References: <20220306123907.24798-1-pali@kernel.org> <20220307114047.ni4dahqwaxch7xoj@pali> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, 7 Mar 2022 15:39:33 +0100 Stefan Roese wrote: > On 3/7/22 12:40, Pali Roh=C3=A1r wrote: > > Hello! > >=20 > > On Sunday 06 March 2022 14:38:57 Tony Dinh wrote: =20 > >> Hi Pali, > >> > >> I have an observation, which is not related to this patch. But about > >> the kwboot options changes in general, I hope it is OK to mention it > >> here. > >> > >> Before the changes you've made to solve the problem with the -b > >> option, I can do this: > >> > >> kwboot -t -B 115200 /dev/ttyUSB0 -b uboot.kwb =20 > >=20 > > Interesting... I did not know that this kind of setup worked. It was not > > documented neither in usage nor in manpage. Normally in applications and > > scripts, all option arguments are before non-option (positional) > > argument. > > =20 > >> But now, the -b option can not be used after the tty device name. All > >> options must appear before the tty device. > >> > >> Is this the actual intention? it did break some of my existing > >> aliases/scripts (It is not a big deal to retrofit them). Just want to > >> make sure I understand the reason to make the tty device a positional > >> argument for kwboot. > >> > >> Thanks, > >> Tony =20 > >=20 > > Marek, Stefan, do you want to support above (old) handling of positional > > tty device argument to be present in the middle of option arguments? =20 >=20 > I personally don't... >=20 > > I think I can develop some "hack" patch for argv[] processing to support > > this operation. But my question is, if this is something which we want > > to officially support. Because if not, it is better to have separate > > option arguments and positional arguments like in any other application= . =20 >=20 > ... >=20 > The only case I can think of, is scripts that use the "incorrect" format > and might fail now. I don't have any such scripts and I would not object > to breaking this backward compatibility. Tony, what's your thinking on > this? Marek? I don't care. I only care whether I can use the -t flag after everything else, and I think this still works. Marek