Received: by 2002:a05:6512:204:0:0:0:0 with SMTP id a4csp1764494lfo; Mon, 7 Mar 2022 12:07:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwa6qwRWKUZT1F3cEMfc2PRTkOGLATcf4lohZ+AHMQtMWii1KAdseb3LhKxwtuZDeSgiQkY X-Received: by 2002:a0d:fa81:0:b0:2d6:faee:cbc4 with SMTP id k123-20020a0dfa81000000b002d6faeecbc4mr10228837ywf.388.1646683638575; Mon, 07 Mar 2022 12:07:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646683638; cv=none; d=google.com; s=arc-20160816; b=FGbOyydcORL4IF4H3wUr/OTqcZSwr6ni8Z+7o2ltYJ6ja/hnvb8hQWnTEYYCYh5Y9n fa+gr68FOnB6p6TvavUCS9yo0MqIgZnaRUjoU0UDE7gPKROuebkylG5LFkRnSuzKOWYv cLHw8wUYUd5D/8If+ylP3o3YRBl3lpiPn9/AYkOV/29iOxeZ7QFWpx3EhFBTFiD5rfsL uoorP2MnNZx203Veft7u6NktiJT3bCUzBvztj2j1hPEu8MNMXfEq9BmICBry19GXWFJs 4uptcF9QTd1apQaN6PFHNyoDzBhfRzfSPMArGNhVt8R0CxZCgxyZDyZSQFAX/NhgsPrI j4YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding:cc:to :from:subject:references:mime-version:message-id:in-reply-to:date :dkim-signature; bh=DFLEp4Au2YK6sqW100Dvh40Za2h5jBDX8hDsOCFY3nA=; b=LDQ7YfpbzWWaQPTb+vJleC12E/lJyTj6FAdz7mStS2bmvWG29IjZdiJIM+vc6DRkjv 3k+xyNwLePGg2ta53vdgsDx3ZQwfX6seSnqfvZQypFeOVlwm41juCr1Xt0KLSfscAp6k IUl3dpeDqxgmUacvQz0kowlpS0KncmIlrCdZvEnSWluW1S2P2veptb7GUVizD1HcN1xY N9JqsorIuUOqGxQoscpNOq8S9jWZIwxJChvHBZCSjAlUcidoj4L83jwuvxvQDiRY6KuI BCE0l/BQ586jRJpXgweZ2/5YRCe1rRelBIwjU5SADBh/f2abx/AQUEBmRWJSdtJkkbtJ 1ojg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=sah0XZFo; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j4-20020a258144000000b00628e50a7f5fsi5922930ybm.10.2022.03.07.12.07.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Mar 2022 12:07:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=sah0XZFo; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from localhost ([::1]:37186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRJdV-0007Je-VT for alex.bennee@linaro.org; Mon, 07 Mar 2022 15:07:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <312UmYgYKCFQF4FGED2AA270.yA8C08G-wD89A929G.AD2@flex--titusr.bounces.google.com>) id 1nRJd7-0006uB-Ih for qemu-arm@nongnu.org; Mon, 07 Mar 2022 15:06:53 -0500 Received: from [2607:f8b0:4864:20::b4a] (port=52807 helo=mail-yb1-xb4a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <312UmYgYKCFQF4FGED2AA270.yA8C08G-wD89A929G.AD2@flex--titusr.bounces.google.com>) id 1nRJd5-0006AL-Fx for qemu-arm@nongnu.org; Mon, 07 Mar 2022 15:06:52 -0500 Received: by mail-yb1-xb4a.google.com with SMTP id b11-20020a5b008b000000b00624ea481d55so14498910ybp.19 for ; Mon, 07 Mar 2022 12:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc:content-transfer-encoding; bh=DFLEp4Au2YK6sqW100Dvh40Za2h5jBDX8hDsOCFY3nA=; b=sah0XZFobUuI+nX7oWDSHtPpbC3WUTm1yejcvByzYxPLm8tCzcfpacwSqkCuU66+z8 HfTjD/NP7nmx13dMulblEpR332F9FtXkY4i81MrKdruDxu+BSXR5tgofhCGJq6c004V9 NT4PBavuN08AyRz11Pmybbj2aiU9rQ8EaClclpD5UJboecgkW9emN+Ulz3sPwtp1j01F 5OwQ9HbWdBSqgNNtiQYMitQdvh/mAwYOTRsf6vV/9VHanPFALOkiu7PeT1CTpCCbRl96 NQHV0ZPBNaQEVax7q6YVFVzEuVVYDmH1QIYVANxDmjul17BDLq1589cRCvMAkUotlFu8 0VNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc:content-transfer-encoding; bh=DFLEp4Au2YK6sqW100Dvh40Za2h5jBDX8hDsOCFY3nA=; b=kMWfESyAe/A4lS8MMAWdqP0XKRDOVYsXCvMvo/AL+/RG0pnjfmkwiKpVynqGHIz0ZA 5z/C5sEZgL6kj0DnJzxeRrx/0rO3HaeAlMj1flqRvrQqFyTYDcze9Tga9HnjsCjuAU3O 1Yd2gXKZFtP5FqMRVx5T4B6AFkyWRBvqPOPE+pS4EgVrDfYfjXJtexlizMbk62+TdpvH T5M+l/W7D7LIchGRCCUCuHbpCb+aPKGxNADCfJ+wE3sZPjIU/k3dSPkYtuS60+SPi1Qa YTa5qLljaf/ajSKo0GdZGgJkbxv0defLH++iwOQi3GaoFbA6g4zDclBu4uOSs+dkgYcz H+Gw== X-Gm-Message-State: AOAM531VzAFD9CuFzTkiXt+1iZi1v2R/w9X83gRb8mHDx1wGVhWu3tIR Wh7Z73CPbLT/lZvsrA1gtbxJ69sfyWk= X-Received: from titusr.svl.corp.google.com ([2620:15c:2a3:201:3c4a:fc8b:1418:53ce]) (user=titusr job=sendgmr) by 2002:a81:5dd5:0:b0:2dc:19cf:17ac with SMTP id r204-20020a815dd5000000b002dc19cf17acmr9940903ywb.312.1646683607906; Mon, 07 Mar 2022 12:06:47 -0800 (PST) Date: Mon, 7 Mar 2022 12:05:57 -0800 In-Reply-To: <20220307200605.4001451-1-titusr@google.com> Message-Id: <20220307200605.4001451-2-titusr@google.com> Mime-Version: 1.0 References: <20220307200605.4001451-1-titusr@google.com> X-Mailer: git-send-email 2.35.1.616.g0bdcbb4464-goog Subject: [PATCH v4 1/9] hw/i2c: pmbus: add registers From: Titus Rwantare To: Corey Minyard , "=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?=" Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, wuhaotsh@google.com, venture@google.com, Titus Rwantare Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::b4a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::b4a; envelope-from=312UmYgYKCFQF4FGED2AA270.yA8C08G-wD89A929G.AD2@flex--titusr.bounces.google.com; helo=mail-yb1-xb4a.google.com X-Spam_score_int: -81 X-Spam_score: -8.2 X-Spam_bar: -------- X-Spam_report: (-8.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DEF_DKIM_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: O0DANZ6Q5ed2 - add the VOUT_MIN and STATUS_MFR registers Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i2c/pmbus_device.c | 24 ++++++++++++++++++++++++ include/hw/i2c/pmbus_device.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 24f8f522d9..07a45c99f9 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -368,6 +368,14 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd) } break; =20 + case PMBUS_VOUT_MIN: /* R/W word */ + if (pmdev->pages[index].page_flags & PB_HAS_VOUT_RATING) { + pmbus_send16(pmdev, pmdev->pages[index].vout_min); + } else { + goto passthough; + } + break; + /* TODO: implement coefficients support */ =20 case PMBUS_POUT_MAX: /* R/W word */ @@ -708,6 +716,10 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd) pmbus_send8(pmdev, pmdev->pages[index].status_other); break; =20 + case PMBUS_STATUS_MFR_SPECIFIC: /* R/W byte */ + pmbus_send8(pmdev, pmdev->pages[index].status_mfr_specific); + break; + case PMBUS_READ_EIN: /* Read-Only block 5 bytes */ if (pmdev->pages[index].page_flags & PB_HAS_EIN) { pmbus_send(pmdev, pmdev->pages[index].read_ein, 5); @@ -1149,6 +1161,14 @@ static int pmbus_write_data(SMBusDevice *smd, uint8_= t *buf, uint8_t len) } break; =20 + case PMBUS_VOUT_MIN: /* R/W word */ + if (pmdev->pages[index].page_flags & PB_HAS_VOUT_RATING) { + pmdev->pages[index].vout_min =3D pmbus_receive16(pmdev); + } else { + goto passthrough; + } + break; + case PMBUS_POUT_MAX: /* R/W word */ if (pmdev->pages[index].page_flags & PB_HAS_VOUT) { pmdev->pages[index].pout_max =3D pmbus_receive16(pmdev); @@ -1482,6 +1502,10 @@ static int pmbus_write_data(SMBusDevice *smd, uint8_= t *buf, uint8_t len) pmdev->pages[index].status_other =3D pmbus_receive8(pmdev); break; =20 + case PMBUS_STATUS_MFR_SPECIFIC: /* R/W byte */ + pmdev->pages[index].status_mfr_specific =3D pmbus_receive8(pmdev); + break; + case PMBUS_PAGE_PLUS_READ: /* Block Read-only */ case PMBUS_CAPABILITY: /* Read-Only byte */ case PMBUS_COEFFICIENTS: /* Read-only block 5 bytes */ diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h index 62bd38c83f..72c0483149 100644 --- a/include/hw/i2c/pmbus_device.h +++ b/include/hw/i2c/pmbus_device.h @@ -43,6 +43,7 @@ enum pmbus_registers { PMBUS_VOUT_DROOP =3D 0x28, /* R/W word */ PMBUS_VOUT_SCALE_LOOP =3D 0x29, /* R/W word */ PMBUS_VOUT_SCALE_MONITOR =3D 0x2A, /* R/W word */ + PMBUS_VOUT_MIN =3D 0x2B, /* R/W word */ PMBUS_COEFFICIENTS =3D 0x30, /* Read-only block 5 bytes *= / PMBUS_POUT_MAX =3D 0x31, /* R/W word */ PMBUS_MAX_DUTY =3D 0x32, /* R/W word */ @@ -255,6 +256,7 @@ OBJECT_DECLARE_TYPE(PMBusDevice, PMBusDeviceClass, #define PB_HAS_TEMP3 BIT_ULL(42) #define PB_HAS_TEMP_RATING BIT_ULL(43) #define PB_HAS_MFR_INFO BIT_ULL(50) +#define PB_HAS_STATUS_MFR_SPECIFIC BIT_ULL(51) =20 struct PMBusDeviceClass { SMBusDeviceClass parent_class; @@ -295,6 +297,7 @@ typedef struct PMBusPage { uint16_t vout_droop; /* R/W word */ uint16_t vout_scale_loop; /* R/W word */ uint16_t vout_scale_monitor; /* R/W word */ + uint16_t vout_min; /* R/W word */ uint8_t coefficients[5]; /* Read-only block 5 bytes */ uint16_t pout_max; /* R/W word */ uint16_t max_duty; /* R/W word */ --=20 2.35.1.616.g0bdcbb4464-goog