Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2214CC433EF for ; Wed, 9 Mar 2022 11:10:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C6CD48339D; Wed, 9 Mar 2022 12:10:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2926682DB7; Wed, 9 Mar 2022 12:10:46 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 57B7382DB7 for ; Wed, 9 Mar 2022 12:10:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 885D11650; Wed, 9 Mar 2022 03:10:35 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBA003FA4D; Wed, 9 Mar 2022 03:10:34 -0800 (PST) Date: Wed, 9 Mar 2022 11:10:31 +0000 From: Andre Przywara To: andy.tang@nxp.com Cc: wd@denx.de, u-boot@lists.denx.de Subject: Re: [PATCH v2] armv8: layerscape: fix the function mismatch issue Message-ID: <20220309111031.576370fe@donnerap.cambridge.arm.com> In-Reply-To: <20220309073722.2670530-1-andy.tang@nxp.com> References: <20220309073722.2670530-1-andy.tang@nxp.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, 9 Mar 2022 15:37:22 +0800 andy.tang@nxp.com wrote: Hi Andy, > From: Yuantian Tang > > Signed-off-by: Yuantian Tang > --- > v2: update copyright year > > arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S b/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S > index d8803738f1..a40175cb3f 100644 > --- a/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S > +++ b/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0+ */ > /* > * (C) Copyright 2014-2015 Freescale Semiconductor > - * Copyright 2019 NXP > + * Copyright 2019-2022 NXP That would not be needed. The common opinion out there(TM) seems to be that the *end* of the copyright period is mostly irrelevant. One rationale is that it would only apply 75 years after the death of the author, whatever that means for "NXP". But also the copyright statement should only be updated when *significant* changes are made to the file (which are "copyright worthy"). Fixing a bug with a single line is definitely not in that category. If nothing else, this is just churn and tends to create pointless and annoying merge conflicts. I know that some projects like TF-A have a different opinion on that. I am trying to teach them for years now ;-) > * > * Extracted from armv8/start.S > */ > @@ -353,7 +353,7 @@ ENTRY(fsl_ocram_clear_ecc_err) > ldr x0, =DCSR_DCFG_MBEESR2 > str w1, [x0] > ret > -ENDPROC(fsl_ocram_init) > +ENDPROC(fsl_ocram_clear_ecc_err) That looks correct, so with the copyright change removed: Reviewed-by: Andre Przywara Cheers, Andre > #endif > > #ifdef CONFIG_FSL_LSCH3