Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 859E2C433EF for ; Thu, 10 Mar 2022 14:04:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 436FE83A75; Thu, 10 Mar 2022 15:04:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 818D183A75; Thu, 10 Mar 2022 15:04:45 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 23C6183AB8 for ; Thu, 10 Mar 2022 15:04:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3DD7F1691; Thu, 10 Mar 2022 06:04:34 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D2613F7D8; Thu, 10 Mar 2022 06:04:33 -0800 (PST) Date: Thu, 10 Mar 2022 14:04:31 +0000 From: Andre Przywara To: Tom Rini Cc: u-boot@lists.denx.de, Jagan Teki , Samuel Holland , Jernej Skrabec Subject: Re: [PATCH 02/15] arm: sunxi: Remove most SoC-specific config header files Message-ID: <20220310140431.110b5033@donnerap.cambridge.arm.com> In-Reply-To: <20220310133211.GL5020@bill-the-cat> References: <20220310014404.1251636-1-trini@konsulko.com> <20220310014404.1251636-2-trini@konsulko.com> <20220310105850.49d40718@donnerap.cambridge.arm.com> <20220310133211.GL5020@bill-the-cat> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 10 Mar 2022 08:32:11 -0500 Tom Rini wrote: > On Thu, Mar 10, 2022 at 10:58:50AM +0000, Andre Przywara wrote: > > On Wed, 9 Mar 2022 20:43:51 -0500 > > Tom Rini wrote: > > > > Hi Tom, > > > > > At this point, sunxi-common.h is used for all systems except for some > > > MACH_SUN50I variants. Remove the now basically empty header files and > > > update CONFIG_SYS_CONFIG_NAME to use sunxi-common.h directly. > > > > So is this #include the only > > user of this symbol? I was on the brink of removing those files several > > times already, but wasn't sure if that has side effects. > > I think buildman names use that as well, so we can't run "./buildman > > sun7i" anymore? > > If that's the only thing, I am fine with this. > > Yup, that's the only place it's used. > > > Actually the content of sun50i.h is bogus, since we don't define > > CONFIG_GICV2, so don't need the GIC addresses. > > So this can go as well, and SYS_CONFIG_NAME can maybe just become "sunxi"? > > > > Samuel, does this torpedo any RISC-V efforts? > > I'll do the move for v2 and keep an eye out if that's a problem for > RISC-V efforts. Thanks. I guess we can bring it back, if needed, or turn it upside down by including "sunxi-riscv.h" from sunxi.h, inside an #ifdef. Cheers, Andre