Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6DAFC433F5 for ; Wed, 16 Mar 2022 07:36:33 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nUOCc-0001v4-08; Wed, 16 Mar 2022 03:36:14 -0400 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1nUOCZ-0001uu-Bv for kernelnewbies@kernelnewbies.org; Wed, 16 Mar 2022 03:36:11 -0400 Received: by mail-io1-xd36.google.com with SMTP id d62so1357778iog.13 for ; Wed, 16 Mar 2022 00:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F9gjG03srQO/Dof6M2dHczRKqeWYZZPVoKngQXQ0HN4=; b=beyI21KzDUqQUu+Hka227XEORF2QJCWehK4sSpWP6SMyV3oSBv42TF7V/xmEyjDH93 xPcsaXYTAnZMcIs0TO5Df8K2GQlhhxD7suYm0ZCoxpqnahK9sUtcvlv1CwlozqEkKiYo hbvPcmC8k8dp/2HLIrmXJ2DsmiKbm8vU+VZb58mrH9CaShODAud5xfu2TYqG6uzPZP2E oiUtcPef8dbyByCUafy+OdDRDxLDm0ovXnynY4mmQcUD20SPcH4VgTOwodr/vYkNHlgx a3XGbFAeV+EAAxkoYUk4B0WFeAyFljp6GcXUMaWmzMjbZEXA+X6YRAMJi6v4h7QSRvj2 U+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F9gjG03srQO/Dof6M2dHczRKqeWYZZPVoKngQXQ0HN4=; b=7jUk0Ual8UoHJRlTBbVSIxXaNdBXpLHi7WrXq34LN3qqfkSe+BUvXFtylhavpG7INf 2bwkfc4e2nTXXtOhbtfFWiYKe7rnGpsUHhB3Vo617Gz5JuB+02+pzicWv3B+z/3xVjTn XX/AjoKP33A0FmKWWgdt3Ov1Wj9f9/c5cmFeDbCbfl5Z7VCVT9xUZRQ2vRa+4AA3zqGj 79elXvM9q8Q3bnr5sGkcW/nxvdqe8E0Bre6bD9wDf0seDjvTT0vZziWjydL4HEoCGpXA OkWX9aiT1j6yciDVapdwWnWzK0bgX4Cu46U8HtPX6eDi8YnCtbu7E+HbfhE7VA5trnZo NOOA== X-Gm-Message-State: AOAM53392qXdtmapdlaK3Q6YDEjjnAmyrp21JERbcwX02SHfGyW66LPj tqHzrtjbrWJNlgCEuBvQxx+ATSq/SPo= X-Google-Smtp-Source: ABdhPJzB5lidhX2DXbeAEw0cZk6Vd/apHsWoJdlTCQDwjdCmrHpoPpvqstSdUWDbdZLO2Nz1t6A1Qw== X-Received: by 2002:a05:6602:1682:b0:63d:cac5:fd0a with SMTP id s2-20020a056602168200b0063dcac5fd0amr24314753iow.132.1647416170116; Wed, 16 Mar 2022 00:36:10 -0700 (PDT) Received: from frodo.hsd1.co.comcast.net ([2601:284:8204:2010::f10e]) by smtp.googlemail.com with ESMTPSA id m5-20020a927105000000b002c60ed6d3afsm711640ilc.69.2022.03.16.00.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 00:36:09 -0700 (PDT) From: Jim Cromie To: kernelnewbies@kernelnewbies.org Subject: [PATCH] dogs - Date: Wed, 16 Mar 2022 01:36:06 -0600 Message-Id: <20220316073606.836341-1-jim.cromie@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Cc: Jim Cromie , jbaron@akamai.com X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org In an attempt to solve frictions in: https://lore.kernel.org/lkml/20220311044756.425777-3-jim.cromie@gmail.com/ And inspired by https://lwn.net/Articles/383362/ defines DOGS macro - an initialization expression, ie list of breeds, each contained by C, an inner macro, undefd when DOGS is defined. C gets 2 defs for 2 tasks: (each with preceding undef to reinforce the pattern) - initialize enum dog_enums = DOGS: C(a) DRM_UT_##a (must form a real token) - stringify each dog in DOGS: C(a) #a Then tries to repeat this macro-pattern in DEFINE_DYNAMIC_DEBUG_CLASSBITS. DOGS --> DRM_DEBUG_CATS C -> C reused for clarity Its close, but not quite right: - want to pass in init-construct once - expand it 2x, with 2 different defs for C() - cant nest #defines, cant redef for 2nd expansion. Is there a way to do this ? theres also some aspirational stuff in there, maybe it communicates / explains things better than this commit msg. Signed-off-by: Jim Cromie --- play/c-code/dogs.c | 149 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 149 insertions(+) create mode 100644 play/c-code/dogs.c diff --git a/play/c-code/dogs.c b/play/c-code/dogs.c new file mode 100644 index 0000000..7094982 --- /dev/null +++ b/play/c-code/dogs.c @@ -0,0 +1,149 @@ + +// see https://lwn.net/Articles/383362/ + +#define DOGS { C(JACK_RUSSELL), C(BULL_TERRIER), C(ITALIAN_GREYHOUND) } + +#undef C +#define C(a) ENUM_##a +enum dog_enums DOGS; + +#undef C +#define C(a) #a + +char *dog_strings[] = DOGS; +char *dog_to_string(enum dog_enums dog) +{ + return dog_strings[dog]; +} + + +// self-documenting help composition +#define DOCS { \ + _doc_( CORE, "extra core info"), \ + _doc_( DRIVER, "extra driver info"), \ + _doc_( KMS, "extra kms"), \ + } + +// 2 decomposers +#define _sym_(_sym, _help) DRM_synth_##_sym +#define _help_(_sym, _help) "enables " #_sym " messages - " _help + +// use sym to enumerate the symbols into the enum +#undef _doc_ +#define _doc_ _sym_ +enum cat_enums DOCS; + +// use -help- to initialize the doc-strings +#undef _doc_ +#define _doc_ _help_ +char *doc_helps[] = DOCS; +char *doc_to_string(enum cat_enums cat) +{ + return doc_helps[cat]; +} + +#define FLAGS_LEN 8 +struct dyndbg_classbits_param { + unsigned long *bits; /* ref to shared state */ + const char flags[FLAGS_LEN]; /* toggle these flags on bit-changes */ + const int classes[]; /* indexed by bitpos */ +}; + +#define _DPRINTK_SITE_UNCLASSED 15 + +#include +#include + +#define OP(s, state, x) BOOST_PP_CAT(state, x) +#define SEQ (b)(o)(o)(s)(t) + +enum foo { + BOOST_PP_SEQ_FOLD_LEFT(OP, BOOST_PP_SEQ_HEAD(SEQ), BOOST_PP_SEQ_TAIL(SEQ)) +}; + +// local copy +enum drm_debug_category { + DRM_UT_CORE, + DRM_UT_DRIVER, + DRM_UT_KMS, + DRM_UT_PRIME, + DRM_UT_ATOMIC, + DRM_UT_VBL, + DRM_UT_STATE, + DRM_UT_LEASE, + DRM_UT_DP, + DRM_UT_DRMRES, + DRM_UT_DEFAULT +}; + +#define DRM_UT_DEFAULT 15 +#define DRM_DEBUG_CATS { \ + C(_CORE), \ + C(_DRIVER), \ + C(_KMS), \ + C(_PRIME), \ + C(_ATOMIC), \ + C(_VBL), \ + C(_STATE), \ + C(_LEASE), \ + C(_DP), \ + C(_DRMRES), \ + C(_DEFAULT) \ + } + +#undef C +#define C(_cat) DRM_UT_##_cat // wo _ after UT get 2x decl on local copy +enum drm_dogs DRM_DEBUG_CATS; + + +/** + * DEFINE_DYNAMIC_DEBUG_CLASSBITS() - bitmap control of classed pr_debugs + * @sysname: sysfs-node name + * @_var: C-identifier of ulong holding bit-vector (Bits 0-14 are usable) + * @_flgs: string with dyndbg flags: 'p' and/or 'T', and maybe "fmlt" also. + * @desc: string summarizing the controls provided + * @classes: vector of callsite.class_id's (uint:4, 15 is reserved) + * + * This macro implements a DRM.debug API style bitmap, mapping bits + * 0-14 to classes of prdbg's, as initialized in their .class_id fields. + * @_flgs chooses the debug recipient; p - syslog, T - tracefs, and + * can include log decorations; m - module, f - function, l - line_num + */ + +#define DEFINE_DYNAMIC_DEBUG_CLASSBITS(fsname, _var, _flgs, desc, ...) \ + static struct dyndbg_classbits_param ddcats_##_var = { \ + .bits = &(_var), \ + .flags = _flgs, \ + .classes = { __VA_ARGS__ } \ + } + +#undef C +#define C(_cls) DRM_UT##_cls + +unsigned long __drm_debug; +DEFINE_DYNAMIC_DEBUG_CLASSBITS(debug, __drm_debug, "p", + "enable drm.debug categories - 1 bit per category", + DRM_DEBUG_CATS); + +#include +#define ARRAY_LEN(arr) (sizeof(arr) / sizeof(arr[0])) + +int main(int argc, char* argv) { + int i; + + printf("hello world: %s\n", + "" //BOOST_PP_SEQ_FOLD_LEFT(OP, BOOST_PP_SEQ_HEAD(SEQ), BOOST_PP_SEQ_TAIL(SEQ)) + ); + + for (i = 0; i < ARRAY_LEN(dog_strings); i++) { + printf("%d: %s %s\n", i, dog_strings[i], dog_to_string(i)); + } + + for (i = 0; i < ARRAY_LEN(doc_helps); i++) { + printf("%d: %s\n", i, doc_helps[i]); + } + + for (i = DRM_UT_CORE; i < DRM_UT_DEFAULT; i++) { + printf("%d: %s\n", i, ddcats___drm_debug.classes[i]); + } +} -- 2.35.1 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies