Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD66AC433F5 for ; Wed, 23 Mar 2022 13:00:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 757B083AEF; Wed, 23 Mar 2022 14:00:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="NcFEwcG1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6E2E883AEF; Wed, 23 Mar 2022 14:00:24 +0100 (CET) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42BD683B29 for ; Wed, 23 Mar 2022 14:00:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 39355CE1F26; Wed, 23 Mar 2022 13:00:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FCD2C340E8; Wed, 23 Mar 2022 13:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648040415; bh=MP3RvvprmPsYkzTDDXjXMzwaJ58vAgVKjl9H7ommX1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NcFEwcG1xc6XEev/VvwCj79bHDZuYoUO9SNyQuaMr2fJZ3WkBM7s9dgnCKsZQ/aKI tFG1j0kj50HJhOw+Bx9qqdMGf7GLLFs7CeOtF4QwFyu4iET3gUSJuH5YTH5u+nLJye ysJywVLLz6Vah5r67dRqRdaDT4e1kwz75RmZOnokqQAn4p03LLEFue0oS7RR2p6LVb VMbfXuW17cBkdUdQ9NtSEBYV/1ysnqJvWgIvBoxpJiV1KRIMRR1Ex9lfSUgN0dqRQA sQ6ZstoPG4/4VgZA0ArdHj5IgDSdCR8j0QWgA++bKkSeOQVYUhm/GGIi+5uR/HyGaL mnI5g2vEUkRbg== Received: by pali.im (Postfix) id 8349372A; Wed, 23 Mar 2022 14:00:12 +0100 (CET) Date: Wed, 23 Mar 2022 14:00:12 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek =?utf-8?B?QmVow7pu?= Cc: Stefan Roese , u-boot@lists.denx.de, Marek =?utf-8?B?QmVow7pu?= Subject: Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Message-ID: <20220323130012.vc424vvdalaesif3@pali> References: <20220322161759.24301-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220322161759.24301-1-kabel@kernel.org> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tuesday 22 March 2022 17:17:59 Marek Behún wrote: > From: Marek Behún > > Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from > upstream Linux kernel") ported Linux's device-tree files for Armada 3720 > SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus > voltage supply is described as a `phy-supply` property of connector > node, a mechanism that is not supported in U-Boot yet. > > For now, fix this by adding `vbus-supply` to usb3 node. > > Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") > Signed-off-by: Marek Behún Reviewed-by: Pali Rohár Btw, now I tested USB2.0 and USB3.0 ports on Espressobin v5 (another Armada 3720 board) and both are working fine in U-Boot. Therefore no USB fix is needed for Espressobin DTS file. > --- > Dear Stefan, as with the network issue, could we get this to master ASAP? > --- > arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi > index 2e05b973d2..28a36a6103 100644 > --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi > +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi > @@ -21,3 +21,7 @@ > }; > > /delete-node/ &mdio; > + > +&usb3 { > + vbus-supply = <&exp_usb3_vbus>; > +}; > -- > 2.34.1 >