Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F7EBC433EF for ; Fri, 25 Mar 2022 20:42:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 61A3D839B6; Fri, 25 Mar 2022 21:42:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GS6agmSW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B9F59839A7; Fri, 25 Mar 2022 21:42:34 +0100 (CET) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E391A840A9 for ; Fri, 25 Mar 2022 21:42:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id i65so6904200qkd.7 for ; Fri, 25 Mar 2022 13:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zh9J0s9kTQHz7obaDL4M2ajXAt1Q9+7Z/1vg1ZRFl/E=; b=GS6agmSWk2zNDJvSXvaXU9iF8N4YLOE4a0L3LnaYP+CiJ6JjxvCoO1T67Zjaf3HQJs Xz5+ACLpwjQ07DJC/2cVtjoEZQYtixKvR5UekEU9UgbxPsWrCBsR6f546voJB9tRYVdr rj4OZ4du5lC4kdi+JKpX03xwqoqoGqolN6Oo4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zh9J0s9kTQHz7obaDL4M2ajXAt1Q9+7Z/1vg1ZRFl/E=; b=WbCzbdKNbbQodMTH3xkCHJQre029mZp/YBVU8XgYIwMkXt0EuNUPWm84HVFZj4CM5d MHqOs+9otesM9BUoNz1+bmYPU9nqmjFVHuKMFGaNpKABlvV50XjsjaYaTb9KCWTU4fBD opOcrLYhT3TjX8ekZQUmqMuNgnoPqMA3tHgBj+6tCy2bGcBzI9s54G6mZg7lO16PidU4 IOpuOaNF9ccbLtgK8S4YaVckHWNPTHXuLloH1IeRVE9hy1o5zq4mgUaBaLWFoa3RinoA pIASLp/VUmODH4dXPBzY7hBbTqGc+G0QJFAMqubNEtn5K50uBjqeitJ+MGRnnbTcje9V QhgQ== X-Gm-Message-State: AOAM532BTUd4l60+1xcbwzJG2nwqdnf0583uSLLoe5BkoQd4Nn8KL/Ar ZLtgjuhhLQszEOdg3x8kPCLxFw== X-Google-Smtp-Source: ABdhPJzsKSkIrMlhhs5Wt0nGrA0b6puBdVtA72wu9O26QcgLa2XMQVbQxmiLzkU0wlh+BkxWORBKkg== X-Received: by 2002:a37:6504:0:b0:67e:3194:db63 with SMTP id z4-20020a376504000000b0067e3194db63mr8247650qkb.127.1648240950602; Fri, 25 Mar 2022 13:42:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id f8-20020ac859c8000000b002e232e04cafsm6225049qtf.88.2022.03.25.13.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 13:42:29 -0700 (PDT) Date: Fri, 25 Mar 2022 16:42:27 -0400 From: Tom Rini To: Sam Shih Cc: Ryder Lee , Weijie Gao , Chunfeng Yun , GSS_MTK_Uboot_upstream , u-boot@lists.denx.de Subject: Re: [1/3] pinctrl: mediatek: rewrite mtk_pinconf_set and related functions Message-ID: <20220325204227.GA2226424@bill-the-cat> References: <20220310043145.7690-1-sam.shih@mediatek.com> <20220310043145.7690-2-sam.shih@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ft28ptjda1JCgATz" Content-Disposition: inline In-Reply-To: <20220310043145.7690-2-sam.shih@mediatek.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --ft28ptjda1JCgATz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 10, 2022 at 12:31:43PM +0800, Sam Shih wrote: > There are many pins in a SoCs, and different pin may belong > to different "io_type", For example: some pins of MT7622 belongs > to "io_type A", the other belongs to "io_type B", and pinctrl "V0" > means handle pinconf via "io_type A" or "io_type B", so SoCs that > contain "io_type A" and "io_type B" pins, use "V0" in pinctrl driver. >=20 > This patch separates the implementation of register operations > (e.g: "bias-pull-up/down", "driving" and "input-enable") into > different functions, and lets the original V0/V1 > ops to call the new functions. >=20 > Signed-off-by: Sam Shih This series breaks mt7623a_unielec_u7623_02 and other mediatek platforms, please retest and resubmit, thanks. --=20 Tom --ft28ptjda1JCgATz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmI+KS0ACgkQFHw5/5Y0 tyzZUwwAmnksfn4uMnjgZTqpxRQxPsKx0CXycn20L5vXhEsrqhLX3LUfdJZaNhoy +yo94Hfai4cPLHfIMFo5/q9phTf9j/1PTucoKTHb4CggWZt2pKUn50vase6irjSL 6/T96ZeLk9OyDi5jalPkIjbSGFk0iut04OkGAzNqxWkoGXzLrfRTgxm65kWuenFu MlkI23JbC1qkxy7pQGiHs16w1HCa9f4zbCP/cQmlnv9KPKZz6DSidrDhqjxQ7G5t 86Ob1c7o6VinAlzaPTDXOoE5ZjP//lZ6965MlOcD+le7zfIj7kmCtf6RqkbWh1mC 4gM2f7aZgxzaIWqDmuouChhR6fDKXmzcBzojuUUsg2jkNNWv+aHeJ855mwXW+fu4 d8ay2q+gsdY7pEbtTEKtM0b2eWMm1telDo/OBGV/ViDDX6RxyqP+3X6Jqn4njmpl bM2a3rmb0nqYRBEfPHIRqIQGSozdTt3Xm4QYgFcvvk79XYW5PglVlDotYfYoWXfT 5gFGJD7K =PuGB -----END PGP SIGNATURE----- --ft28ptjda1JCgATz--