Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nYjNX-0001Zi-8y for mharc-grub-devel@gnu.org; Mon, 28 Mar 2022 03:01:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYjNS-0001U3-0O for grub-devel@gnu.org; Mon, 28 Mar 2022 03:01:22 -0400 Received: from de-smtp-delivery-102.mimecast.com ([194.104.109.102]:35788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYjNQ-0003Yu-99 for grub-devel@gnu.org; Mon, 28 Mar 2022 03:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1648450878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOivJRzTc2waZb2wgFig/iXW2EYSH7SFYLm79kOCJow=; b=KjxqHwGpQA/1peezB2gIvaljeIN5y8UNm12vGdpWMHsVR9zvqQuLZ09Fwrjyb1uOfrhLP8 69e6pn+qsKwYuw2CSj+HopU0jhTKyfr9EdsL+OIDmYz+zGsbepI5CMwSTS3iJz4EFmqgud +6RZS168wW2ROE10RBwa3i+gu1JFQhQ= Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2056.outbound.protection.outlook.com [104.47.1.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-5f8v_mRZO-GlDRJnt6gzpw-2; Mon, 28 Mar 2022 09:01:17 +0200 X-MC-Unique: 5f8v_mRZO-GlDRJnt6gzpw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SWN1r70dQPHpTgE6B7b7PEdOWeFTjoKSKRH/kV6K2uBISrl/jA6TdauQsm02WkwEMl0sPBMLX7Scr431jsVB55M9eORNUCUpzVxSuZLF4VhshmFQCpriWY80r+dhbubQX5nI61qeJIbgUJw2/2lGF6mJ6AQ8NiDBJmSHxJmFPDeFUlqF52R7o3619dPLyfIz7S1jf0XD+1yzeCqX1sEo5kGGYqdNzHw2/ocy38tjAzalAtkNZvvARwSnDq04pS4VR3PwxEHHH3plt/PJRM81BZn6q7DHECjqTFTYN9Zdyzj0x1HmDYG9ozOqvH8GWav5VxDxIhlR0tWJa9gE5a/3rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UQxEUmbr3DiyCX4nDx5ej04O2eqNuzK7ZA1lzSiwGPQ=; b=hMFnu7JcNmL8RR6198wKfnEse/S0nfQmkHxOhcZxu6chNt/OcUI9PSP8u6a6jJKn6CVy51h/Vi6et5/O9YQFvpa+ELWya4Jigpcs94ntdBlU9DKDfB73i3Wm5M8BF4w4rD9kbIA3j3WPgj2a/lIT0ZBcoSM/zbu7GcieoXFToz8KJOlWvdA2HBZUDGUV9FsaKM0frOdR9lVorP0lnAv0dtFiqsdmilf0sgzRNyEYJeD5ylQATLKnQ51e94669jvXuNA0JIJTsYmmyTWxTAV3LrOdzhtmJTnLjvwvVRIej7vOt1TcBEN9JtR5EaOfGlSapsLtHVHmr6IgTURzE75ZsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) by VI1PR04MB5949.eurprd04.prod.outlook.com (2603:10a6:803:da::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.22; Mon, 28 Mar 2022 07:01:17 +0000 Received: from DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::2d29:445:cc37:a97f]) by DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::2d29:445:cc37:a97f%4]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 07:01:17 +0000 From: Michael Chang To: grub-devel@gnu.org Subject: [PATCH v2 3/3] reed_solomon: Fix array subscript 0 is outside array bounds Date: Mon, 28 Mar 2022 15:00:54 +0800 Message-ID: <20220328070054.13497-4-mchang@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220328070054.13497-1-mchang@suse.com> References: <20220328070054.13497-1-mchang@suse.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-ClientProxiedBy: HK2PR02CA0221.apcprd02.prod.outlook.com (2603:1096:201:20::33) To DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f5c793c-ec16-43ba-8812-08da1088c131 X-MS-TrafficTypeDiagnostic: VI1PR04MB5949:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: frU8nqG4j3oXoQBjNis3oCs+chgat1vZVVpKR50/oq9rRo0LrXOqPNd//SVOpuNaFyK6ZiLKGMyXnefx5nvOoGEhquJbeR/7K7xHNmsHbK5KYvW02j3ca3o+dJIuC4Eg5RFooYZbfcGBk5RLOhfEbWMAwrlt8ABVDr0/ukCc+Qz6hGW3xY+luUHd0NF1zmsiJ13TK9lN7wsfsmSrelcZwqCZl5C/Ytrk6LXFtgrUpZj3/+vx3xJkR65/D0Sq5kxd+bHrYM8DvpP5oQH7U/UUHQgdIIPa76pvqfNPPcAKhnvrrJt5XYycZVe6ASpGr+u6PDqjkGfO0I7Ox1VQHG07xMvaNIbCxs2O2jvQo+oO7Gfu88RZMfzafysK4ux5TiOaGUz5qeIPj1X2sqx55HbBUwSvvDL5IpxKAt+NscUWYGcxerFbVuHydBmYXoCf48QVEqFB/d9YxzYfux5bGWrjQa27uAZhk3J11YLDkjT1NbgZuXaDOaNh04DylWA6dSFIqh+BwgihOp2LQCpYrEozFHBiO+ZmkWl1FOOYrqRClzNfuXxKYPq8r3BLOOhbEa7063OSM8Z+NhhohhBxb+7cjtoj0luOEWa+IorBJfcwPvJUZ0NNEopF0Y9icAaK8wOQBHwiJfTH+FUAwaOADE01aA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB9081.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66556008)(66476007)(66946007)(1076003)(5660300002)(6486002)(186003)(8676002)(508600001)(83380400001)(6916009)(6666004)(86362001)(316002)(2616005)(6506007)(2906002)(6512007)(8936002)(36756003)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AjzVgM+DjAvDlpQWGfRD11mhC3DhE30X55IRTR/ccPttotjd4KM98ZC08Eup?= =?us-ascii?Q?h9yoTkeu77ivrN+1C87Rg1DtvlTMhQhw5LBh8hXS6ZZWoNbRZrn+M2mXBywD?= =?us-ascii?Q?24BoKJ760x9IKc24L4wrdBoYSra2flbkj7Ohm5KugxYLfVjJSTTWg7W1XTW0?= =?us-ascii?Q?1HHlnUtK7lc2ftvd2W2nSMSTmTh4WQyUjEv8szl4SWIaURSVtDaC0RYuPy3P?= =?us-ascii?Q?OU2vOySS5vIS6gdFnTf+icphcYa+xKReBemTYUT+9GRJwQJV9ZJUPrKi9wZL?= =?us-ascii?Q?swE29IAys/vBE0lJR4t91hI3q03+g/SLnCsknulHSepR1zJGY9MDfBEEJy+y?= =?us-ascii?Q?xVPxAX9e0AAym6q18P+qXWbEBacfFwfZXeinPaEu+SroG4OAO+fRxmP3dR1U?= =?us-ascii?Q?G7ahzEzPc2256AW85gLEkBF5iq3z/vWJEvJyFM7WB9Poyn/wrM/uPekZ7amx?= =?us-ascii?Q?K9FZA5mDFbVC63+oft0z3IZKmRaMgIJBjDpfT2rE0r7ZbD4/VoHxt11ub21e?= =?us-ascii?Q?ugXBwTK5VPnHCxiTb7UKOhLI1/6EytxT/w6W/+tviLVd78VrpXvmVYFguu/v?= =?us-ascii?Q?al7Rv80s+2mYzwToDoPdm6CY0LQmaItosj/qJE1BEByechpXhB0Zjl/OSufe?= =?us-ascii?Q?lMcjbmbFzPtZir1hqPn70UVUOKZvXOMb0NAmBuyaKMAySYvmulzmnqwXY//7?= =?us-ascii?Q?VPvzcouvlZfAdJ1jD0RDW4gWV6M2DwwOlctk/+GpKjxvGxAkxiv9mxthmPox?= =?us-ascii?Q?DhnhBuWr3AHF8e8Gacfm2/XXJDrgDpsL5yiNWg/K4PrAk0vqU+Cl++4w/2TJ?= =?us-ascii?Q?y40VF5ON+/l4TsMGwxzGhRal8PvZm6vI9s7GXb3FBk5HqcEtKUcaTpOTCNxI?= =?us-ascii?Q?rxESsVZRh2AuPqTCKbc5bAalQFAcvoH9ekueI782anjR+Z9clTn5A4UI8HCy?= =?us-ascii?Q?aQPUYHGSH52I9nAP3MSNa2t+m5cFaaHhf88kTNvlZnWy6XgCKozMz86n7PS1?= =?us-ascii?Q?dOHBvVFcNfW3A7MRgkoRkv2vGenlSgG/BFAk1+xZCPMR9Bhtdds/ctW6kqAD?= =?us-ascii?Q?HgwdQMe+AvcTs8NR8Ya4qQifs08d5DZ6mEhvC7Tqa2WRE/IJsCVROLgTCFyO?= =?us-ascii?Q?+VlSkHMt1YbGu5ZOCVMNd/86w6GTYY48BnCnrJDGmCdgMFkMj5kcJIlqNIIZ?= =?us-ascii?Q?GtjrX+UNp8gJSAp6iurPFIrkc/nj+TuXfRnJDeVYxf6eMMrkpt/vX8MXBZyh?= =?us-ascii?Q?ogxesCoeiLSCZaAqGcnRGwRqyeu9/KzQkatmGjWgCfLITZLA5OUb5q8FTDnA?= =?us-ascii?Q?mW8XMGGUY7ge0YK+gveEZDMAaVyDJacOjsi+bFVaZNDID3ODnFG+Vd1pp71y?= =?us-ascii?Q?aADXbmxUW/9X3vyq4S4DRil4+sI0fa6wjJrwiwQDgvyT+R1Va70Wcrne+FCC?= =?us-ascii?Q?pkZjacX+JJlvZykTKBs6gN3N/SvOlGCtlNBKNFhiNTMLgmFla7f2pGfhAbS9?= =?us-ascii?Q?0mO2n7mh7zhFYy98p5lKoot3GLfuT4TWJwp6OrGROV2LzmQg2jlvnO7U2AA7?= =?us-ascii?Q?2bxN7rORn3+uhtRJOZBOdupTjtDCxTXxkRz6O++SN8s0zGTfET97penofxOC?= =?us-ascii?Q?S4qw+0iowlr+h5vA0oLNVK0XC7GSTbJq3klRHfhBhJ3n/0ymXmIqzDxWUcuH?= =?us-ascii?Q?EdrWEQdIxvNDq1aX81lvFyHJQy9tFGH/ojfXZsDV9jDSOQh/29aVlS5csJ/E?= =?us-ascii?Q?g021L1UpFKfweq6ieiaKa77nQxYqPe1wkMI6nC+SedJWxB574ejeMTxE0cpD?= X-MS-Exchange-AntiSpam-MessageData-1: WCFR/XoXPv06zA== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f5c793c-ec16-43ba-8812-08da1088c131 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 07:01:17.0285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qrwdzwnudNYqIssDJw8bcOdH7xSAdSKU+uMwSgp4smShHrDrB7F+23uKTzrrrisk X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5949 Received-SPF: pass client-ip=194.104.109.102; envelope-from=mchang@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 07:01:22 -0000 The grub_absolute_pointer() is a compound expression that can only work within a function. We are out of luck here when the pointer variables require global definition due to ATTRIBUTE_TEXT that have to use fully initialized global definition because of the way linkers work. static gf_single_t * const gf_powx ATTRIBUTE_TEXT =3D (void *) 0x100000; For the reason given above, use gcc diagnostic pragmas to suppress the array-bounds warning. Signed-off-by: Michael Chang Reviewed-by: Daniel Kiper --- grub-core/lib/reed_solomon.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/grub-core/lib/reed_solomon.c b/grub-core/lib/reed_solomon.c index 82779a296b..562bd2e3e3 100644 --- a/grub-core/lib/reed_solomon.c +++ b/grub-core/lib/reed_solomon.c @@ -102,6 +102,11 @@ static gf_single_t errvals[256]; static gf_single_t eqstat[65536 + 256]; #endif =20 +#if __GNUC__ =3D=3D 12 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Warray-bounds" +#endif + static gf_single_t gf_mul (gf_single_t a, gf_single_t b) { @@ -319,6 +324,10 @@ decode_block (gf_single_t *ptr, grub_size_t s, } } =20 +#if __GNUC__ =3D=3D 12 +#pragma GCC diagnostic pop +#endif + #if !defined (STANDALONE) static void encode_block (gf_single_t *ptr, grub_size_t s, --=20 2.34.1