Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B00AC433F5 for ; Wed, 30 Mar 2022 12:29:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AD5C684064; Wed, 30 Mar 2022 14:29:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DcA8YNNH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A99584064; Wed, 30 Mar 2022 14:29:37 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F364C84053 for ; Wed, 30 Mar 2022 14:29:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id t7so17841974qta.10 for ; Wed, 30 Mar 2022 05:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vz5icOoexFhJmBpzB+q2fXw4c7RtxVfW77qj+kpxZr4=; b=DcA8YNNH86Bk3SJ1rW+PsyVtxP1g45tX3hxHWSNhOzMqMBhgoY4PX4Mlw08bRMpcXo 3jnFt+z81GjYIKrcnsEc94H2SxwhvUHmuypXGkO69RnCaBAed6AwAXmUj9pFuUX+BsIM GgL+4LXWCCS9SPscVxG5VP657zUsavWLPkgtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vz5icOoexFhJmBpzB+q2fXw4c7RtxVfW77qj+kpxZr4=; b=qvDgc4G6ixjKwYsvOY6vkWQUnabfSIDH/x9ZM222ZjVX37WAB9+riuz+RKEAUY7Owq CNchuP5RXhq9EqlwcA3UM9dwEShcaNX6dl+3+83xU7QO8XhgzZ4OHqeiTdVAxQA1R6lt 7UdkKhwPdf4NVBFTTMQH3A9oySTsP0Us99syvmIlEqZwQWzTFenOejdT2b/OTbPm+5cd 207sF+hAp6pr35u9AHNMcFQh6Fxgsc6C3kjMp9EMN4wrBvueeQ3R/CHnA3S9FhSJ5SK9 /CmX66A5pIuEVX5GK+etV3OaTHC8k4t3AzTFFvu9sh81880iJtnI31G/WJP4XBOsDsfG 2ZcQ== X-Gm-Message-State: AOAM533MkP2F1pbRkO7fPMkfZvLy8K7Q+sdFroTJFjjs1NMmgZ17RC7w U7MkyN9PKqlJ0UrxGNKIkOi+9Q== X-Google-Smtp-Source: ABdhPJxCdYDSzXdXKFMzaBmGwslagFAORy9/SHPWBKBciMDanZbgHgFpsh7SFucGnw5dkJv/VnONxQ== X-Received: by 2002:ac8:5b92:0:b0:2e1:e454:7fd7 with SMTP id a18-20020ac85b92000000b002e1e4547fd7mr32319786qta.667.1648643360677; Wed, 30 Mar 2022 05:29:20 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id f14-20020ac8068e000000b002dd1bc00eadsm15742107qth.93.2022.03.30.05.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 05:29:19 -0700 (PDT) Date: Wed, 30 Mar 2022 08:29:17 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Priyanka Jain , Wolfgang Denk , u-boot@lists.denx.de Subject: Re: Broken P2020 board since commit be7dbb60c5bf ("Convert CONFIG_SYS_IMMR to Kconfig") Message-ID: <20220330122917.GP14476@bill-the-cat> References: <20220330122028.jrcdywdg7j2g2usd@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="45wMVEkw4XUbiYON" Content-Disposition: inline In-Reply-To: <20220330122028.jrcdywdg7j2g2usd@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --45wMVEkw4XUbiYON Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 30, 2022 at 02:20:28PM +0200, Pali Roh=E1r wrote: > Hello! >=20 > In current master branch is U-Boot for P2020 board (powerpc mpc85xx > based) built by P2020RDB-PC_SDCARD_defconfig completely broken. U-Boot > does not work at all and on UART is nothing printed. >=20 > I run git bisect and it found commit which broke this P2020 board: >=20 > be7dbb60c5bfa38ea444fe7de1dca8bd35f83f5b is the first bad commit > commit be7dbb60c5bfa38ea444fe7de1dca8bd35f83f5b > Author: Tom Rini > Date: Sun Dec 12 22:12:30 2021 -0500 >=20 > Convert CONFIG_SYS_IMMR to Kconfig >=20 > This converts the following to Kconfig: > CONFIG_SYS_IMMR >=20 > We do this by consolidating the SYS_IMMR options we have and provid= ing > defaults. >=20 > We also, in the few places where M68K was also sharing code with th= ese > platforms, define it within the file to CONFIG_SYS_MBAR to match us= age. > This should be cleaned up longer term. >=20 > Signed-off-by: Tom Rini >=20 > :040000 040000 12f819284e85d64b7df5da65476038a542e587f5 ea3da4aefeee93f= 1566be6b7f85a43846f29aa8b M arch > :040000 040000 afe083b1f22b57470532d2a2c3c37b6a5d4a68d4 302d04810c94496= 22ce43982f562d2e8400086ec M configs > :040000 040000 411b7912fc83c8aaf25adf5647400625793cee38 0eff4a6f6e7b5f2= 1bc3d533e1c5bc1cd2a5ed86b M drivers > :040000 040000 b7d8b45f803b3619f76be355193d5c5645e76782 be2ac1c8506e99d= 1f9c615ad09477884f5ce1231 M include >=20 > So it is relatively new change (Dec 2021). >=20 > Tom, any idea how this commit could broke P2020 board which is mpc85xx > platform? I do not see nothing suspicious in this commit. Before this > commit BootROM can successfully boot SPL without any issues and SPL > prints info on UART. This board use include/configs/p1_p2_rdb_pc.h > config file and it was not touched at all. >=20 > Priyanka, Wolfgang, you are marked as maintainers, do you know how to > debug this issue? Or do you have some P2020 board or other mpc85xx > based, so you could test if U-Boot is working on this platform? >=20 >=20 > For reference I built U-Boot SPL by these commands: >=20 > make CROSS_COMPILE=3Dpowerpc-linux-gnuspe- P2020RDB-PC_SDCARD_defconfig s= pl/u-boot-spl.bin > boot_format config_sram_p2020rdb.dat spl/u-boot-spl.bin -spi u-boot.sdcar= d.bin >=20 > boot_format and config_sram_p2020rdb.dat are taken from the upstream git > repo from the latest branch nxp/sdk-v2.0.x: > https://source.codeaurora.org/external/qoriq/qoriq-yocto-sdk/boot-format >=20 > u-boot.sdcard.bin is then copied to SD card (starting from sector zero). The likely answer is that one of the sets of games PowerPC platforms play so that "SPL", "TPL" and regular U-Boot to do redefine some symbols / base addresses didn't get migrated correctly. Or, re-reading that commit, maybe what I had worked out wasn't right, and CONFIG_SYS_IMMR=3D0xff700000 is wrong? --=20 Tom --45wMVEkw4XUbiYON Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJETRoACgkQFHw5/5Y0 tyzVMgv8Cas7VUpW1kSCan/U/jPIITluCgp6NFxUSm4T/2KL3njHR3H13XA6FUvb RQC5G3vy4dMtKMvdVM9rDBb2wDe+saHjGSBOyH4LEchAdAPa2DUmlbRj/Bi11V24 92OLtqW7Ze4Mq92kgtB9amtVwj/LXTLMFj9NSfIDEYbyt5IBGH1gopekVBxgLm8/ MQwhh1PGcl9HIJcWZzpZhcdWVUfJpheHqiwRgMayuQEvwzbvdJiT1cafLmu26LCw bBcQwNASEq08YEsqcKqwtXUE8vaFtnbiOlZK6EJSDGRF0xaedsgOoXxT1q6q9qF1 MeIWZK8SsFM2+KCSN0F8bO/2A9NBoxnmgFykvGnT4IFORJojyCh8NCDoXn3ds+bU /EXKLb0GX1iZMatdihFV4SPlhjxaR9MvmgEF3RE3L5nT+kdcj4/OWVaYWAjK7ub/ vBy4tBdT2wyprg5QsdkaGHXYSZXWPr6m61ePx55dqKyD3C3uwrsv9PbphWzbB43L /0zLb1ix =LS5D -----END PGP SIGNATURE----- --45wMVEkw4XUbiYON--