Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AF9DC433F5 for ; Thu, 31 Mar 2022 08:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=sOiXcIYPD9epTBfXUo6STXJi2v1rswD6Y2YEEguKyqg=; b=sz8a1OqcgkdJ2q GrmkA/JtlShI/lv8+FPNCLFsFROMypWQsqJImR2zE84ngaug5uS/WYloakhJp5+Wh/LSHylvU0s6A /tbkr4WdN49mo9zv8vwarX3GgeLpSASyI6QOO0QMzH+zW8bADTCGj09mpqLShTjrpbGFbNzFLMYlA Mc2jS5n5edYtgrxljhqsZe23iHOOuMDuc5Y2HhseRyD0ZqQWou4trUlzilD5YDBJ9IlthjOyqFz6B 1NGqxGdVQgIm9tNkn8wcFYz72vuWhtjlfEcTElTu0yKcqMIg6zUOWedk7tWmN2yX4zqpePfeBO36e g1sn0cBwDHbOYfZLmglQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZqTO-001M7h-95; Thu, 31 Mar 2022 08:48:06 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZqTK-001M6B-2k for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 08:48:03 +0000 Received: from grover.. (133-32-177-133.west.xps.vectant.ne.jp [133.32.177.133]) (authenticated) by conuserg-07.nifty.com with ESMTP id 22V8lTVu003697; Thu, 31 Mar 2022 17:47:29 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com 22V8lTVu003697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1648716450; bh=gGJuNtZNlK31EyvN6aKIUPmZ7sjtipQdD25VkZOOOCc=; h=From:To:Cc:Subject:Date:From; b=rhYAFo8ei45If/CuJ5HR8u2dnVvZ08GiqGLaoczoXz7rFPV3QkIvV97Gh2YSQ7pmw uZLlDBkluCfe97IeemZkfBwq0hTp1C+HmS+5XL0dyRbn9C42Cj0h72ZKVdK0P7tbeW MWFBqothqXfeFMtBFejY4M+zO5a/Nr/vkFQ/LQSSCJnFl2qcrGeIOrAryV4DDAVQzE H78GFsvKTs/pOPFwREjJNQtE77QIeVngD1ZSDH/jRTfyAT1xgJgOuxm969trEA46oG TaE3oDFJrNGlQbQsl3i7eCjXPNp3/1QPPfJtkPaZNsx5DyG9FXvs0VxwTgJBeR2cUt Gf9rfexlO2VoA== X-Nifty-SrcIP: [133.32.177.133] From: Masahiro Yamada To: patches@arm.linux.org.uk Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Russell King , Arnd Bergmann , David Heidelberg , Nicolas Schier , Russell King , linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: decompressor: fix unneeded rebuilds of library objects Date: Thu, 31 Mar 2022 17:47:09 +0900 Message-Id: <20220331084709.1079362-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_014802_494012_FD2F3DD5 X-CRM114-Status: GOOD ( 10.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since commit 251cc826be7d ("ARM: 9154/1: decompressor: do not copy source files while building"), the following three are rebuilt every time. AS arch/arm/boot/compressed/lib1funcs.o AS arch/arm/boot/compressed/ashldi3.o AS arch/arm/boot/compressed/bswapsdi2.o Move the "OBJS += ..." line up so these objects are added to 'targets'. Fixes: 251cc826be7d ("ARM: 9154/1: decompressor: do not copy source files while building") Reported-by: Russell King (Oracle) Signed-off-by: Masahiro Yamada --- KernelVersion: v5.17 arch/arm/boot/compressed/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index 954eee8a785a..e65c7ad5dd4c 100644 --- a/arch/arm/boot/compressed/Makefile +++ b/arch/arm/boot/compressed/Makefile @@ -97,6 +97,8 @@ endif $(foreach o, $(libfdt_objs) atags_to_fdt.o fdt_check_mem_start.o, \ $(eval CFLAGS_$(o) := -I $(srctree)/scripts/dtc/libfdt -fno-stack-protector)) +OBJS += lib1funcs.o ashldi3.o bswapsdi2.o + targets := vmlinux vmlinux.lds piggy_data piggy.o \ head.o $(OBJS) @@ -130,8 +132,6 @@ endif # Next argument is a linker script LDFLAGS_vmlinux += -T -OBJS += lib1funcs.o ashldi3.o bswapsdi2.o - # We need to prevent any GOTOFF relocs being used with references # to symbols in the .bss section since we cannot relocate them # independently from the rest at run time. This can be achieved by -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel