Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62560C433F5 for ; Thu, 31 Mar 2022 13:39:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BB74284239; Thu, 31 Mar 2022 15:39:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="H2Qju053"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E2A5B8421A; Thu, 31 Mar 2022 15:39:13 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A3F0184217 for ; Thu, 31 Mar 2022 15:39:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id p25so19705372qkj.10 for ; Thu, 31 Mar 2022 06:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wdrP3EBOw/3H7ln1gECvcaWw2fwLhXsjkOEIKqqd7vA=; b=H2Qju053V7bPhBEI74MV1iAcU8xd+jYdcejmcOLEPvRYLB5SGKfeXgt87FwZv2cPLr sXCY+fJniO+TIqWIaGZQAFxVdRvVPoCQQWk+PoK2sG2oYSRQSOMWnbp8XdIpyHEwTIcH u4z4KU0rfhZcX9aP9fhpQ73KVd9dWnXRH8JbQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wdrP3EBOw/3H7ln1gECvcaWw2fwLhXsjkOEIKqqd7vA=; b=4IujgYBbQxx59X6q+0G54F+Xl5wfgaGNrOGeamXWN1I9bNFX4b3Ba01b1y3SuK3McU 2lCkuq/9mMpGpgDfBLeYrhHOWU205AVK4SwUHrN08CxsjScurcBdni5YHfZCdB0oL7/r G0zGKp82ua46tjbYvDSapEiX0Et/Ga6e8ZlR7U7fYI03U0Up2fy0Xtux4wPTLCEGmCKB W7/BwEcYHP01RsKssi55tkct4ogWrbFCOCSq3kuxCjanj/oJLGAIq+2ireGG8Q5qtB3y KcqgH9WBy33ZZ/UFWMCPcd+oLkvN3hEtSmPqV1qVfH93AOHF8dNRzXhhYXqsSlHweEfe 5L9g== X-Gm-Message-State: AOAM532HRwJWNHJ6kmXg3xmy3O/nXke8fEooJa5+pROd4DzvG8cLiqe4 jW6dPiVWsogsJKVIPq8yyKB/+w== X-Google-Smtp-Source: ABdhPJzh82j7cmz9xQXQF/zM4pykVwDNEl6kgZ8n5IPkubpcKiFz1N8CMcdqK1ZC/seMcCiL15nLpw== X-Received: by 2002:a05:620a:22f9:b0:67d:1561:f4f4 with SMTP id p25-20020a05620a22f900b0067d1561f4f4mr3385963qki.217.1648733941348; Thu, 31 Mar 2022 06:39:01 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id y12-20020a05622a164c00b002e1e277885esm19039025qtj.8.2022.03.31.06.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 06:39:00 -0700 (PDT) Date: Thu, 31 Mar 2022 09:38:58 -0400 From: Tom Rini To: Andy Shevchenko Cc: Simon Glass , Heinrich Schuchardt , u-boot@lists.denx.de, Bin Meng , u-boot-custodians@lists.denx.de, u-boot-board-maintainers@lists.denx.de, Ferry Toth Subject: Re: [PATCH v1 1/1] Revert "x86: Move FACP table into separate functions" Message-ID: <20220331133858.GA14476@bill-the-cat> References: <20220330154918.21107-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IgDDV5QArAYIxtdK" Content-Disposition: inline In-Reply-To: <20220330154918.21107-1-andriy.shevchenko@linux.intel.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --IgDDV5QArAYIxtdK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 30, 2022 at 06:49:18PM +0300, Andy Shevchenko wrote: > Before the culprit patch (see BugLink for the details): >=20 > =3D> acpi list > Name Base Size Detail > ---- -------- ----- ------ > RSDP 000e4500 24 v02 U-BOOT > RSDT 000e4530 38 v01 U-BOOT U-BOOTBL 20220401 INTL 0 > XSDT 000e45e0 4c v01 U-BOOT U-BOOTBL 20220401 INTL 0 > CSRT 000e5490 58 v00 U-BOOT U-BOOTBL 20220401 INTL 0 > FACP 000e54f0 114 v06 U-BOOT U-BOOTBL 20220401 INTL 0 > DSDT 000e4780 c06 v02 U-BOOT U-BOOTBL 10000 INTL 20200925 > FACS 000e4740 40 > MCFG 000e5610 3c v01 U-BOOT U-BOOTBL 20220401 INTL 0 > SPCR 000e5650 50 v02 U-BOOT U-BOOTBL 20220401 INTL 0 > APIC 000e56a0 48 v02 U-BOOT U-BOOTBL 20220401 INTL 0 >=20 > After the culprit patch: >=20 > =3D> acpi list > Name Base Size Detail > ---- -------- ----- ------ > RSDP 000e4500 24 v02 U-BOOT > RSDT 000e4530 34 v01 U-BOOT U-BOOTBL 20220401 INTL 0 > XSDT 000e45e0 44 v01 U-BOOT U-BOOTBL 20220401 INTL 0 > CSRT 000e53a0 58 v00 U-BOOT U-BOOTBL 20220401 INTL 0 > MCFG 000e5520 3c v01 U-BOOT U-BOOTBL 20220401 INTL 0 > SPCR 000e5560 50 v02 U-BOOT U-BOOTBL 20220401 INTL 0 > APIC 000e55b0 48 v02 U-BOOT U-BOOTBL 20220401 INTL 0 >=20 > As a result Linux kernel can't find mandatory tables and fails > to boot. >=20 > Hence, revert it for good. >=20 > This reverts commit 379d3c1fd6aa490b1ad5697525cfc89b615cf25a. >=20 > BugLink: https://lore.kernel.org/all/20220131225930.GJ7515@bill-the-cat/ > Signed-off-by: Andy Shevchenko Applied to u-boot/master, thanks! --=20 Tom --IgDDV5QArAYIxtdK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJFrvIACgkQFHw5/5Y0 tywt0wv+JrHn/sZX6YRxx5B3TogRsBjzU3m9ZT+uAb6BwQWKSF2gNHL9YgnzwI3o rzEyzE9dkyuMAX1evYJlvyYivc4EXfDisKUY5IJkPYAX4oETG0NSdhIbWko8OQ0r BekDxCTwceewKcs+B2qlxtjwO8sA6Mh0klQNYYfvzmadvADL80BQn2wu3fDbi/Ub 2sJefhyucHDH6Ln3y7zumi2gkLufEgCzp/lzyBcRJmRUrVFiZCx6JOyLt7nFdbk2 hxPmN/EpzBFIMWIRi+UCzW8yRp2Hj7nhddXQEAtnNhM2Ts/iI6yP/kv63efQgU4g hYn/LsjWZwkculAVF+pHGyJjqAME36TVBr3cSdMvz87Fq6IZR0A9DFtcOOwSabrI rzmQhBA8VQERbC3ZDOYl//vx95RghTpi4C+/N5oiIFWeoL8gP39JflxRP61Nq65B sxP8XTc0lPPj+Q7XZMdTHPviFjjUpwfZMAiQKV+0Auc9BGfgZA9QrnjDU0+/y6Jb JqNBPbg+ =S0Lp -----END PGP SIGNATURE----- --IgDDV5QArAYIxtdK--