Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E15CC433EF for ; Mon, 4 Apr 2022 13:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1/nTvB1odicofFAzGC045ky3taeagi0XYqDlB5wnwqU=; b=lnQkKTjhur6RwP 6vJCFRSyEH5xDgUIGIDjJiFWk4TICf+9GEbDSHvocJ8/cjF4sThVTDU2NUCJFLCu7Tw+66KDVts8N Ixrh3gzEbSuq30+aBoUj0SSC1nYxSiWIdz0uqmEVazLTt8b12BaG1I4W+1DUVdo72sQhQZz4aglSY VD8EGLs63HxDIMwygQd/mt51SnwHt6W6rmUfuKQO0oF9DgArvJuOEfKIAH49IGTuQGLbluKyBjoq3 UNsE2KW2set630d8wo0oNpvavl+0Ici5Gdkwrg1cg8Mw2E61oLzwKM+Je/abnwGvmkzzY68eQGw9M JwxTeQmcF4pCWnq6CQpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbN5S-00FBXw-7F; Mon, 04 Apr 2022 13:49:42 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbN5O-00FBWf-9H for linux-arm-kernel@lists.infradead.org; Mon, 04 Apr 2022 13:49:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B74661341; Mon, 4 Apr 2022 13:49:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6810BC2BBE4; Mon, 4 Apr 2022 13:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649080173; bh=o8EusyFNITqQirjoSgFG0TvXuu6TeCDoM+CoPgklalE=; h=From:To:Cc:Subject:Date:From; b=O7A/pLmIMF58kWEbLFcq+LZdEOd/UX0Jn5Lv0KgCyPBTXBHJho/aKoDug5Hv5NCpd lCjxVKCdHBaspbTGb0FiJHtvN0GOVh1x/rac0pqv6pZzaaVIJZqYGpM7eRh8b2bFA8 /TJPF0DQwMFVg9GRCrmXfPMrGHvnnNQ4QlladtXKhAJ41tR3JR1F+hMwOgtbys62G9 rGzlAJQrmmkezn/r4e5Awk6nctnES2tm2HmURla7wSAFdQrmKWXNXaLIlewPlg+08+ tRc2cowQWLYNNiuSZ1uznT18uoJ/QO/GoG5LruvRJEFt3USTH1TpkVoKUs1wEVlNKq 20/wc1XpO5C1A== From: Mark Brown To: Catalin Marinas , Will Deacon Cc: Mark Rutland , Marc Zyngier , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, Mark Brown Subject: [PATCH v3 0/8] arm64: Automatic system register definition generation Date: Mon, 4 Apr 2022 14:46:37 +0100 Message-Id: <20220404134645.1675346-1-broonie@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5602; h=from:subject; bh=o8EusyFNITqQirjoSgFG0TvXuu6TeCDoM+CoPgklalE=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBiSva9r9nBDsmVN/KNx4CupPx+kV9cx70gH3zGwyW9 aTY1MMyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCYkr2vQAKCRAk1otyXVSH0Fm2CA CBkWpB7grhjLJLjJFRHT7it/54MdZ8YLxuMA7UC+X6Kc2PWhmhH3ptlOLCQ+c4JjmEmSKa2uRpS3X9 p7j18G8ES9rBwK9/oh+1UxQOczbn1k0vfc3fuR7A2/JjfAyk+xzj7j6T+gESjagONhYfPI5G6GG0Lb g8fMGa4QrN9VRWl08luQZLGGflznkdwqJ0IQqRR34KHOdhdCyCuVQPBwbZRxAGO/ofAaVntLOi3pdm op3NXS1TUAE5IiB159gPnr5LqYaRE+L+BUxjkqbpK96YbovCUkuxxTpQtDpYirB6OMyEjjw85w3OHy 1g2QYBv3H03H37K1O1jQWpfpRIVo7b X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_064938_445832_E10A9764 X-CRM114-Status: GOOD ( 24.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The arm64 kernel requires some metadata for each system register it may need to access. Currently we have: * A SYS_ definition which sorresponds to a sys_reg() macro. This is used both to look up a sysreg by encoding (e.g. in KVM), and also to generate code to access a sysreg where the assembler is unaware of the specific sysreg encoding. Where assemblers support the S3__C_C_ syntax for system registers, we could use this rather than manually assembling the instructions. However, we don't have consistent definitions for these and we currently still need to handle toolchains that lack this feature. * A set of __SHIFT and __MASK definitions, which can be used to extract fields from the register, or to construct a register from a set of fields. These do not follow the convention used by , and the masks are not shifted into place, preventing their use in FIELD_PREP() and FIELD_GET(). We require the SHIFT definitions for inline assembly (and WIDTH definitions would be helpful for UBFX/SBFX), so we cannot only define a shifted MASK. Defining a SHIFT, WIDTH, shifted MASK and unshifted MASK is tedious and error-prone and life is much easier when they can be relied up to exist when writing code. * A set of __ definitions for each enumerated value a field may hold. These are used when identifying the presence of features. Atop of this, other code has to build up metadata at runtime (e.g. the sets of RES0/RES1 bits in a register). This patch series introduces a script which describes registers and the fields within them in a format that is easy to cross reference with the architecture reference manual and uses them to generate the constants we use in a standard format: | #define REG_ID_AA64ISAR0_EL1 S3_0_C0_C6_0 | #define SYS_ID_AA64ISAR0_EL1 sys_reg(3, 0, 0, 6, 0) | #define SYS_ID_AA64ISAR0_EL1_Op0 3 | #define SYS_ID_AA64ISAR0_EL1_Op1 0 | #define SYS_ID_AA64ISAR0_EL1_CRn 0 | #define SYS_ID_AA64ISAR0_EL1_CRm 6 | #define SYS_ID_AA64ISAR0_EL1_Op2 0 | #define ID_AA64ISAR0_EL1_RNDR ARM64_SYSREG_BITMASK(63, 60) | #define ID_AA64ISAR0_EL1_RNDR_MASK ARM64_SYSREG_BITMASK(63, 60) | #define ID_AA64ISAR0_EL1_RNDR_SHIFT 60 | #define ID_AA64ISAR0_EL1_RNDR_WIDTH 4 | #define ID_AA64ISAR0_EL1_RNDR_NI ULL(0b0000) | #define ID_AA64ISAR0_EL1_RNDR_IMP ULL(0b0001) This should be particularly useful for the ID registers where we will be able to specify just the register and field for more of the bitfield information, simplifying ARM64_FTR_BITS() and providing helpers for use in struct arm64_cpu_capabilities or for hwcaps. At the moment this is only intended to express metadata from the architecture, and does not handle policy imposed by the kernel, such as values exposed to userspace or VMs. In future this could be extended to express such information. This could also be extended to cover more information such as the FTR_SIGNED/FTR_UNSIGNED distinction. There is also currently no support for registers which change layout at runtime, for example based on virtualisation settings - these could be manually handled for the time being, or the script extended. At the present time (especially given how near we are to the merge window) this is as much about getting feedback on the general approach and how to move forward if we want to move forward. Rather than attempting to convert every register at once the current series converts a few sample registers to provide some concrete examples but allow for easier updating during review of the file format and the script. Handling a register at a time should also make review less taxing so it seems like a sensible approach in general. The generation script was originally written by Mark Rutland and subsequently improved and integrated into the kernel build by me. v3: - Rebase onto v5.18-rc1. v2: - Fix issue with building bounds.s in an O= build by renaming the generated header. Mark Brown (7): arm64/mte: Move shift from definition of TCF0 enumeration values arm64/sysreg: Standardise ID_AA64ISAR0_EL1 macro names arm64/sysreg: Rename SCTLR_EL1_NTWE/TWI to SCTLR_EL1_nTWE/TWI arm64/sysreg: Enable automatic generation of system register definitions arm64/sysreg: Generate definitions for ID_AA64ISAR0_EL1 arm64/sysreg: Generate definitions for TTBRn_EL1 arm64/sysreg: Generate definitions for SCTLR_EL1 Mark Rutland (1): arm64: Add sysreg header generation scripting arch/arm64/include/asm/Kbuild | 1 + arch/arm64/include/asm/archrandom.h | 2 +- arch/arm64/include/asm/sysreg.h | 61 +---- arch/arm64/kernel/cpufeature.c | 70 +++--- arch/arm64/kernel/mte.c | 6 +- .../arm64/kvm/hyp/include/nvhe/fixed_config.h | 28 +-- arch/arm64/tools/Makefile | 8 +- arch/arm64/tools/gen-sysreg.awk | 213 ++++++++++++++++++ arch/arm64/tools/sysreg | 183 +++++++++++++++ 9 files changed, 466 insertions(+), 106 deletions(-) create mode 100755 arch/arm64/tools/gen-sysreg.awk create mode 100644 arch/arm64/tools/sysreg base-commit: 3123109284176b1532874591f7c81f3837bbdc17 -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel