Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C218C433F5 for ; Wed, 6 Apr 2022 13:09:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 29FF183D2A; Wed, 6 Apr 2022 15:09:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="gQBk0WSY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B14383D2A; Wed, 6 Apr 2022 15:09:44 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 22EFC83C11 for ; Wed, 6 Apr 2022 15:09:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id v2so4133782qtc.5 for ; Wed, 06 Apr 2022 06:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WzsIBWSPW2yIgYvR3VcQyjhOBjS+EQqUiJ9B5wGfHOU=; b=gQBk0WSYACzdg7gShLnC1q1qsXGG/kpVHIsvzhrm3EhgSmO/8PtQYGershzH0aUvRK TtnQyqZlfo7aSJZbIS+UGZLNVe92z9Y+K6rvOWSFPIhKSaTw6Re2hRirA/L96tvT0vc+ gQYWwXS2A2So5qzseUGAaDQJestE3fWTKIheU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WzsIBWSPW2yIgYvR3VcQyjhOBjS+EQqUiJ9B5wGfHOU=; b=CoMeolzDmSwjirfocqPVe7AnoweaqQeH6JXBVwByRv4a5ueAjqBhNDTuH+oirD3m/b eSxsJwdpWeFMZk39DMlgmdkqNgLaTy4nk72juoVrOTRG2jKoV5zyJmsUM3HAjZ//biMm nCxH5NWNnCdEHArVf2bb8bY/Si4lDk2B0I+l+9et6FTfYt1RzgyvrXGMwY7k/xQXvS8w ebXQ6l6S/FiHRCASHBH6Uv/eSdS+vRO4zH03hBcr0Y1HnSiot6T1BLu3SchhHXQvjcwI RahNFCmmkaO7LM0C2eigSoZITCeB2uNiI2IkCmG/ACjlY9EzxVhMBWxuZc15U9a2Sfq5 BQ6Q== X-Gm-Message-State: AOAM533n2+p8Lwp0x3uHiUw03LPt78GEXbEAE5t/VHU77FlS3DGmJpAb KWB1sGdh/SPIomHxxQYGenz0UW1XuHcjYA== X-Google-Smtp-Source: ABdhPJzwV1iZWZkp2kaCzyKIQ5Q3SKhDb8Px9ek9NrVWX5T724gOSWebDSmcxTFFGJ4VUwDRcm8nxQ== X-Received: by 2002:ae9:f501:0:b0:67b:2d97:93c5 with SMTP id o1-20020ae9f501000000b0067b2d9793c5mr5537208qkg.380.1649250576718; Wed, 06 Apr 2022 06:09:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id x4-20020a05620a258400b0067d47fb5aa4sm10088019qko.63.2022.04.06.06.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:09:35 -0700 (PDT) Date: Wed, 6 Apr 2022 09:09:34 -0400 From: Tom Rini To: Michael Walle Cc: u-boot@lists.denx.de Subject: Re: [PATCH] armv8: sec_firmware: drop unneeded ARMV8_SEC_FIRMWARE_SUPPORT check Message-ID: <20220406130934.GZ9042@bill-the-cat> References: <20211126161136.66006-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f8lmXUvqnCdFQPaI" Content-Disposition: inline In-Reply-To: <20211126161136.66006-1-michael@walle.cc> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --f8lmXUvqnCdFQPaI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 26, 2021 at 05:11:36PM +0100, Michael Walle wrote: > This module will only be compiled if this symbol is set. Remove the > useless check. While at it, invert the return code, to return 0 if the > function succeeds. The only user of this function in > arch/arm/cpu/armv8/fsl-layerscape/fdt.c doesn't check the return code > anyway, so its safe change it. >=20 > Signed-off-by: Michael Walle > --- > arch/arm/cpu/armv8/sec_firmware.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) Currently this causes a large number of platforms to fail to build such as ls1012aqds_tfa_SECURE_BOOT, please fix and resubmit, thanks. --=20 Tom --f8lmXUvqnCdFQPaI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJNkQcACgkQFHw5/5Y0 tywdDgv/SQCpQR6MennN0vvdRAf7aw0lGegmPAZqVGFDcczxFHz4P3OqXT7vw6Xa abeUzZoTwI9qM0mf9cfvhRtXf/sldwDeqSNX0qkPxhcdGG4gXlqTFdoFjnFqyQW3 FjP1APnxDsZk0/SLtSIgSQLHffx59kIASEUr3nJ2O2aC4532cfAqBh49+ZveOTsp JuGMUswZM9So/Zx+WFjJ9lJgobQIYKXj/5+693Gb6jcrSsT2MSOORhZPHsNlJnt7 +jMimkRdjiWUT6M0PfFkr0aDA0hhvGHyfFMdT9Mnc92c360IoW25Dl0cFer2OWPX KnTWOoAk8c+pVq68blyI5U2LPY9BaW6WDSs9aq/JD9BM3fzNaHcBu+GjdLnPKfDO dUGQyMnRrTYJmtJ0vvxMJD9beJG5JurIckV03C6fG9vUWknlbOA8fVyxvGUU1Ri+ ZM19txUobCZ8PADj8IeeGbJPi6PMDoU8bZP+sq2eTlK/thCdCmu14LVahj9d+iII bHVLYIk0 =6xqv -----END PGP SIGNATURE----- --f8lmXUvqnCdFQPaI--