Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C952C433EF for ; Wed, 6 Apr 2022 23:33:25 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.300194.511861 (Exim 4.92) (envelope-from ) id 1ncF8x-00017i-HP; Wed, 06 Apr 2022 23:32:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 300194.511861; Wed, 06 Apr 2022 23:32:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ncF8x-00017b-EF; Wed, 06 Apr 2022 23:32:55 +0000 Received: by outflank-mailman (input) for mailman id 300194; Wed, 06 Apr 2022 23:32:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ncF8v-00017V-KE for xen-devel@lists.xenproject.org; Wed, 06 Apr 2022 23:32:54 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd3b35af-b601-11ec-8fbc-03012f2f19d4; Thu, 07 Apr 2022 01:32:49 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 16:32:45 -0700 Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2022 16:32:42 -0700 Received: from kbuild by a44fdfb70b94 with local (Exim 4.95) (envelope-from ) id 1ncF8j-0004r5-Sb; Wed, 06 Apr 2022 23:32:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd3b35af-b601-11ec-8fbc-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649287969; x=1680823969; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pRwkOMm0qHu0lOS5zpitn48/SuLkUxM71YjsDbeCfgU=; b=k8sJAnIRTABGPo9r6P9fFHuX2ub2BVcKh6ldIHdGtPrlVYsVJB8RGbhx 5spofdTCJv22IRr4RPRY9odflKFvmO5cuwbQIVIwq+KogproTNYWebsG8 A/+zxKw4pfYLu7aoLeQz3DefJNGAFDERSHa2uSnMbYmZuz5mthkYmMGDI b3VBclifxD33arxzglIfzn9QendKXzMFgo2N4XFrlZNKn3n1TQ4VUBnZv OdG/HnUdn/WHoDr+svxnN7RD0oyVkuT0ccPhDc61qgh1MZhPjDV1faTLJ E1mlvGqX9zqFKymFcUfO+im+QAxptDAF/9UxszDLK4uRyqiYzTfAiJ0Dd w==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="258775586" X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; d="scan'208";a="258775586" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; d="scan'208";a="722721744" Date: Thu, 7 Apr 2022 07:31:44 +0800 From: kernel test robot To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Juergen Gross , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= Subject: Re: [PATCH] xen/balloon: fix page onlining when populating new zone Message-ID: <202204070706.PKz2Th7L-lkp@intel.com> References: <20220406133229.15979-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406133229.15979-1-jgross@suse.com> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Juergen, I love your patch! Perhaps something to improve: [auto build test WARNING on xen-tip/linux-next] [also build test WARNING on linus/master linux/master v5.18-rc1 next-20220406] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935 base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next config: arm64-randconfig-r011-20220406 (https://download.01.org/0day-ci/archive/20220407/202204070706.PKz2Th7L-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/b3deb59d5386ade4fb227038f202a9bdb8ade4ab git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Juergen-Gross/xen-balloon-fix-page-onlining-when-populating-new-zone/20220407-000935 git checkout b3deb59d5386ade4fb227038f202a9bdb8ade4ab # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/xen/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/xen/balloon.c: In function 'decrease_reservation': drivers/xen/balloon.c:518:24: error: implicit declaration of function 'alloc_page_for_balloon' [-Werror=implicit-function-declaration] 518 | page = alloc_page_for_balloon(gfp); | ^~~~~~~~~~~~~~~~~~~~~~ >> drivers/xen/balloon.c:518:22: warning: assignment to 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 518 | page = alloc_page_for_balloon(gfp); | ^ drivers/xen/balloon.c:545:17: error: implicit declaration of function 'add_page_to_balloon' [-Werror=implicit-function-declaration] 545 | add_page_to_balloon(page); | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +518 drivers/xen/balloon.c 505 506 static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp) 507 { 508 enum bp_state state = BP_DONE; 509 unsigned long i; 510 struct page *page, *tmp; 511 int ret; 512 LIST_HEAD(pages); 513 514 if (nr_pages > ARRAY_SIZE(frame_list)) 515 nr_pages = ARRAY_SIZE(frame_list); 516 517 for (i = 0; i < nr_pages; i++) { > 518 page = alloc_page_for_balloon(gfp); 519 if (page == NULL) { 520 nr_pages = i; 521 state = BP_EAGAIN; 522 break; 523 } 524 list_add(&page->lru, &pages); 525 } 526 527 /* 528 * Ensure that ballooned highmem pages don't have kmaps. 529 * 530 * Do this before changing the p2m as kmap_flush_unused() 531 * reads PTEs to obtain pages (and hence needs the original 532 * p2m entry). 533 */ 534 kmap_flush_unused(); 535 536 /* 537 * Setup the frame, update direct mapping, invalidate P2M, 538 * and add to balloon. 539 */ 540 i = 0; 541 list_for_each_entry_safe(page, tmp, &pages, lru) { 542 frame_list[i++] = xen_page_to_gfn(page); 543 544 list_del(&page->lru); 545 add_page_to_balloon(page); 546 } 547 548 flush_tlb_all(); 549 550 ret = xenmem_reservation_decrease(nr_pages, frame_list); 551 BUG_ON(ret != nr_pages); 552 553 balloon_stats.current_pages -= nr_pages; 554 555 return state; 556 } 557 -- 0-DAY CI Kernel Test Service https://01.org/lkp