Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3753C433F5 for ; Fri, 8 Apr 2022 12:31:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0074283DCC; Fri, 8 Apr 2022 14:30:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TiLofK2m"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D0C4583DA3; Fri, 8 Apr 2022 14:30:48 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 27D9B83D9B for ; Fri, 8 Apr 2022 14:30:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id 75so1791181qkk.8 for ; Fri, 08 Apr 2022 05:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TdODppgvyWLWO2789lxgYzs97yePNnVSlmoPm7hbnxU=; b=TiLofK2mafJmcJhEOS+VAzXzlz8KVKx6htvepxemlFNbTclmBASizXE0R05CvOZ05/ 843pvSQMTD39M+fTaEywRkb4mWwrR44TLb1M1D1DWO7eOBXu2Xrxo0QxpGwd3ZfAd9a6 H53TkRM5Rak1JOvPhQJyED2PaxKaIh3LLZrQc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TdODppgvyWLWO2789lxgYzs97yePNnVSlmoPm7hbnxU=; b=cmldXglnV62Uun4IAFzbVEk+zRnHjrT7Kco/pP+uO4Qaamow3EFY6SFke2sHDh5n8o A1jkL7g0W+24yzyq4TMw2axByQ6U29OUXPC9t2cJjBBb9a3Xp6qhFG5Zh7ayjk1XBH9m 0SB96ojWQC5Vq+l05XLRHu6OwYQbh3EmQXN4pOSNVQ07bV9y82X5rtZUy6z4ZMlBxYLr a4TzXB6fnHapvpHuOUdNni2aSmqoBXtnEc3GprRggqWRS16WAgtx7bYxF3PW/OAd7prc yVb25oBAyJJzD7oCqtlw5z69srtlspOFetJBSXoQkAzOQn1Zlz3qeXpjJjCtcTag6ada wQaQ== X-Gm-Message-State: AOAM533QQ89GO5yphgLwRKZ4FNmizBgxt1dx4IxEHN/JblytjGOftH4r bqWzNwpBvuLqYpCAagM4vF1wPQ== X-Google-Smtp-Source: ABdhPJzF4OiVnpv+gfPiQ1iZd+91+6RY8lCNd6uivYN3R+vFGAWStNI6QZQPMzCAZfCOGKiX/j1COQ== X-Received: by 2002:a05:620a:74b:b0:69b:db1d:f91e with SMTP id i11-20020a05620a074b00b0069bdb1df91emr1607238qki.286.1649421040749; Fri, 08 Apr 2022 05:30:40 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id o14-20020a05622a138e00b002e1e78c899fsm17553079qtk.53.2022.04.08.05.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 05:30:40 -0700 (PDT) Date: Fri, 8 Apr 2022 08:30:38 -0400 From: Tom Rini To: Christoph Niedermaier Cc: u-boot@lists.denx.de, Stefano Babic , Simon Glass , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH V3] Makefile: Sort u-boot-initial-env output Message-ID: <20220408123038.GW14282@bill-the-cat> References: <20220301083851.2677-1-cniedermaier@dh-electronics.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p609JBPwWeYlfsbE" Content-Disposition: inline In-Reply-To: <20220301083851.2677-1-cniedermaier@dh-electronics.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --p609JBPwWeYlfsbE Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 01, 2022 at 09:38:51AM +0100, Christoph Niedermaier wrote: > This will sort the default environment file generated by > "make u-boot-initial-env", but won't sort the default > environment in the compiled u-boot binary. The file > u-boot-initial-env is considered to use for the userpace > environment access tools [1] in case of that the > environments is written the first time into its location. > This is done on the one hand for a better overview and > comparison of the generated environment file. On the other > hand it is to synchronize the output with the script > get_default_env.sh, which generated a sorted default > environment file. The sorting preserves the order of equal > variable names by sorting only the variable name, and > disable the last-resort comparison. After sorting, > unnoticed blank lines at the end move to the top. Avoid > that by removing it before sorting. >=20 > [1] https://github.com/sbabic/libubootenv >=20 > Signed-off-by: Christoph Niedermaier > Reviewed-by: Stefano Babic > Tested-by: Stefano Babic > Cc: Stefano Babic > Cc: Simon Glass > Cc: Marek Beh=FAn > To: u-boot@lists.denx.de > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --p609JBPwWeYlfsbE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJQKu4ACgkQFHw5/5Y0 tyzzjgv+P23yBNSjbAcTYzCdHGaEed5XCPOH6kLTGM47L8WGWA/6esa1tHbzPTZm 3dStVIJBFsoJLjvW1smO8y3SDUul7HfVMslUvaS1KJLmifUbgi6J3htW6XxuAnru cX2YS/GMqsr+lOiJxrv2IM91mnEp93ySTiQn1HlzvNqgYqA60DR1I9PTduhKs8V4 N+jxEjaP4yzE9cnkb8pG5FQuN6sTosJx+L6GYbsoICrUBurNxzMm7ohEUz9LNvzC XLQJlLqFtiTS2as1n4LUN3fiVj5wKCSeHXBGrYXJQRjR7Sbf8kL1RTrblXRcwmF4 3GewIbS9ncmmXHgxvWyuLAcljzWtrF1MHHI9xbxdkvNGm72137/ULtU6UGO6Znck 6THhQwobefeFX5rxRLmA2Ne2QtFn22XZoPy13jNQ+FG0H3mXmonSv1nivs3ICGO0 KCM2l74VPNbPkQWGwmdpZK+nd0Pm1IWfX7lrlBXQGtqM/Yt3KLjoqxApu0YkPn2q RML+p1Mr =v1Ta -----END PGP SIGNATURE----- --p609JBPwWeYlfsbE--