Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2955C433EF for ; Tue, 12 Apr 2022 15:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350245AbiDLPun (ORCPT ); Tue, 12 Apr 2022 11:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230352AbiDLPul (ORCPT ); Tue, 12 Apr 2022 11:50:41 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 049EA5FF29 for ; Tue, 12 Apr 2022 08:48:23 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id x10-20020a5b028a000000b0063f0cc26f1bso10304901ybl.16 for ; Tue, 12 Apr 2022 08:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=8IZz/gMylCpP1gVOy3Mzg8c3y39Rz/6oTdnON/BPbbo=; b=nozrEXfagyw88Rss5WjQoaW+QrAP05xY/u0NdTER42+HrNPzXBnVSeJMVV1t4f1tuk blSVnwX63Ntsee0BrggFx1BX7hqrWUE+/lheMmBq4lLmaGVbOnNzrH3RMNh/aYIYEC7m gkyaLUH7heh/Bagv6Tc7TIuyIYrzP9V8RZn/U4DS5KheteWxYjSJ7u/6J0we0EIJ0NC9 AsCP7aaf3Kb42hs6Lw2WxNxA8rsk6dSAiF1hRAoqmSeTeb13PJFeWlHtOGKWUJ5C2+Ue xLJls2OFlXo9elbttQXMs1LNWl87IVZaVxDY+tNaz/W/C6bgwKop6uSP1HPb7zpVPwZ0 gtWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=8IZz/gMylCpP1gVOy3Mzg8c3y39Rz/6oTdnON/BPbbo=; b=489Qa22k3lVMqipBY7NC3s8WRjxImxWWR77kRVURO1J9bFQpN4fhKWPs7EXnM5YoW4 PTIlzMgGwSn7Krh7+jA2LRz8wKy1nig3Yf3LryPO0Q3QOgjfXwUt47dtv+fDEOfuXNfg XvV0jZunHWQbGbriJiMhvRtbZvUAwl6REkejYkdimt1TrlzVsWr/F7TKZ92LFxuFSOWx iOau3jpLvPsRwfoZGKWpwTqIb3CuRxy1D4ooi2k2ovn1d3v577IySQglyl2VrQ43hP1I oQc6JTxCq18RWTu6HxN9F8hebxdGZkDBkVJ2NXdHwZRMd7k+Pb3dNO42vJFTwD1n81mu eJWg== X-Gm-Message-State: AOAM531C0s25kxi4Cmrza4redYlga2vkIMjcCdYtYKH36EvPrMBJPVMV 5BRg/9sl6XKXndhjD6cQVWl4mnz7vU6a X-Google-Smtp-Source: ABdhPJy450ML0VeLyDFpbPqaekYj5Wh+ytMVAvRr1v5nwfqBAHYtbYtXW7oIiYzIflTqKubXTCVh9Baufz9i X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:5f6f:a698:92a:5d45]) (user=irogers job=sendgmr) by 2002:a5b:cc:0:b0:63d:897a:ddab with SMTP id d12-20020a5b00cc000000b0063d897addabmr25252581ybp.110.1649778502201; Tue, 12 Apr 2022 08:48:22 -0700 (PDT) Date: Tue, 12 Apr 2022 08:48:13 -0700 Message-Id: <20220412154817.2728324-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.1.1178.g4f1659d476-goog Subject: [PATCH v2 0/4] Tidy up symbol end fixup From: Ian Rogers To: John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Clark , Alexandre Truong , German Gomez , Ian Rogers , Dave Marchevsky , Song Liu , Ravi Bangoria , Li Huafei , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , William Cohen , Riccardo Mancini , Masami Hiramatsu , Thomas Richter , Lexi Shao , Remi Bernon , Michael Petlan , Denis Nikitin , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Fixing up more symbol ends as introduced in: https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/ caused perf annotate to run into memory limits - every symbol holds all the disassembled code in the annotation, and so making symbols ends further away dramatically increased memory usage (40MB to >1GB). Modify the symbol end logic so that special kernel cases aren't applied in the common case. v2. Drops a merged patch. Fixes a build issue with libbfd enabled. Ian Rogers (4): perf symbols: Always do architecture specific fixups perf symbols: Add is_kernel argument to fixup end perf symbol: By default only fix zero length symbols perf symbols: More specific architecture end fixing tools/perf/arch/arm64/util/machine.c | 14 +++++++++----- tools/perf/arch/powerpc/util/machine.c | 10 +++++++--- tools/perf/arch/s390/util/machine.c | 12 ++++++++---- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 16 +++++++++------- tools/perf/util/symbol.h | 4 ++-- 6 files changed, 36 insertions(+), 22 deletions(-) -- 2.35.1.1178.g4f1659d476-goog