Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBB35C433EF for ; Tue, 12 Apr 2022 16:42:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 22A7B838AB; Tue, 12 Apr 2022 18:42:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DYNFvXck"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 35AEC838C7; Tue, 12 Apr 2022 18:42:43 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 59CEF831E0 for ; Tue, 12 Apr 2022 18:42:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id o18so12355559qtk.7 for ; Tue, 12 Apr 2022 09:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WrOTE+Dp9WY2WifmqbqjTsGYll96FlMFo6KsnS7fQrU=; b=DYNFvXckegGT2ydwQnDewu8y89BY0y51rDYV0KYZ7CgWvaxcEQNFn39Z1otgZcbw7T xBEdvYLwboUXmMvh37+1dxHelABGglA4C3zvh8mkBcR/1xuOWnyr1bgyzByaNY9N7GQW kDdT9nf/9L+N5Uvqge6jKrVCnbz7Y3V4H5lIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WrOTE+Dp9WY2WifmqbqjTsGYll96FlMFo6KsnS7fQrU=; b=OvcICTJ8p0t3i5SkTg+l3M8dq1l4DxPb9jndktYCLEyDRTTQJbgpeetmKm20sAkaK+ WnQJIyBjMkFkzQLcUbPKmbE/xZxXrDgqJfYmD3Y/30k06zTvg7Pm1E9FZQMC8O6zPbrd 8WMGAfmekWxhLSpKZ6MM/JjbSZ6tNxOrG0hfrY2d4sbFJbck3D7nwy9XUWxAX0KJ2Jeq cGIabmThaGYRiKwwtQpp8/q1ZkT3yQJ658ufvn+jrXebKQbmO6v30Q6+1w/OHsdJnDfE bX5F6TmVDxPgdHAliJ+slPq0M9k/NWvyTjgFJKNbU7T4EEN0+fa3yeMv8TeQlIrgs/Qt RSBQ== X-Gm-Message-State: AOAM532dDPQNkkbGZ4r5mrcx1bl7MQB549cuCGYsRlDZbLSga7HBhPjf btGhh0IpPAyn29y3bst3AXD5rQ== X-Google-Smtp-Source: ABdhPJznBFscAreYipLfegM8f4JQpxQCA8R2PPUmDt41dyaTvYumtGD6t6Ruxk+son31IlAVzBdcNQ== X-Received: by 2002:ac8:4e8a:0:b0:2e1:e828:cac3 with SMTP id 10-20020ac84e8a000000b002e1e828cac3mr4000321qtp.616.1649781759101; Tue, 12 Apr 2022 09:42:39 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id t3-20020a05622a148300b002ef8ff7afa1sm3100187qtx.21.2022.04.12.09.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 09:42:38 -0700 (PDT) Date: Tue, 12 Apr 2022 12:42:36 -0400 From: Tom Rini To: Andrew Scull Cc: u-boot@lists.denx.de, sjg@chromium.org, bmeng.cn@gmail.com, adelva@google.com, keirf@google.com, ptosi@google.com Subject: Re: [PATCH v2 13/18] pci: Map bars with offset and length Message-ID: <20220412164236.GA370634@bill-the-cat> References: <20220329165900.1139885-1-ascull@google.com> <20220329165900.1139885-14-ascull@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk" Content-Disposition: inline In-Reply-To: <20220329165900.1139885-14-ascull@google.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 29, 2022 at 04:58:55PM +0000, Andrew Scull wrote: > Evolve dm_pci_map_bar() to include an offset and length parameter. These > allow a portion of the memory to be mapped and range checks to be > applied. >=20 > Passing both the offset and length as zero results in the previous > behaviour and this is used to migtate the previous callers. >=20 > Signed-off-by: Andrew Scull This breaks rpi_arm64 building, and possibly others. It may be helpful to read https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html and get a CI run completed for the whole series to shake out any other failures. Thanks! --=20 Tom --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJVq/QACgkQFHw5/5Y0 tyy5MgwAi8nbVqnAiZNy1MK24Oi2BF8U2iVQxlSbmkg/LSnsViPevPz2ta4Wt44t znyVc+ORPxD7uscr/O+aXRhbGJNLAm+9AN60zWgQqeNHR5Ea1Iv/kIiXpmlsCTp9 IERlUzvcvre6Js2fAwrrbCT+WCDkV0iyvMwuwQyN+vW3HEIf/+tycEtfSAIOVxbi BDvgZ6/e0cPE+3VM/dtDbuN9g7ehYLHodE2nqQNxTOBtsdWWZ1m8HenkPudEfX0o UNqMp7js7YLaMj+9qBwVEds7ngPtDjJlP8j/rN6WyvdEZQ4cnvxEZacVzdUZQc/5 jfBoQI/qdLyZxqsBMhfl2XMmmGtuNPh1QGneOn9ZamiLHEpXvdJXcZ8fBhQnTYig bqb12kfUU/UZhs3bsomlLx4dV4O2R6Jph0BHkJsMM7HmdPOI1su0NiQFCN8ECzmq hhYIR9Gty6EfIMBiamfLJruqTh0+hIU/sq/Fgm9Jr4+8xQ+l0ObW9n6cGshR8YVw YaClN21Z =sjDj -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--