Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 634B3C433F5 for ; Tue, 12 Apr 2022 18:52:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0128F83F1D; Tue, 12 Apr 2022 20:45:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649789157; bh=TiouZ5sp4uoM9M1llX9AnGwUs/Qu4rt5YFi7KvnpEuA=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=F33tW9ddYz8Y0dDlM5ofxt3NUTdV0Gl0aFPVS9AcVTiA5+9jUz8cd1sAJ2GKkjZ+K HNXiX/QMQxHpFUJAxZr/coHc65ef2Zh0jHZrFrdqCVvaRvBnPjIm94V58ve5PjyiKh Ek2pVQRiE7BBsd7orItudnVw5nVdSoaW+z8YqNg0BiMISMaK3jRY0bM60OwerSpYHr gJwRXBcpR26YuKvWrANFDKd/BCtbMXydbqkJcuAdHsNr/fkWAIZNnu49kbU+zRMBT6 v0eMVjQu0Pxds3VszQpfMhdVFSYyVPbipd8LO88Gc7+gazLQHLfr2OsJ+HuHd/KSBv fsQEBHeSL0iXQ== Received: by phobos.denx.de (Postfix, from userid 109) id 5D1A183E45; Tue, 12 Apr 2022 20:45:21 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 667DC83EDA for ; Tue, 12 Apr 2022 20:45:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4KdF5p0SPTz1qyJ7; Tue, 12 Apr 2022 20:45:18 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4KdF5p0LZKz1qqkG; Tue, 12 Apr 2022 20:45:18 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id XOsOv6IYPq4V; Tue, 12 Apr 2022 20:45:17 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 12 Apr 2022 20:45:17 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 1613925 X-Patchwork-Delegate: sbabic@denx.de To: Francesco Dolcini ,u-boot@lists.denx.de Subject: [PATCH v1 1/2] mx6: ddr: Restore ralat/walat in write level calibration In-reply-to: <20220406115325.98086-2-francesco.dolcini@toradex.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Message-Id: <20220412184521.5D1A183E45@phobos.denx.de> Date: Tue, 12 Apr 2022 20:45:18 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > The current DDR write level calibration routine always overwrite > the ralat/walat fields to their maximum value, just save > the existing values at the beginning of the calibration routine > and restore it at the end. > In case the delay is estimated by the user to be more than one cycle the > walat should be configured according to that, this is not > automatically done. From the i.MX6 RM: > The user should read the results of the associated delay-line at > MPWLDECTRL#[WL_DL_ABS_OFFSET#] and in case the user estimates that the > reasonable delay may be above 1 cycle then the user should indicate it at > MPWLDECTRL#[WL_CYC_DEL#]. Moreover the user should indicate it in > MDMISC[WALAT] field. For example, if the result of the write leveling ca= libration > is 100/256 parts of a cycle, but the user estimates that the delay is ab= ove 2 cycles > then MPWLDECTRL#[WL_CYC_DEL#] should be configured to 2, so the total > delay will be 2 and 100/256 parts of a cycle > Probably it would just possible to not overwrite the mdmisc register in > the first place, since this is not present in the write_level_calib() examp= le > in NXP AN4467 nor in the i.MX6 RM (44.11.6.1 Hardware Write Leveling > Calibration). > Fixes: d339f16911c7 ("arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL") > Signed-off-by: Francesco Dolcini > Reviewed-by: Marek Vasut > Reviewed-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D