Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4E77C433EF for ; Tue, 12 Apr 2022 23:12:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B624083AE2; Wed, 13 Apr 2022 01:11:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="D1yWBXRV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3549583AF5; Wed, 13 Apr 2022 01:11:58 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6703C83953 for ; Wed, 13 Apr 2022 01:11:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id d71so117155qkg.12 for ; Tue, 12 Apr 2022 16:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9EhTSGdcIPVSvaWLN8P6MKVZCTkeybK8AGrzaqlG3WQ=; b=D1yWBXRVNGOf4AIIFcECE7N0bxptTWnsKu3W2XDUJsPA3MMra7cevGE8wW5FA/Cnid VHLNmvDXUyIdF1+2lBqQHcBdPLsbudo4+LRV6dVle9cRVql/IrMHLadZfWK0Un7N2P9O t3Na8ALJ+k/rPzQYa3JzvWY/bCBjWV50GG3no= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9EhTSGdcIPVSvaWLN8P6MKVZCTkeybK8AGrzaqlG3WQ=; b=HDQ8pe8ZfXsyUAH6MwqH0VzTlBrsn4YTwCIaWAEdrymhXmZ6kGnk8x4HNXXyltH9OV wVEqM/A0ipGptisSQl+QkilgoY8igAOnTniHihUCvDG9R7HIr7zb/Rmkibe3MUpgq/Gs r/wj04Yp5cjNbanFrWSGCaX2UMBEUm4J0WTM7zwwipkpaOrhS5BQ9tMyl+QZSsvr5MQV aNea0wYbfMSCLiVpB1MssANjZZlSJoMyo2KVlGl5FgsjbyjhcWyAiS6y+57S8ALaxs3J yKpxnSriMn/ezuet8g3d31wa7sVbwolPyBQrUnCBdvDanLQ4vQK9WmFRjWR8PBaLmz1B 6Bxw== X-Gm-Message-State: AOAM530wjQ4qAq+2HxycAY5QBQE14p/W+OI8qCpWqYOLCsDXQbwqbsif 3c98QroQ7xlp6Pwd+cHi7gH8Aw== X-Google-Smtp-Source: ABdhPJyDLF5qWXtPOLFj8ljxlzy6tDh2nlOUpNw07KhFyJetxcS/FVayKg0CMGq3dKEyLo6qwcdyvA== X-Received: by 2002:a37:6041:0:b0:680:f510:79c8 with SMTP id u62-20020a376041000000b00680f51079c8mr5005549qkb.570.1649805114291; Tue, 12 Apr 2022 16:11:54 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id a9-20020ac85b89000000b002e2072c9dedsm29722912qta.67.2022.04.12.16.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:11:53 -0700 (PDT) Date: Tue, 12 Apr 2022 19:11:51 -0400 From: Tom Rini To: Andrew Scull Cc: U-Boot Mailing List , Simon Glass , Bin Meng , Alistair Delva , Keir Fraser , =?iso-8859-1?Q?Pierre-Cl=E9ment?= Tosi Subject: Re: [PATCH v2 13/18] pci: Map bars with offset and length Message-ID: <20220412231151.GR14282@bill-the-cat> References: <20220329165900.1139885-1-ascull@google.com> <20220329165900.1139885-14-ascull@google.com> <20220412164236.GA370634@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dahAzsxSdSzXFIjf" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --dahAzsxSdSzXFIjf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 12, 2022 at 11:54:33PM +0100, Andrew Scull wrote: > On Tue, 12 Apr 2022 at 17:42, Tom Rini wrote: > > > > On Tue, Mar 29, 2022 at 04:58:55PM +0000, Andrew Scull wrote: > > > > > Evolve dm_pci_map_bar() to include an offset and length parameter. Th= ese > > > allow a portion of the memory to be mapped and range checks to be > > > applied. > > > > > > Passing both the offset and length as zero results in the previous > > > behaviour and this is used to migtate the previous callers. > > > > > > Signed-off-by: Andrew Scull > > > > This breaks rpi_arm64 building, and possibly others. It may be helpful > > to read https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html > > and get a CI run completed for the whole series to shake out any other > > failures. Thanks! >=20 > That CI sounds like it will be useful to know how to use, thanks for > the pointers. >=20 > Aside from just building, I'd also be interested in feedback as to > whether this evolution of the API is a suitable direction to be > taking. Ah. To be clear, I was preparing to merge the series and ran in to this problem. So, I think it's fine once CI passes. --=20 Tom --dahAzsxSdSzXFIjf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJWBzcACgkQFHw5/5Y0 tywTeQv+N7JroG9yVPq/8Np8pBEMei5QOEycAeP8ddCwaOUAtTR9V4geMMF34MGq TJm5D/Ih1kDqQv0ixJNQecogbKyUkzmFzOhelzN5eZwiM1A20aR4FYIII/8fGStW UFd74wardFiBQArmc+U43xa4bSQiy42flZLXrG1qyK4Y9UUcpkFYBNJtdgNDr/xa /yny2n4tBs2x5uVVYVkO5kK+YuRAdApwskZOH1S+QtMb8kJBYU5ipazUhGOSA42F vY64Lt54TdyoyKz1uyJQ19JuXuptywv/QCnIEIaUNzUkL76maj/Q/cyzGyV67IgJ jxa23TFqyvRsi8Ust+K4BmAfCow2EnwTvz5OTa7D93O6r5rUX3wR+Y8pVsLkfks1 gpm6gUGz+aTOxO/ImmOuMPmiQ8qN0laLVhcKT4TvUrNZ36TxfYpbZJDSV9ahxnSZ Wd7OkiYHKgH5GXE1o8rKko8Br2DjL5OYz7wjiYXdBJ/kG4tsz4JH1/nn1iIZaVWI rSMj3Vo9 =DuVl -----END PGP SIGNATURE----- --dahAzsxSdSzXFIjf--