Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1887FC433EF for ; Wed, 13 Apr 2022 02:16:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FD5F83D8A; Wed, 13 Apr 2022 04:16:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649816172; bh=NzLElga1MTLp7gm/VTzud9J9fRiZ1CsbCYYBGz92IDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hf/HDJXhWSZZB6pwb3KG4AswfMCOamJRzQeW+IWPGncpqNmmiZoxzD5LI6VHM27m2 6VbgfJ7WJhQUkY6ia8lIr7+FxHUNFjdtLdqUVwatNc4MFjj+gSZZjx/ktXEtfcaU4Z iBLkIbd6QWCWYJUUoC2Q3jl/sfXmeH6zCjP5aQOJyS1JgypPyie3wu6/cPbuWc9IOg EJi7TZUA9iTXfz7TvMY9eeQF6P4A3GyVylGBbyl2kZcN6agtZEVuNpATbxiVVI6B6a vT1h/hl0hbkBuSLtKnWdpdZvOnTlp8E4gbJZNA/i0+70ALCzo7vB7UpdOTajJO1oW1 9BhVoC3WTiZiQ== Received: from tr.lan (ip-86-49-12-201.net.upcbroadband.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2C81983D05; Wed, 13 Apr 2022 04:15:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649816159; bh=NzLElga1MTLp7gm/VTzud9J9fRiZ1CsbCYYBGz92IDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uNl2Od8wpmnAHCdmNQUccWof3I4oB2OIppi3SYMH7jdIp9ElEFxd37INJVYK0Tbhr ywwW63NTFkprHRceu551urlq/2oDzXhj4Q4uo7zxmTjsrummQN7m4qpKG+sZA7F/ON e4YBymRl7rJyWIRU5UM3HLW2iLmKdytxRksHD9K3GA5KXkb7pHwxCmC11KV2jdB1oS GytOvO6fMqC3H/v031w08KXGhrfe40T+sMkVXdxgd3v/yS4YIp7u3zfHxuJ7EGS8Mc 0eOsyPd+VAE6DXVE0m+HUn0Z2ZKg0yYQAl/83x9AjeoNppH+UUK1X8VnSafvohmTwi ciUmKOHBpthqA== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Ramon Fried , Joe Hershberger Subject: [PATCH v2 03/17] net: dm9000: Make RxLen and RxStatus lowercase Date: Wed, 13 Apr 2022 04:15:25 +0200 Message-Id: <20220413021539.454331-3-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220413021539.454331-1-marex@denx.de> References: <20220413021539.454331-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Rename variables to lowercase to be consistent with coding style. No functional change. Reviewed-by: Ramon Fried Signed-off-by: Marek Vasut Cc: Joe Hershberger Cc: Ramon Fried --- V2: Add RB from Ramon --- drivers/net/dm9000x.c | 44 +++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index e83b838fd82..a99a901e828 100644 --- a/drivers/net/dm9000x.c +++ b/drivers/net/dm9000x.c @@ -92,7 +92,7 @@ typedef struct board_info { unsigned char srom[128]; void (*outblk)(volatile void *data_ptr, int count); void (*inblk)(void *data_ptr, int count); - void (*rx_status)(u16 *RxStatus, u16 *RxLen); + void (*rx_status)(u16 *rxstatus, u16 *rxlen); struct eth_device netdev; } board_info_t; static board_info_t dm9000_info; @@ -187,33 +187,33 @@ static void dm9000_inblk_32bit(void *data_ptr, int count) ((u32 *) data_ptr)[i] = dm9000_inl(DM9000_DATA); } -static void dm9000_rx_status_32bit(u16 *RxStatus, u16 *RxLen) +static void dm9000_rx_status_32bit(u16 *rxstatus, u16 *rxlen) { u32 tmpdata; dm9000_outb(DM9000_MRCMD, DM9000_IO); tmpdata = dm9000_inl(DM9000_DATA); - *RxStatus = __le16_to_cpu(tmpdata); - *RxLen = __le16_to_cpu(tmpdata >> 16); + *rxstatus = __le16_to_cpu(tmpdata); + *rxlen = __le16_to_cpu(tmpdata >> 16); } -static void dm9000_rx_status_16bit(u16 *RxStatus, u16 *RxLen) +static void dm9000_rx_status_16bit(u16 *rxstatus, u16 *rxlen) { dm9000_outb(DM9000_MRCMD, DM9000_IO); - *RxStatus = __le16_to_cpu(dm9000_inw(DM9000_DATA)); - *RxLen = __le16_to_cpu(dm9000_inw(DM9000_DATA)); + *rxstatus = __le16_to_cpu(dm9000_inw(DM9000_DATA)); + *rxlen = __le16_to_cpu(dm9000_inw(DM9000_DATA)); } -static void dm9000_rx_status_8bit(u16 *RxStatus, u16 *RxLen) +static void dm9000_rx_status_8bit(u16 *rxstatus, u16 *rxlen) { dm9000_outb(DM9000_MRCMD, DM9000_IO); - *RxStatus = + *rxstatus = __le16_to_cpu(dm9000_inb(DM9000_DATA) + (dm9000_inb(DM9000_DATA) << 8)); - *RxLen = + *rxlen = __le16_to_cpu(dm9000_inb(DM9000_DATA) + (dm9000_inb(DM9000_DATA) << 8)); } @@ -458,7 +458,7 @@ static int dm9000_rx(struct eth_device *netdev) { u8 rxbyte; u8 *rdptr = (u8 *)net_rx_packets[0]; - u16 RxStatus, RxLen = 0; + u16 rxstatus, rxlen = 0; struct board_info *db = &dm9000_info; /* Check packet ready or not, we must check @@ -491,34 +491,34 @@ static int dm9000_rx(struct eth_device *netdev) debug("receiving packet\n"); /* A packet ready now & Get status/length */ - (db->rx_status)(&RxStatus, &RxLen); + (db->rx_status)(&rxstatus, &rxlen); - debug("rx status: 0x%04x rx len: %d\n", RxStatus, RxLen); + debug("rx status: 0x%04x rx len: %d\n", rxstatus, rxlen); /* Move data from DM9000 */ /* Read received packet from RX SRAM */ - (db->inblk)(rdptr, RxLen); + (db->inblk)(rdptr, rxlen); - if ((RxStatus & 0xbf00) || (RxLen < 0x40) - || (RxLen > DM9000_PKT_MAX)) { - if (RxStatus & 0x100) { + if ((rxstatus & 0xbf00) || (rxlen < 0x40) + || (rxlen > DM9000_PKT_MAX)) { + if (rxstatus & 0x100) { printf("rx fifo error\n"); } - if (RxStatus & 0x200) { + if (rxstatus & 0x200) { printf("rx crc error\n"); } - if (RxStatus & 0x8000) { + if (rxstatus & 0x8000) { printf("rx length error\n"); } - if (RxLen > DM9000_PKT_MAX) { + if (rxlen > DM9000_PKT_MAX) { printf("rx length too big\n"); dm9000_reset(); } } else { - DM9000_DMP_PACKET(__func__ , rdptr, RxLen); + DM9000_DMP_PACKET(__func__ , rdptr, rxlen); debug("passing packet to upper layer\n"); - net_process_received_packet(net_rx_packets[0], RxLen); + net_process_received_packet(net_rx_packets[0], rxlen); } } return 0; -- 2.35.1