Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CD47C433EF for ; Wed, 13 Apr 2022 02:16:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD87583DA4; Wed, 13 Apr 2022 04:16:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649816178; bh=Cx7/+QlUlSZFlplpfsCeCoxDg02P9TsxCuOe5/O80Xg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TB7/6TMBaKcGIzKYBHJTdc2qxIOO6hHJvqoHtYRdhy7SKfCoOMLwvN0I9bDGt+afv By/6tiVNnzNbatIUjc4csgO1A9BY59iI9LPrpd3Ax9z+99ZEe4OfQjYAMNRdMXVKqz X0SvUkoOVK9LaIbWapxJ1GpePox39k2S7sDF76TaJHUIsWv0rQIjvCCo1QPW/0J7Gr xVlos0geYs7R22JLuNNX7lZM0dxl8kYQkwrmevHC17kqeJ+VxKYsBMYlU61+hOycw7 4Ggp02D/lKQGBLdrWUCV9XgQsFMo2OHgKvusFHxSeOTXiwSUgWIaynzkQyZSMXtdvU hHtYZDjRV6J0Q== Received: from tr.lan (ip-86-49-12-201.net.upcbroadband.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id CA63383D69; Wed, 13 Apr 2022 04:15:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649816160; bh=Cx7/+QlUlSZFlplpfsCeCoxDg02P9TsxCuOe5/O80Xg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MVAQL5EvBKgCK03uLh7xzpgCizWlngKPT1DFdzPSOfZnz5BbJiEBe+Bw1wTKo7zA2 jV5cXwVD8CxegM3lXLW0JGizTndsh9vQPF3TUFgQ9oKioBvXB4Eq/t2qRU1s6NAiOQ DBmL5iD0BxM4E4ru1MTqy/wl0/FZ32Kve2UoZaCOs43Bh0NHM93Ik2brHghYnHYS+j x6/iYO8mzvGAjYIR4YP8F1jqdFvVNHuhhXoEleR1loCrsnPqHfmKNK7tw0QRHaOUO7 yqysa2VigNxmKfR551pZLpcwIrf5EDfh6S6Z9+8ES8FZM50Lf0fal4QzWkgKk2/bq5 /pOaRPJlpt8Bw== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Ramon Fried , Joe Hershberger Subject: [PATCH v2 05/17] net: dm9000: Turn DM9000_DMP_PACKET() into a function Date: Wed, 13 Apr 2022 04:15:27 +0200 Message-Id: <20220413021539.454331-5-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220413021539.454331-1-marex@denx.de> References: <20220413021539.454331-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Rework DM9000_DMP_PACKET() into dm9000_dump_packet() function, this brings better type checking. No functional change. Reviewed-by: Ramon Fried Signed-off-by: Marek Vasut Cc: Joe Hershberger Cc: Ramon Fried --- V2: Add RB from Ramon --- drivers/net/dm9000x.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index 223df944a48..da16b64610b 100644 --- a/drivers/net/dm9000x.c +++ b/drivers/net/dm9000x.c @@ -58,25 +58,6 @@ TODO: external MII is not functional, only internal at the moment. #include "dm9000x.h" -/* Board/System/Debug information/definition ---------------- */ - -/* #define CONFIG_DM9000_DEBUG */ - -#ifdef CONFIG_DM9000_DEBUG -#define DM9000_DMP_PACKET(func,packet,length) \ - do { \ - int i; \ - printf("%s: length: %d\n", func, length); \ - for (i = 0; i < length; i++) { \ - if (i % 8 == 0) \ - printf("\n%s: %02x: ", func, i); \ - printf("%02x ", ((unsigned char *) packet)[i]); \ - } printf("\n"); \ - } while(0) -#else -#define DM9000_DMP_PACKET(func,packet,length) -#endif - /* Structure/enum declaration ------------------------------- */ typedef struct board_info { u32 runt_length_counter; /* counter: RX length < 64byte */ @@ -122,6 +103,25 @@ static void dm9000_iow(int reg, u8 value); #define dm9000_inl(r) __raw_readl(r) #endif +#ifdef DEBUG +static void dm9000_dump_packet(const char *func, u8 *packet, int length) +{ + int i; + + printf("%s: length: %d\n", func, length); + + for (i = 0; i < length; i++) { + if (i % 8 == 0) + printf("\n%s: %02x: ", func, i); + printf("%02x ", packet[i]); + } + + printf("\n"); +} +#else +static void dm9000_dump_packet(const char *func, u8 *packet, int length) {} +#endif + static void dm9000_outblk_8bit(volatile void *data_ptr, int count) { int i; @@ -387,7 +387,7 @@ static int dm9000_send(struct eth_device *netdev, void *packet, int length) int tmo; struct board_info *db = &dm9000_info; - DM9000_DMP_PACKET(__func__ , packet, length); + dm9000_dump_packet(__func__ , packet, length); dm9000_iow(DM9000_ISR, IMR_PTM); /* Clear Tx bit in ISR */ @@ -498,7 +498,7 @@ static int dm9000_rx(struct eth_device *netdev) dm9000_reset(); } } else { - DM9000_DMP_PACKET(__func__ , rdptr, rxlen); + dm9000_dump_packet(__func__ , rdptr, rxlen); debug("passing packet to upper layer\n"); net_process_received_packet(net_rx_packets[0], rxlen); -- 2.35.1