Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54448C433EF for ; Wed, 13 Apr 2022 02:18:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6709883E7A; Wed, 13 Apr 2022 04:16:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649816211; bh=mdKHkZqUzU+2N0gd0wNFXtR7MLoDZBt8J03HkX0/nQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wWfWbewpgAK3XXtcE+uvgjrl6HWkBB9Wk279vDOaDAJW81DyQD6+5ExP+RTsvwMOO S3JRvRzNJ11v54x6ZgwYnbyBSSV5o/FHiC4T4qyul+gTuppKJKTlMQJ7YgS1FlWgj8 lf4RHcGMrX2+xYrN20b5ZIP1b7/F6BmJW0b4CHWg/wUq5ESpVGZmxEcK1qpVIq0Y3w Udr8HB4PKOOLRmiuNAw8oArxr4aYJv/uMakQ8guzjXeH5aBgfIL7nZcfGPgM28GeHD PWLbILY6+p1Q5DB0yCq/V7d98zT6JI5T9nilGwr4sKnUEN/RYbMy8nFwlzJC3YIVLI MtrHQ/LMTxeww== Received: from tr.lan (ip-86-49-12-201.net.upcbroadband.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2902383D6E; Wed, 13 Apr 2022 04:16:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649816160; bh=mdKHkZqUzU+2N0gd0wNFXtR7MLoDZBt8J03HkX0/nQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fpJzcQfOyfz4mfSHv7OlJ7vsf2neStB0eCETTK+DivXjXy8AUUFe5NwyQ434u84CI 6Me5HzCbcXxo/+oW6rgu0aNmHR7ugwFq8W521OxsfA/T1qPrzv0+WBL+rkPJz8Tqd2 r1xHO8dhoWrpWNuRW3j5XFZR8Iau0ugC49jaaDCv858PSrssoNZPfoHB7P45F4XGW6 wrmGhSyNb48TE3uQT1F8K2BgzO98dorUuOJMPt82+JK8/dn0gWIjwWBg50UdIjHj+Z ppvFIu0188Ud6NehUhrLpd+AquW5qiewhWoYUwgFi9sshG93vT2i3XfkjVE66No3Jz gVaPyMbaaPOUw== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Ramon Fried , Joe Hershberger Subject: [PATCH v2 06/17] net: dm9000: Drop volatiles Date: Wed, 13 Apr 2022 04:15:28 +0200 Message-Id: <20220413021539.454331-6-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220413021539.454331-1-marex@denx.de> References: <20220413021539.454331-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Remove volatile keyword usage from arrays, they are not really volatile in any way, so this keyword is misused here. No functional change. Reviewed-by: Ramon Fried Signed-off-by: Marek Vasut Cc: Joe Hershberger Cc: Ramon Fried --- V2: Add RB from Ramon --- drivers/net/dm9000x.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index da16b64610b..aacf5f670e9 100644 --- a/drivers/net/dm9000x.c +++ b/drivers/net/dm9000x.c @@ -71,7 +71,7 @@ typedef struct board_info { u8 phy_addr; u8 device_wait_reset; /* device state */ unsigned char srom[128]; - void (*outblk)(volatile void *data_ptr, int count); + void (*outblk)(void *data_ptr, int count); void (*inblk)(void *data_ptr, int count); void (*rx_status)(u16 *rxstatus, u16 *rxlen); struct eth_device netdev; @@ -88,12 +88,12 @@ static void dm9000_iow(int reg, u8 value); /* DM9000 network board routine ---------------------------- */ #ifndef CONFIG_DM9000_BYTE_SWAPPED -#define dm9000_outb(d,r) writeb(d, (volatile u8 *)(r)) -#define dm9000_outw(d,r) writew(d, (volatile u16 *)(r)) -#define dm9000_outl(d,r) writel(d, (volatile u32 *)(r)) -#define dm9000_inb(r) readb((volatile u8 *)(r)) -#define dm9000_inw(r) readw((volatile u16 *)(r)) -#define dm9000_inl(r) readl((volatile u32 *)(r)) +#define dm9000_outb(d,r) writeb((d), (r)) +#define dm9000_outw(d,r) writew((d), (r)) +#define dm9000_outl(d,r) writel((d), (r)) +#define dm9000_inb(r) readb(r) +#define dm9000_inw(r) readw(r) +#define dm9000_inl(r) readl(r) #else #define dm9000_outb(d, r) __raw_writeb(d, r) #define dm9000_outw(d, r) __raw_writew(d, r) @@ -122,14 +122,14 @@ static void dm9000_dump_packet(const char *func, u8 *packet, int length) static void dm9000_dump_packet(const char *func, u8 *packet, int length) {} #endif -static void dm9000_outblk_8bit(volatile void *data_ptr, int count) +static void dm9000_outblk_8bit(void *data_ptr, int count) { int i; for (i = 0; i < count; i++) dm9000_outb((((u8 *) data_ptr)[i] & 0xff), DM9000_DATA); } -static void dm9000_outblk_16bit(volatile void *data_ptr, int count) +static void dm9000_outblk_16bit(void *data_ptr, int count) { int i; u32 tmplen = (count + 1) / 2; @@ -137,7 +137,7 @@ static void dm9000_outblk_16bit(volatile void *data_ptr, int count) for (i = 0; i < tmplen; i++) dm9000_outw(((u16 *) data_ptr)[i], DM9000_DATA); } -static void dm9000_outblk_32bit(volatile void *data_ptr, int count) +static void dm9000_outblk_32bit(void *data_ptr, int count) { int i; u32 tmplen = (count + 3) / 4; -- 2.35.1