Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26357C433EF for ; Wed, 13 Apr 2022 02:49:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8B5AA83E1F; Wed, 13 Apr 2022 04:49:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649818194; bh=24ASrhDinIndxVCN5YIq7tE11F+s5u8FSPa9s7rj+/g=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=nv+SdJbgJUTDKzd6b82rQSnp5hthiUUom6L5IWP9lR6T5UYNo/Ow4N7fi+P0BmrmI lvyqcAXJoLZaYgyGJdh2vQgIWYu2QNxvtnf5bugHHfFBBrGsjAR1oLG6pwO2GoxH75 dKzFeJIOAUcZXl9IsCbcaAQQDEsw+k8hpjHYKCxj1tEI+NLO6twkDb0g6eInUBMQCu 6Habk4epIo2WGlXeJs5eb5cOPovJRflPaZOmDCPurg7xDdDNMrVDflhUq0jWwRbcBk RuN5uBwwFcZwjiZfTaDecG18kGOPri+GuNVqXDn1XWANbVfw+0L+zNnVWQiSQJfwNC CRjO6Ac41u4bw== Received: from tr.lan (ip-86-49-12-201.net.upcbroadband.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3581E83D3D; Wed, 13 Apr 2022 04:49:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649818191; bh=24ASrhDinIndxVCN5YIq7tE11F+s5u8FSPa9s7rj+/g=; h=From:To:Cc:Subject:Date:From; b=hshDAFsFlSHv8f1QMwE1qiyb5dvA7LjyK/2KGLThIQpPDbI9ulGKFovahSS6kOLKX Qx+EL3JnriKr+eQQRSAVQET3RZZxX/K6uKi/3nV+GEycHCz2yi1Us2MxVG6xWDq7Z4 +rKh6jHMPbDOBefao95G3Yemwxt7RNcdH7XyWR/B/RmGjbWySKIRLArtlx/V9Dda9f SOam6BhbBV+rEk9FZifahCA28+t1QYYxGdtpWLyUV1Hs1+7QxjIZwMAWAfTpd8okVd CujF5wHHhiODU/NJgw/Yf7+ZTkE29W6scJ1refYJMQV4xdUNzYm55fcFz1sQBeRZDi jF3XvmYzP1Hcw== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Patrick Delaunay , Patrice Chotard Subject: [PATCH] ram: stm32mp1: Conditionally enable ASR Date: Wed, 13 Apr 2022 04:49:37 +0200 Message-Id: <20220413024937.502193-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Enable DRAM ASR, auto self-refresh, conditionally, based on DT property "st,mem-enable-asr" . While ASR does save considerable amount of power at runtime automatically, it also causes LTDC underruns on large panels. Let user select whether or not ASR is required or not, generally ASR should be enabled on portable and battery operated devices. Signed-off-by: Marek Vasut Cc: Patrick Delaunay Cc: Patrice Chotard --- drivers/ram/stm32mp1/stm32mp1_ddr.c | 3 ++- drivers/ram/stm32mp1/stm32mp1_ddr.h | 1 + drivers/ram/stm32mp1/stm32mp1_ram.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ram/stm32mp1/stm32mp1_ddr.c b/drivers/ram/stm32mp1/stm32mp1_ddr.c index 528a171b454..fd11e02aff4 100644 --- a/drivers/ram/stm32mp1/stm32mp1_ddr.c +++ b/drivers/ram/stm32mp1/stm32mp1_ddr.c @@ -845,7 +845,8 @@ start: config->c_reg.pwrctl); /* Enable auto-self-refresh, which saves a bit of power at runtime. */ - stm32mp1_asr_enable(priv); + if (config->info.enable_asr) + stm32mp1_asr_enable(priv); /* enable uMCTL2 AXI port 0 and 1 */ setbits_le32(&priv->ctl->pctrl_0, DDRCTRL_PCTRL_N_PORT_EN); diff --git a/drivers/ram/stm32mp1/stm32mp1_ddr.h b/drivers/ram/stm32mp1/stm32mp1_ddr.h index 861efff92be..c74a9cea2cc 100644 --- a/drivers/ram/stm32mp1/stm32mp1_ddr.h +++ b/drivers/ram/stm32mp1/stm32mp1_ddr.h @@ -144,6 +144,7 @@ struct stm32mp1_ddr_info { const char *name; u32 speed; /* in kHZ */ u32 size; /* memory size in byte = col * row * width */ + bool enable_asr; }; struct stm32mp1_ddr_config { diff --git a/drivers/ram/stm32mp1/stm32mp1_ram.c b/drivers/ram/stm32mp1/stm32mp1_ram.c index 49b1262461b..f39cfad4764 100644 --- a/drivers/ram/stm32mp1/stm32mp1_ram.c +++ b/drivers/ram/stm32mp1/stm32mp1_ram.c @@ -122,6 +122,7 @@ static int stm32mp1_ddr_setup(struct udevice *dev) config.info.speed = ofnode_read_u32_default(node, "st,mem-speed", 0); config.info.size = ofnode_read_u32_default(node, "st,mem-size", 0); config.info.name = ofnode_read_string(node, "st,mem-name"); + config.info.enable_asr = ofnode_read_bool(node, "st,mem-enable-asr"); if (!config.info.name) { dev_dbg(dev, "no st,mem-name\n"); return -EINVAL; -- 2.35.1