Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 309D2C433F5 for ; Fri, 15 Apr 2022 12:10:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 89E4A83DDA; Fri, 15 Apr 2022 14:09:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="H53tC0N1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7FE9E83E4B; Fri, 15 Apr 2022 14:08:53 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E91A683E4B for ; Fri, 15 Apr 2022 14:08:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id b189so6485662qkf.11 for ; Fri, 15 Apr 2022 05:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RqL/7EF/6gShOmPaFYuB6C7DuNF0LCn2iHuw2UqB/cM=; b=H53tC0N12FiQ94GuUbFexPDHBSIdGKmSPjqVdhdB7ZKWEjHTlbyN1u3MWoUHoDa1jB 9uIrm904AexGGIAh8QFXVUYQ8TnGlmtZjVJ4Nm2zcA7o5TTVTUo5y4ne4bo1PmJtAWFp Ub+9yA+z2Kz+hNiExTdBvx47SUDNCz/fcQzS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RqL/7EF/6gShOmPaFYuB6C7DuNF0LCn2iHuw2UqB/cM=; b=ARP9aCDHd3LAepkfTuc/2YTcQCSGlB5axU1PWapGkbxljdXmMbfELKUOYrbs257gd8 mZOnpFgQHX+qbGnO+5FzzbcmaLxhS7ZQLkCX9cVXzX7WtlUiRkSoTos6dx0uVWUT50Wx VjmdyFq51H8h/6YS5IuB3ZFswT4W8tlCaz0S9DgxVeVxiv+unHludNPnkWWgbrIB2tU+ hTNpW8CiGawncTxon4mb0ndBo5bvEROEUwnP2HIcs91hYz1NdosZEpL8HkrBqX3mz+Pq GuUvdIGaJys9ck+CdBF0FJ9OJQcq2nNT40dv1bvYy+LghhuqrG/QBUl6IeRAiMTGTxW6 0joA== X-Gm-Message-State: AOAM531GxL2fVCvlsPoPsnxkr8J3e0Lh9HqbB5Mg5g7lBZbrCVD+cH1G 0oJyGyHhXT+qumgCr5W6XWnXE0XJdJuPZQ== X-Google-Smtp-Source: ABdhPJw/wAzUZNVJDu2pVxmlH+F5AvNJOBj2deucdEpIbSXwEldmtoAcqa4kCgWA7C2YLLm59OuhMw== X-Received: by 2002:a05:620a:171e:b0:69c:2480:cfea with SMTP id az30-20020a05620a171e00b0069c2480cfeamr5358198qkb.247.1650024529398; Fri, 15 Apr 2022 05:08:49 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id i5-20020a05620a074500b0069c310c5fbesm2330496qki.135.2022.04.15.05.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 05:08:48 -0700 (PDT) Date: Fri, 15 Apr 2022 08:08:46 -0400 From: Tom Rini To: u-boot@lists.denx.de Cc: Alexander Graf Subject: Re: [PATCH] Remove duplication of table_compute_checksum function Message-ID: <20220415120846.GT14282@bill-the-cat> References: <20220404184351.4041677-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cpjgzoJucjx6xRSo" Content-Disposition: inline In-Reply-To: <20220404184351.4041677-1-trini@konsulko.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --cpjgzoJucjx6xRSo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 04, 2022 at 02:43:51PM -0400, Tom Rini wrote: > It seems like there was some merge error when first cleaning up and > sharing this function. We have both an inline version of the function > in include/tables_csum.h and a non-inline version in lib/tables_csum.c. > Rework things so that we only have the non-inline version (due to number > of calls, we should not inline this). >=20 > Fixes: 1befb38b8682 ("x86: Move table csum into separate file") > Fixes: 2b445e4d3194 ("x86: Move table csum into separate header") > Cc: Alexander Graf > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! --=20 Tom --cpjgzoJucjx6xRSo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJZYE4ACgkQFHw5/5Y0 tyyeWQv/cxOSb1E6Aa9TqnrshAC6zq5QVZVV6oQKDba2qumjd2LPZ38/Ax9iyZvc roacPxRjsF4gmVzXqPZxk7jAbfbuoIKTKiWTGOOE26o4TkRy+d8jjQOWakhIbd6a IrGHvrxFz6whx8KpGAwneYByEgLYRYdP802MJRBISR3TN+cRmXwibwszTgC09PCJ n30xIG2KSCrtejuQSQx74ES/3Iv6wzRcvkCyDviqLORLCCeZco7wkT0v3xenEuC+ A64xlRW1U1mwmQ+I1xRHiW8zVw5wmPohm4EfIff2WpQbomqQay6V5dU/hHB+AkIj AamR9reZCzZZrLNXTlvKf9N/dZOBhvHQqXmO3hYy6bIzXLCZXdXEgOZrGz7BMcjd BlZWYax7qmj8cz5U1KVUz0zcDa1rFpOMO6qyQs+m1IoHvsQu4nK2YiKfcA3gZhBx egWR/lqBYOyuAEQq2v5JxMdCly9024KyWgTDtcgAUntLZlHMHT+1FsoNevld09ie j6NoBESn =lXmm -----END PGP SIGNATURE----- --cpjgzoJucjx6xRSo--