Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB619C433EF for ; Sat, 16 Apr 2022 11:09:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1E08083C70; Sat, 16 Apr 2022 13:09:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=mirx.dev Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mirx.dev header.i=@mirx.dev header.b="aCoGUeu8"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="QpPEGpqF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 87C0283AC9; Sat, 16 Apr 2022 02:12:51 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DC19F80544 for ; Sat, 16 Apr 2022 02:12:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=mirx.dev Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andrew@mirx.dev Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id CEE3B3200E89; Fri, 15 Apr 2022 20:12:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 15 Apr 2022 20:12:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirx.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1650067963; x=1650154363; bh=e+/C6878UMhbiAPD2VzyPYbBv +pMlqqqTCYKA0WMmnk=; b=aCoGUeu8PFGZoVjawQDzaxZ7BeAvZms6L9vzTo8Rf HDU5ud0BjwhlUUB9ndEweIpHzkqCi/vGd3qA2suHH44aRW3DmbT0O5IxCKL4YQxD vH1Z2R5/qwzIW7t8pgwNmlZx/61YFlVME196xFKoNe45mrWbRIMjoOjBGmRdsCSH NKSddBYnMK2AvSRbJqWYMTMegjBNPvBG6H6Ka2nGF52+aOT0g1i4ae+7eH+clr9F oN7AtXigfuydqGsgTX23UsfgedUPEbunpeF11AT4QkTbQI+prfC0m+/WTvrobUIu EXfDQjQ2wV7q3h37SOhHRNIAYQjuEOyIR43MRxa0ihGsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1650067963; x=1650154363; bh=e +/C6878UMhbiAPD2VzyPYbBv+pMlqqqTCYKA0WMmnk=; b=QpPEGpqF8lOnUvc0Y hTn/XYcgROtBS5/0T7kj5V+LT6QN1e07tbAQ6eAHp186Q/r1oWfqhRGFcVktWuLT 34wxTpMQpwJlAhKLMaCZFmkG0LOOMsAu/9Ucg2fxnWGiNRqyGnLQsLQBeGlqq980 VVvSd2+OyrWoJnn0eMUNr58FswqIAcUxAJvuzPmG1JeQryyfsZ4r0eTAu4jKqK/Q hyyqUiDh843nUITT1QI2JsKauiRTBCboV10d3Qa1Pq2qCIAQ+Bfp36n0Fdgwi7zF lhL4tUMjSiSmtImg1ik1yxND0zeu8JqO2jM8FWiUlZnnL9r+DB34bhlSlAUjUG26 11u3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeliedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomheptehnughrvgifucetsggsohhtthcuoegrnhgurhgvfiesmhhirhig rdguvghvqeenucggtffrrghtthgvrhhnpefhteelkedtkeeigfdvgfelffegudejhfelve dtteeugeduvdeiueeutedvkedvheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrnhgurhgvfiesmhhirhigrdguvghv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Apr 2022 20:12:41 -0400 (EDT) From: Andrew Abbott To: u-boot@lists.denx.de Cc: Andrew Abbott , sjg@chromium.org Subject: [PATCH] fdt: Fix TPL SEPARATE_BSS check when locating DTB Date: Sat, 16 Apr 2022 10:12:31 +1000 Message-Id: <20220416001231.843315-1-andrew@mirx.dev> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sat, 16 Apr 2022 13:09:53 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Commit 690af71850149bf242502f688eca80fb302d1f76 changed this condition from an explicit IS_ENABLED(CONFIG_SPL_SEPARATE_BSS) to CONFIG_IS_ENABLED(SEPARATE_BSS) The documentation for CONFIG_IS_ENABLED() in include/linux/kconfig.h implies that we will get the correct behaviour, but the actual behaviour differs such that this condition is now always false. This stopped TPL being able to load the device tree blob at least on the ROCKPro64 board (RK3399 SoC), since the wrong device tree location was chosen. The issues causing this behaviour with CONFIG_IS_ENABLED() are: 1. The documentation implies that CONFIG_SPL_BUILD => CONFIG_SPL_