Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E066C433F5 for ; Tue, 19 Apr 2022 18:11:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20EEB10EE98; Tue, 19 Apr 2022 18:11:36 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D4AC10E805; Tue, 19 Apr 2022 18:11:34 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B5ABA60C90; Tue, 19 Apr 2022 18:11:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 700E6C385A5; Tue, 19 Apr 2022 18:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650391893; bh=j2fWnchsZdK99kusfeZuzP3ZMiYvZ++rKX4EyqUwgpo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SgNHZpus1HSMf8hmR4xe2BfEF+8U6Dml+ZT7dL7d32f2skcqCzA+OPGWn/LHg9/mT 5thDpOEu5DHeOUF0AwwnRO8wpNctwdFSV994MD46lPOTD7/DUkfWysI9t2BCy5XdTQ OI2E9dlNpPo68UdqiAmqEHCDEvJg+8KJhBMSNvjAqyoIItsVgVQgltUcM6lPdYpvOR li/Dopbk+Jdf4LoqHVN9y9wyYPpi9Gfr+Hm4t3XyzAFxRcMeuetlL0Fl+BYpfD3f4y lD8z9EfFYOV570Wixxdc++KLIeMcmwlC71LJHiD2LXypbZndHeEz9aKLTGhoopEknw JM8A5wTWA6kPw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 08/34] drm/msm/disp: check the return value of kzalloc() Date: Tue, 19 Apr 2022 14:10:35 -0400 Message-Id: <20220419181104.484667-8-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220419181104.484667-1-sashal@kernel.org> References: <20220419181104.484667-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Sasha Levin , airlied@linux.ie, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Xiaoke Wang , dri-devel@lists.freedesktop.org, Abhinav Kumar , dmitry.baryshkov@linaro.org, bjorn.andersson@linaro.org, sean@poorly.run, greenfoo@u92.eu Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Xiaoke Wang [ Upstream commit f75e582b0c3ee8f0bddc2248cc8b9175f29c5937 ] kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it to prevent potential wrong memory access. Signed-off-by: Xiaoke Wang Reviewed-by: Abhinav Kumar Link: https://lore.kernel.org/r/tencent_B3E19486FF39415098B572B7397C2936C309@qq.com Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c index 5d2ff6791058..acfe1b31e079 100644 --- a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c +++ b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c @@ -176,6 +176,8 @@ void msm_disp_snapshot_add_block(struct msm_disp_state *disp_state, u32 len, va_list va; new_blk = kzalloc(sizeof(struct msm_disp_state_block), GFP_KERNEL); + if (!new_blk) + return; va_start(va, fmt); -- 2.35.1