Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34009C433EF for ; Tue, 19 Apr 2022 20:32:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D803E83B63; Tue, 19 Apr 2022 22:32:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pI1AKHRK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6D50283C08; Tue, 19 Apr 2022 22:32:49 +0200 (CEST) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D228483B4D for ; Tue, 19 Apr 2022 22:32:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id a10so14043117qvm.8 for ; Tue, 19 Apr 2022 13:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Z6wNrXhCueb5g9MBWr6VDkzFOhzWa8ABy6S4t45AKpY=; b=pI1AKHRKr5mDv4sFWOVUN+OY7Jx7RMXEyYJqOyXNnGSdIrzs0QaUyfVRlmTbz8diYY buay46Ka4aykUR+KoYmB3NHYZtOqSZ2oHu2c7ladzk3JC9TvLQQkIm27FVSpnFG/pKLJ 1fYxSiPP5r/SMeCTWTjNyT3XOZnM7UC44kSNI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z6wNrXhCueb5g9MBWr6VDkzFOhzWa8ABy6S4t45AKpY=; b=AUDUN/H3wnRhirLGnLgbPSv2ydufB5DV9EWCs+mxieyp1l6yYTBPlor43JlZGCf06j 4UfuIKrcNYxFOPHYNZSIhg4mn2Uy1mktw72mTFa1qv+B3FbuZYK5LryI3+vHSm8mRIvW 0CeslVm3T5JdkmviS/GWYW3+KX54RdWXComcIkf6bEz/3YaqwmI5s/lxj/vZUzk1ST7v StoQogTHI/eUpYYF/Wj5B0NaMuGEeifzGP3tvt7a5akGORaMOx+EVoMRabUaMxLRHoR8 lZIt89RLKsby+2/S9ogHVTR+KlluuVoR30b2li5diBo8e9mFhNatKm3P/r2NDKvsDm5z 89Hw== X-Gm-Message-State: AOAM530QCm/ipgAuNxrfa7P6TFXjJLuB+FtOmt0PCLTbIXilgQS/LZbx 5ZfkLxdOeW0zK0Q7DrtCAFat8JJ3ZvvOfw== X-Google-Smtp-Source: ABdhPJxbHd+YAEdulvfrPIFDI8518rdZc+ci9cDC2B1oJTq/0Ye0c4JpMNZVw/VVz1FNPxB8/wqFng== X-Received: by 2002:a05:6214:2268:b0:446:66a8:85ca with SMTP id gs8-20020a056214226800b0044666a885camr6507820qvb.21.1650400365531; Tue, 19 Apr 2022 13:32:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id y15-20020a05620a09cf00b0069c80404de6sm470717qky.31.2022.04.19.13.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 13:32:44 -0700 (PDT) Date: Tue, 19 Apr 2022 16:32:42 -0400 From: Tom Rini To: Samuel Dionne-Riel Cc: u-boot@lists.denx.de Subject: Re: [PATCH] cmd: Add pause command Message-ID: <20220419203242.GA177260@bill-the-cat> References: <20211220224946.033b3f99.samuel@dionne-riel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <20211220224946.033b3f99.samuel@dionne-riel.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 20, 2021 at 10:49:46PM -0500, Samuel Dionne-Riel wrote: > This command is being introduced with the goal of allowing user-friendly > "generic use case" U-Boot builds to pause until user input under some > situations. >=20 > The main use case would be when a boot failure happens, to pause until > the user has had time to acknowledge the current state. >=20 > Signed-off-by: Samuel Dionne-Riel > --- > cmd/Kconfig | 7 +++++++ > cmd/Makefile | 1 + > cmd/pause.c | 35 +++++++++++++++++++++++++++++++++++ > 3 files changed, 43 insertions(+) > create mode 100644 cmd/pause.c Sorry for the delay. Please don't make this default, and also please add a test for the command. Thanks. --=20 Tom --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJfHGoACgkQFHw5/5Y0 tyw+IAv9GQ/VjP5c9y9AjCMnQH7P3TipqCzNZILHKNizuQq3lbponnLSOlMpgOa8 LrI2Y1p4PS3NCkZTFU/KT/rouU/zT5h46lVjDFXzEWoHUzVUmrk2fzW4DGDXJF5x P2OmBWuNaYaaFA9AefgjJmWLNXAkt8iSgCqcC82DEa1EZHqUbQO7HdUY0q9V+qim Y82bYYJwyGlo0OO7ykrYRjuA852mqrdtE3/ZejWxN5RTqR/bObJLjeYJsT8w+2rl 239OQh5M8+YuN8VoxUV2zDJh119ima/yoJA74LPAMRJXuR9qy72PU365w/vHhXjT VCsokDdhGEyHgCuob0luxq5e2oagxqUpXo8jMdBavNWcfJ4B10fbnvaHszwxP8+8 ehKM8dI8Vde0pnaEqedp3/jUc0NXuMb1+/tnYZwU2DngFXenxN9wTBA1j3+wjNuZ zQ7rccjFff0S3FZAxUmUNT62xat/tQmfe465M15+1oM+yTnMSuUz/O/+nK4QWGps RTcP2TCw =LrbT -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--