Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B318EC433F5 for ; Wed, 20 Apr 2022 13:12:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 04FBE83E1D; Wed, 20 Apr 2022 15:11:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Fmo7Py37"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 17E0683DE7; Wed, 20 Apr 2022 15:11:51 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0975D83E0E for ; Wed, 20 Apr 2022 15:11:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id s70so1127277qke.8 for ; Wed, 20 Apr 2022 06:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5E27vS7MWyGzpYFEqrZkR5xKKw4PBAyd7okDQbjlvVc=; b=Fmo7Py37j0IVZsLMkJDXOIiVhDEEie/kyiRyapbfYSZcOTuPY1TWhoxFZtXVMOH745 TC3VrYmcR+w7+cUYdUoFRk4djrLRIotVOn9RJ5nj3DiiJzFf2BRq8GhqKUzUTdvnKC0V G0QZF+Zv7cavpNcqa2rtDx166C8ln/3RyLE3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5E27vS7MWyGzpYFEqrZkR5xKKw4PBAyd7okDQbjlvVc=; b=r4HbM3FGq4cmVmST7CGDL/KiTWcvTKsuYeHNUdyKLsDiA2H0kHZa1hBIIqLdZQQTGL z8RWbE6IULAE95+GRiD/cRb8m2rhPvjj/QyoZjdVwRVqKz+hJE/3+uLIz4NIAJGYpk84 6utwOtLvobfTFs/Yo3d037wYE8x1ErJFBao02eO0s1Rky8ocOHVm7zgxuV8qqK97hNvE 6uq2MAFEtTrx/LRVf+JvJJNY88+wW+6QHcgf3Dq9AINrbz0GDF3hV6lJa4KH0OtSWSF1 PnlFFd1X367KI4sFgKql//X51JBCSUBPRivih+g6pI3o14/aqs0C9A2WHu6HONU2akSj I2mQ== X-Gm-Message-State: AOAM530Wpta0q4BiNuxTMQlOOFwWGMhMMlT42nEK9T2ZeY3rhhLBVkf7 ThAZa26bNfEiMPq+oZ9XgClrmA== X-Google-Smtp-Source: ABdhPJzTqBNDV26XOH4oj9+1oa9/pMDzc16ybiySee7eHwwY3/hkx9ftT3gdUR5xqAdWqqL9oaNd9w== X-Received: by 2002:a37:6412:0:b0:69e:68cf:d889 with SMTP id y18-20020a376412000000b0069e68cfd889mr12018480qkb.443.1650460302331; Wed, 20 Apr 2022 06:11:42 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id x23-20020a05620a099700b0069e5cd89332sm1404907qkx.77.2022.04.20.06.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:11:41 -0700 (PDT) Date: Wed, 20 Apr 2022 09:11:39 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Marek Behun , Qu Wenruo , u-boot@lists.denx.de Subject: Re: [PATCH] btrfs: Fix compilation on big endian systems Message-ID: <20220420131139.GC3045430@bill-the-cat> References: <20220407125103.5074-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="je0mZywpqEo4t1RU" Content-Disposition: inline In-Reply-To: <20220407125103.5074-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --je0mZywpqEo4t1RU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 07, 2022 at 02:51:03PM +0200, Pali Roh=C3=A1r wrote: > Fix following two compile errors on big endian systems: >=20 > CC fs/btrfs/btrfs.o > In file included from include/linux/byteorder/big_endian.h:107, > from ./arch/powerpc/include/asm/byteorder.h:82, > from ./arch/powerpc/include/asm/bitops.h:8, > from include/linux/bitops.h:152, > from include/uuid.h:9, > from fs/btrfs/btrfs.c:10: > fs/btrfs/conv-funcs.h: In function =E2=80=98btrfs_key_to_disk=E2=80=99: > include/linux/byteorder/generic.h:90:21: error: =E2=80=98__cpu_to_le16=E2= =80=99 undeclared (first use in this function); did you mean =E2=80=98__cpu= _to_le16p=E2=80=99? > #define cpu_to_le16 __cpu_to_le16 > ^~~~~~~~~~~~~ > fs/btrfs/conv-funcs.h:79:10: note: in expansion of macro =E2=80=98cpu_to_= le16=E2=80=99 > __u16: cpu_to_le16, \ > ^~~~~~~~~~~ >=20 > CC fs/btrfs/compression.o > In file included from ./arch/powerpc/include/asm/unaligned.h:9, > from fs/btrfs/compression.c:16: > include/linux/unaligned/access_ok.h:6:19: error: redefinition of =E2=80= =98get_unaligned_le16=E2=80=99 > static inline u16 get_unaligned_le16(const void *p) > ^~~~~~~~~~~~~~~~~~ > In file included from fs/btrfs/ctree.h:16, > from fs/btrfs/btrfs.h:12, > from fs/btrfs/compression.c:8: > include/linux/unaligned/le_byteshift.h:40:19: note: previous definition o= f =E2=80=98get_unaligned_le16=E2=80=99 was here > static inline u16 get_unaligned_le16(const void *p) > ^~~~~~~~~~~~~~~~~~ >=20 > Include file asm/unaligned.h contains arch specific macros and functions > for unaligned access as opposite to linux/unaligned le_byteshift.h which > contains macros and functions specific to little endian systems only. >=20 > Signed-off-by: Pali Roh=C3=A1r > Reviewed-by: Marek Beh=C3=BAn > Reviewed-by: Qu Wenruo Applied to u-boot/master, thanks! --=20 Tom --je0mZywpqEo4t1RU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJgBosACgkQFHw5/5Y0 tyy86wv9HME6P6+jIT16kKc2wbk3sKjdCg+vcreEs/4sl1/hL7wj2G0fYZyABSOz tSUlrJoIxtIk7ItCtysvI5dtUZssZg0cB4iVg6xtOVtAZogkTVhgXjzQLWTMXMMg WnJ4Epqdd6TElGFLYloVubpb9k7aeCS0Nj/CfDN5gfau17iEYGPyi20QQqa8Glk/ fhJb5vXtvglJrhqWgoS6QzweZg7CbnkKWOhxoKmeRGL/7EIv6acsnX9pHxAj2ahP gWgcfIBAWTJKj8FV022rYU5jYjatmwudR2UtbqLiwsDHssnd41Edaec0flvRyUOp RM40MmsB2D6V8KVPFZnDPKiIyl2WqbTjYQ/XhDmg0AqZ8eg+YVs2RY0rHsEEOMdx M6dbRN2Ac4ubxPRubSnF4KJfGtjzJmuGjF0oK9CwxyW2ilPIn3fGOjo39xdHbrWD IqJaqcuy6Qkj9cmIrNCQCzA6331l4rbLkumZhyYK65ERco8pbNfshakczi8DGewB 3vFj/lBm =1608 -----END PGP SIGNATURE----- --je0mZywpqEo4t1RU--