Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 300ACC433EF for ; Thu, 21 Apr 2022 23:56:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9771B83CF3; Fri, 22 Apr 2022 01:56:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hMtdbnxS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7299283D30; Fri, 22 Apr 2022 01:56:50 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AF92983C70 for ; Fri, 22 Apr 2022 01:56:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id bz24so4473234qtb.2 for ; Thu, 21 Apr 2022 16:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AqKbSOZAWFW3u0JuYhP4RtPA/dGao6fYwk4WIY5MP2I=; b=hMtdbnxSET2zyk20Y1z/OUdeabKHNpekt7ItMCvdjogmivD31q7+fmEiFTBfIzj1P3 hqveopyBoYWneKcLG9aYVQs1qnm9Cfumn08HnNs+UtVc3CbVG2WrXth9XoV8kxMZ1piN e/3TKnsFgj5XBv6tndECGX2KZYTIv5LcDMer4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AqKbSOZAWFW3u0JuYhP4RtPA/dGao6fYwk4WIY5MP2I=; b=T3rXlJW47UsPWbrLUGK8oGWuZ9M4YfTHaGHk4ScBkNFRwezUZ25kWlQlhGu8GYpsP1 KBZWaJBYoXwvHkxIwyy3004WI7RD6YtU3OV3et4z2n306CW9iCM5/ZpQWrO+N92fWKrv /HpCuwSAXE3zY68deRZFb4nmsirwSm4XRUBOLRWm+Ry7V+yMtOXjPAl7iBnm5zU4UYzv CSfzBWhFEGG28aS9m5e6u+a1JHEAIx2DyGzYbcLn97X2PNxVYy56PYR9G+VPVH2aDa0d kj+h0yiW0/5bBXkmUdAKYe7eKi23AcoqXD1LyIkUvu4aUZs5IkCE85VUkdYnqq9/TG/c EwXQ== X-Gm-Message-State: AOAM5307oc+xNF2fQGMgyDzzaZWlzimeJzUCdDL1RhVILWW/FDFvHF/m SHqNRf/KgEjfdyTvhXU6nKSuvw== X-Google-Smtp-Source: ABdhPJzuEJc3oxN1ZopI2U3SS6v2FCzU+PfQZSq5IQkjdwe6LFAuviDLAh3PKsKkL7xOmoN/QIX5Zw== X-Received: by 2002:ac8:13cc:0:b0:2f1:eab7:865e with SMTP id i12-20020ac813cc000000b002f1eab7865emr1392633qtj.57.1650585406493; Thu, 21 Apr 2022 16:56:46 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id a190-20020a3766c7000000b0069e770524adsm204161qkc.114.2022.04.21.16.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 16:56:45 -0700 (PDT) Date: Thu, 21 Apr 2022 19:56:43 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Priyanka Jain , Simon Glass , Rick Chen , Andre Przywara , Michal Simek , Marek =?iso-8859-1?Q?Beh=FAn?= , Sinan Akman , u-boot@lists.denx.de Subject: Re: [PATCH v2] SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SPL_FRAMEWORK by default Message-ID: <20220421235643.GM3045430@bill-the-cat> References: <20220405092822.20547-1-pali@kernel.org> <20220408082805.12561-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jHwcxWEthkc1rt9P" Content-Disposition: inline In-Reply-To: <20220408082805.12561-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --jHwcxWEthkc1rt9P Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 08, 2022 at 10:28:05AM +0200, Pali Roh=E1r wrote: > On P2020 board is SPL malloc simple always failing with error and loops: >=20 > SD boot... > alloc space exhausted > Bad trap at PC: f8f8b5f0, SR: 21200, vector=3Dd00 > NIP: 00000000 XER: 00000000 LR: 00000000 REGS: f8f8b5f0 TRAP: 20000000 = DAR: 00000000 > MSR: 00021200 EE: 0 PR: 0 FP: 0 ME: 1 IR/DR: 00 >=20 > GPR00: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 0= 0000000 > GPR08: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 0= 0000000 > GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 0= 0000000 > GPR24: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 0= 0000000 > Call backtrace: > Exception in kernel pc f8f8b5f0 signal 0 >=20 > Inspection showed that gd->malloc_limit is zero. And it is because > generally SPL_FRAMEWORK initialize SPL's gd->malloc_limit. But when > SPL_FRAMEWORK is not enabled then in most cases nobody initialize > gd->malloc_limit and so SPL malloc simple does not work. >=20 > So disable SPL_SYS_MALLOC_SIMPLE by default when SPL_FRAMEWORK is not > enabled. SPL_SYS_MALLOC_SIMPLE can be disabled only by setting > SPL_SYS_MALLOC_F_LEN to zero. So do it. >=20 > This change fixes SPL error "alloc space exhausted" on P2020 board. >=20 > Signed-off-by: Pali Roh=E1r Applied to u-boot/master, thanks! --=20 Tom --jHwcxWEthkc1rt9P Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJh7zgACgkQFHw5/5Y0 tywSSgwAmIhUepvck9GdzP2fDs3JU87CJlfZCmXXmOliy7Z0xqGXjfY/AuJn4S6p 6WZSkhvyLCrHg++FiOmB2xb+GPpYbyN/JSDHka716QDN7snP7kM3Z/XPL7KZoYGp rVEObZCQeeY4aKkEHh9+2bPJl6Nyt+Z758jHmsE1evqr7FoPd5Al6aValvkZSezj Z4sfzJHuLx2YYdm1TXgX0RKVhx+PhXr736OsThNhEpYbF9pD6wPBrYdA9jcf5zIr MsKfmDiS+VRKnXUHrjLeu1VPvf1Xt+F1yWj+K/tVZVUfZQFEB1dylXeNB3uFW0n6 JrlHVD9UBc7eKrStVrm8OILABitIj0BgJEPS9RVsxCmLe9UIXEK3uAhTFUvNXFIZ GTgXQe9tw252dnNnG1kpqWjNhWN0RYpCGVRFiNdrVSqfnnK9+OZnwPzqVS4WID6a VcKL2Z6u8DjE6gEa87sDZdlzv2zq7SMe2xoCQjkLOHIqX5A2wRKVtgfqmr7cf0/d bfslAt7r =8RYl -----END PGP SIGNATURE----- --jHwcxWEthkc1rt9P--