Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D76CC433F5 for ; Sat, 23 Apr 2022 12:08:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 08A5F83CDF; Sat, 23 Apr 2022 14:08:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jMLn+YZl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4C08881A02; Sat, 23 Apr 2022 14:08:54 +0200 (CEST) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A1FA781A02 for ; Sat, 23 Apr 2022 14:08:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf35.google.com with SMTP id k12so181547qvc.4 for ; Sat, 23 Apr 2022 05:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2Dm1+hKyvPEBmX97b8yzvZrToD66gIahprctSTOTw64=; b=jMLn+YZl4WTw280EclvJD25vGsvuwcbz7Z0k9F1elMldYbUkKke3kPaAC4Lg555jcV 0VpOEhzu6gItguptm/j9EprNp54/m7jXzR3xj6MHT6XulHkS7MJwtz2t0Fbz3qAbuSI5 2mSkXLBKj+PWELZZ6CRM1EyyvkDtFz8Iy2lng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2Dm1+hKyvPEBmX97b8yzvZrToD66gIahprctSTOTw64=; b=KH7kYUWL1R+TobeDUfsoeCpPoSbgh98YY0zLpvO2FCz1KWX2OEjXe5kEiG9Yfj7IM4 ExYHudANq3gSC9QH1t7YXLteQ7umboKUWz0Gs7Am66VlcvJ0mibbzHidEIN+ljyVa0in MBRS7GAtvPtm8Chq6ZggMltZlizJpB3gMOViwg5IGmpGmvNhy7YP1fM0Tsgb4AH97RhP KBtTdV4ipYJcsMjxlf1UNA36fislXQfouSSWYVQO91youg3BBMwshOlTbILHkQJzNinG T1J3pUnzJH2w2EsAdfc1x0usBj2FjULn5b9DDsRdlfvI7uZrCTlLup+jATKrqg2DIhHH +1yQ== X-Gm-Message-State: AOAM530aKek6/m3fOCwL+EJ06o5I+Spo6wcZUzq1ZMfj3Uxp0nS/a42V CIkLePKjvCy68EwTpJyE4np2eQ== X-Google-Smtp-Source: ABdhPJyGJdxuzRnrLtCEC0m5O00NZHkXENL/n7FuEE+71bApBxYDk0yzHOM4CrtK1TTuB5mfAYJY7A== X-Received: by 2002:ad4:5c62:0:b0:444:560e:32ae with SMTP id i2-20020ad45c62000000b00444560e32aemr6541846qvh.76.1650715730422; Sat, 23 Apr 2022 05:08:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id 17-20020a370911000000b0069f0e781d96sm2276843qkj.90.2022.04.23.05.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 05:08:49 -0700 (PDT) Date: Sat, 23 Apr 2022 08:08:46 -0400 From: Tom Rini To: Peter Hoyes Cc: u-boot@lists.denx.de, sjg@chromium.org, andre.przywara@arm.com, diego.sueiro@arm.com Subject: Re: [PATCH] fdt: Add -q option to fdt addr for distro_bootcmd Message-ID: <20220423120846.GH3045430@bill-the-cat> References: <20220331105322.3495402-1-peter.hoyes@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QYbTd+PSDu6P6/0L" Content-Disposition: inline In-Reply-To: <20220331105322.3495402-1-peter.hoyes@arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --QYbTd+PSDu6P6/0L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 31, 2022 at 11:53:22AM +0100, Peter Hoyes wrote: > From: Peter Hoyes >=20 > distro_bootcmd uses this construct a few times to test $fdt_addr_r, > and fall back on $fdtcontroladdr if not set/invalid: >=20 > if fdt addr ${fdt_addr_r}; then > ... > else > ... > fi >=20 > If the `fdt addr` test fails, it prints the following message on the > console, suggesting there is an error when there is not: >=20 > libfdt fdt_check_header(): FDT_ERR_BADMAGIC >=20 > To remove this potentially confusing error message, this patch adds -q > as a 'quiet' option for fdt addr, and uses this flag in > config_distro_bootcmd.h >=20 > Signed-off-by: Peter Hoyes Applied to u-boot/master, thanks! --=20 Tom --QYbTd+PSDu6P6/0L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJj7EYACgkQFHw5/5Y0 tyybhwv+KxDa7fVRB2PxtC+Vhxe6Q+cl3VIaE4gPq9Anv1z/4uc6U8wyjBL/GRHB kg5wHxQMftqPpZQuAA8P14izddjzH/BrjiXwCsmqiar+DZE0XebHQmZ/2ZQA8PV2 hNd2RIplioWfhbCJ7sU5b49WE/Px5MbHW1/1+dbyljr2pXwhLy4xZFtvq5S0kFkJ bTA6ODTCQSGruavbFJCqHk5qhX4qxgkcjAqfWA3E7ZiiEa2R29tEYJnEjqEH9VkZ +Do8iNM4fuCu7gr6hAQc4VmhqjsiJj5+UJ5Zq/R4PvhpKOqH8khO8i/ODaB3nbbJ SqETy0yVIxKrq74R6asvSfnTJgHuUyBArp50C83DL2u3IGpt+S1oHX3yqKRAY4Ye YA1mw3L/0nmCv/1MpgyuzLIPi0Kr6VejmJA1tElGJ6eeHff2jD4UCUe8TwqSO9Ep rblUnxyVdC8v3BZcNglPWVlRqXmP3sR+t8yZNScynJw6ZX/otBsv9oom7MdIXUCK 8p0ek2CT =C6pl -----END PGP SIGNATURE----- --QYbTd+PSDu6P6/0L--