From: Pascal Fabreges <pascal.fabreges@nokia.com>
To: linux-mtd@lists.infradead.org
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
 Miquel Raynal <miquel.raynal@bootlin.com>,
 Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,
 wladislav.wiebe@nokia.com, alexander.sverdlin@nokia.com,
 agathe.porte@nokia.com, matthias.robert@nokia.com
Subject: [PATCH] spi-nor: fix spi_nor_probe
Date: Mon, 25 Apr 2022 13:58:05 +0000
Message-Id: <20220425135805.32-1-pascal.fabreges@nokia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CAKCaE6MJ1ZWk6maqAFLeYf78t4aiiTLL3BEUzCK9esX8jM2qEGvXuSMRPLN?=
 =?us-ascii?Q?San9iJnIWWoEi+Ptmn9tiUh/LPu+u0pF4FJ9amV7tBn7MisDOFEW+4cYSFVZ?=
 =?us-ascii?Q?QCRvy0q1n19wJcaqjsMnj4B9+LUxAkWEC65CL0212ChFm76leHpQUD9x52tG?=
 =?us-ascii?Q?IEvkqzMLNnukNEGEkyAFnCwk3mHGbfoJWsabKlFYEpsyDcnzn6/z/4xApKKS?=
 =?us-ascii?Q?YB1hKy1JPvJo7eRLwBF+c8YEilmkJVgDJgtx1tRQ2gvwTaSlXgzTprVDYyy2?=
 =?us-ascii?Q?zs68Hdyi636VqYOjnbE94AvXKNn+cF7PNT5ftp0abrB7lfoGOwpEHoreSPj1?=
 =?us-ascii?Q?S5IwM6IKQk6YXG/PDcm7hzDK+G1Wxv3jQoZrY/NIgSClAJ9DOmAjOC1AMs4Z?=
 =?us-ascii?Q?gGO79qsNcEq+KSZs9Hir2vplq/qJfv0ghWE8hH3sPTsghpsHuH/4L3ulDmZN?=
 =?us-ascii?Q?YFy6uuDkPqGlizFY0PcOd/KiMqzE6dKHjiHM2KUPvQsxHA2QaC94qxNJSU7G?=
 =?us-ascii?Q?Qz4vQnPe0U75jlP1VlMTMaqdmljjnTZuMGsh8J4ZbPaJNnVjhMz8stRlphUl?=
 =?us-ascii?Q?Q4Afcfeg82dDetnVMm6yZdEBQmPnMfoWe8DhaPAw9rb05XNA6IC4AMzhNE1m?=
 =?us-ascii?Q?SPNmliBysXhxLxo84cv0kjU/3bOjWJk7WE4AxNkhkcFtMC37ObzWd1ZOaq6I?=
 =?us-ascii?Q?851Pk7cxUnKBjtBpk5Q8EmA7cZi0JN1ihm20aYgdzayAUaFgqgYUhcJ561dD?=
 =?us-ascii?Q?+WihKmx+hiK/WkqmSXrXY0kV80lOuplSXHB896cZM4mDwaJ1rujCf/OEnuHH?=
 =?us-ascii?Q?iAxLckuylho6HYUvr/QulEgFC+sn+dXM36xKJdNJamdy5eDbi6OCMymz58/l?=
 =?us-ascii?Q?E5h4XDFQ8rKsdTv1VohnO8O8GjQ7YI1KCuyqBQvAfBd8OQwW/HW2eUMMdGBn?=
 =?us-ascii?Q?f6aeN834tJJaZMRZbrhlSnBelEGMwXvK5iAnE4KRnpDl0mA7V2aNFKN28ptq?=
 =?us-ascii?Q?hxjGqyDRkM9zIHsQagJF0n45U7kSvtSsfvMyYnojWEAoH3aLI1Sa2SwSfo5D?=
 =?us-ascii?Q?vWP5jI2ogdRdptZqy2eIUoL4/OAamE7kE+38EzUefvCO23U4dyiN/zjFXdqP?=
 =?us-ascii?Q?dUf88fXLxmkviLQ8UiWbGYfTovuz7V7Ho234gKoB6Vpe2j5c81YJR3Y5NA8J?=
 =?us-ascii?Q?P8J4UMzG84DH5bGhsTDmHR+3jMugZTj0DAAkt8RmI9SdHgW1+onKmBI8djLO?=
 =?us-ascii?Q?+MnJENIL61XCS8YJWiuI5PXzvSqo7XWZXR+H9LC9NvV59jUDOQhIYhaVjttS?=
 =?us-ascii?Q?IsY0E9MFRH1w/kW0eudRODOArSo0aibkQKS2J89asM506sWXqmcIJqzlcIz3?=
 =?us-ascii?Q?PwDnsmyvd3MltN2Alnk6v88XVv7BjHUKu+mb725Sty2hyMuTMLOXbOCn+v4t?=
 =?us-ascii?Q?lORteiZn9SzXXdsBgMvCX5+rC4SvMwPXCysuke8YgHnhJcTEbh3q/rbwjKVI?=
 =?us-ascii?Q?n47zw+PrYN9Do50LKiFjWCEjKL9/VS4VuAuUFCwAUDJ9KDjsSmM/QCR3OIT8?=
 =?us-ascii?Q?YdZGDIz4kX2kFifoy5BYmkSSPy+/zPUgCFL+EDqNKfpHwTbTAhZo/wOMIkob?=
 =?us-ascii?Q?ccGF2sglmyjbT221eHORDwXxEJRlWAVvRJmAgYVK1jfWaAFGvAsOyLAJkDh9?=
 =?us-ascii?Q?SgFTdKSv2XFdJMKxG5HVS8ctwiEt69jH1ep6UQkIxDPg/osL3L3sVLm9lWoJ?=
 =?us-ascii?Q?XITGP/Luec06kqjfwNeBRN6DagpzFec=3D?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d178081-ec54-4bba-7e0c-08da26c3f3d7
X-MS-Exchange-CrossTenant-AuthSource: PAXPR07MB7727.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 14:00:27.8603 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2gIhuF/1j7A+127RYQLyuJRWgyCHu5tXBWQTDZ7703OcwZwCkvWZPIc6GqiMr/ntUNDPHZVC2DUrPi0ahdSLIak154DUbL5F09MDJkwTXC4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB5379
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20220425_071612_046481_5B529147 
X-CRM114-Status: UNSURE (   9.62  )
X-CRM114-Notice: Please train this message.
X-BeenThere: linux-mtd@lists.infradead.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org>
Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org

In rare cases, 7 on 5000 power off/on, the spi-nor driver is probed
too soon.
The controller is not in "running" mode.

The spi-nor driver take the hand before the end of the
spi_start_queue procedure which set the running mode to true after
the spi_init_queue (Initialize and start queue).

kernel: spi_master spi0: spi_init_queue: ctlr->running = false
kernel: device: 'spi0.1': device_add
kernel: bus: 'spi': add device spi0.1
kernel: bus: 'spi': driver_probe_device: matched device spi0.1 with driver spi-nor
kernel: bus: 'spi': really_probe: probing driver spi-nor with device spi0.1
kernel: spi-nor spi0.1: no pinctrl handle
kernel: spi-nor spi0.1: spi_nor_probe: Caller name: really_probe+0x2b3/0x3e0
kernel: spi-nor spi0.1: spi_nor_probe: Call spi_nor_scan
kernel: spi_master spi0: spi_mem_exec_op: Caller name: spi_nor_read_id+0x89/0x190
kernel: spi-nor spi0.1: spi_sync: Caller name: spi_mem_exec_op+0x2f5/0x460
kernel: spi-nor spi0.1: __spi_sync:  call __spi_queued_transfer
kernel: spi-nor spi0.1: __spi_queued_transfer: return -ESHUTDOWN
kernel: spi-nor spi0.1: error -108 reading JEDEC ID  00 00 00 00 00 00
kernel: spi-nor: probe of spi0.1 failed with error -108

Signed-off-by: Pascal Fabreges <pascal.fabreges@nokia.com>
---
 drivers/mtd/spi-nor/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index e6b8b19a68ee..dd82f42c29db 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -3618,6 +3618,9 @@ static int spi_nor_probe(struct spi_mem *spimem)
 	char *flash_name;
 	int ret;
 
+	if (!spi->controller->running)
+		return -EPROBE_DEFER;
+
 	nor = devm_kzalloc(&spi->dev, sizeof(*nor), GFP_KERNEL);
 	if (!nor)
 		return -ENOMEM;
-- 
2.32.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/