Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C00F7C433EF for ; Mon, 25 Apr 2022 14:32:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4DAD2839B7; Mon, 25 Apr 2022 16:32:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VBv66/Cl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6DBE283C79; Mon, 25 Apr 2022 16:32:16 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 453DD83953 for ; Mon, 25 Apr 2022 16:31:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id bb21so10391423qtb.3 for ; Mon, 25 Apr 2022 07:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QG2FQFqjnYooEUv13kxjL0k300aP7aD+Tad+9qfLtRE=; b=VBv66/Cl44fUIwoFuYz4ZQHCuliBeWG1F6Ag5D6jt4UjGIv6+z7YJv/TqUJ3q7QjiG Nh79oGR9d5u8vQlLIAKwLQyBaJwGjZ5VkBtagxmBeJeKuJQjps0nNXWD1xTBBwgKsI1V O4w+s9/cu/sN6CUr3yqMEeqh1S28E08BkeB4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QG2FQFqjnYooEUv13kxjL0k300aP7aD+Tad+9qfLtRE=; b=qv3jryf4bHIa5y3atP2bVYGnsdp4NLAo/BHOZnveLIPiOaDCjulRu2W+PxyP6pvsbp nf4s9ujTIZgOa+dwG+1AIk3pTad6Fa2Hwmu9ZsLXi3ulhMsB1q4j1vQ/MJCbJqtvad56 2A768Uss0qB3QF9IHc6XMQUVuVr2Aej8/PjYUq4B5sQIjgG0qA67jQu5lgRPaFi/Q10P QLDuUoyAAwGvtgkJvXNaZbficmKZ0PIW3PCR4Gz8ay/8m/kaBitAdJ2mcrnfjmbTCHVO TvmddOYAtHVpi5BUlbu/8h7N/6PCgxoqVsN0rFASk/oIpn8FsvzFz+OHXTKL3k/MdDyi 26ng== X-Gm-Message-State: AOAM532zJ4TJYt1Xcc8G6vXZVB0jGodAKHlK7MuL23TmNUhE1tqo+Bs7 S6DYXep8z+YrdP+VwkTfW91JqQ== X-Google-Smtp-Source: ABdhPJxNLWPYBla4V4SpmKhxrMXRgwJiEpen4jfDG3RFAcCpEp3Bn2sgFjyJeEWkolny/Iualqi1nw== X-Received: by 2002:ac8:65c5:0:b0:2f1:e813:6078 with SMTP id t5-20020ac865c5000000b002f1e8136078mr12138269qto.187.1650897117995; Mon, 25 Apr 2022 07:31:57 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id d17-20020ac85d91000000b002f365edfd21sm2623364qtx.83.2022.04.25.07.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 07:31:57 -0700 (PDT) Date: Mon, 25 Apr 2022 10:31:55 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Patrice Chotard , Patrick Delaunay , Sean Anderson , Simon Glass , Steven Lawrance Subject: Re: [PATCH 2/3] led: Mark device instance with DM_FLAG_PROBE_AFTER_BIND Message-ID: <20220425143155.GA303559@bill-the-cat> References: <20220422131555.123598-1-marex@denx.de> <20220422131555.123598-2-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <20220422131555.123598-2-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2022 at 03:15:54PM +0200, Marek Vasut wrote: > Calling device_probe() from uclass .post_bind() callback has all kinds > of odd side-effects, e.g. device instances not being available just yet. > Make use of the DM_FLAG_PROBE_AFTER_BIND instead, mark device instances > which need to be probe()d in order to configure the LED default state > with this flag and let the DM core do the device_probe() at the right > time instead. >=20 > Fixes: 72675b063b6 ("led: Configure LED default-state on boot") > Signed-off-by: Marek Vasut > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Sean Anderson > Cc: Simon Glass > Cc: Steven Lawrance > Reviewed-by: Patrice Chotard > Tested-by: Patrice Chotard > --- > drivers/led/led-uclass.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) This breaks all of the sandbox tests, which perhaps need another update for what you've changed here? I already had to tweak them once in=20 72675b063b6e ("led: Configure LED default-state on boot"). But my perhaps incorrect read then was that the dts / test weren't quite right to start with. Perhaps that's still the case however? --=20 Tom --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJmsNcACgkQFHw5/5Y0 tyxi6Av/ed57JoCcVhquw2zk25vqeP6dw6DLXwB3h9CnW+8gkDlbenf3xoWfTIFc gwqgSz40hBqJdAhxLtVGHk5SLmfj1mYFFbxrH5eLMBMrOPAa22YQ7MLBmw1bh1Kx N6sHV48519aV15ToQh9ERNW80dUtmHNQ3HPUs81uKXZe7X1QTifZrgBylL/BN95d vwqeEm2Cr+tPZSn4EGtlRFwkWI7tLcrwe/2WeWG/1sn+/WB5BAudAWAib1DrmO/S OAq3Ct9wt6yJdJ9CYjpDA5NO66YUSGICKQ3JLUclzOVuxDJNSsk6vrxh/1NCQSbx BcZUkQF3gT6ahSuiLd3N1s080iE1AU9+bPk+t86L5wp1h7VO8mCA0maLR6SJcMaO 5RHMfYd5jOVzHETqLRJatKtyQxIGSy7WHXZd7oulcW4YSvIqpDF+tzT9DyJ5IWiO r5pXHNjRbSj/yDYbJOo29xo0iqou5njG4nsg07XXkmlEIMvfKb+ViN3wFUZtVD25 I0mPrjX7 =0S4r -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--