Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64496C433F5 for ; Tue, 26 Apr 2022 07:28:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6FF37807DF; Tue, 26 Apr 2022 09:28:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=kococonnector.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=KoCoConnector.onmicrosoft.com header.i=@KoCoConnector.onmicrosoft.com header.b="N5FzKP7s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD2DA8399B; Tue, 26 Apr 2022 09:28:15 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0613.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::613]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7D180807DF for ; Tue, 26 Apr 2022 09:28:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kococonnector.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=oliver.graute@kococonnector.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOracA8oYxX27CxPT7zx3sjwBSfjnBLq9RZasApV4bY1u3xaw+25qF48yVYFWNATSF04MQ/czo9uNwAmptlBmH8teZhbZ87hyb19AE0Fk57G/n5JdcVG1dO9dpCaCzJId13h2Kp2m67d8elkbThoF3AhutMfYS7y+1aYtHK6uWSOmoGdjTWTeYC8cEKPhLNBNKb8F5fGbWpgLGQ/3R0UYxNVUbe4DpH3eOr6Bq8HVa7kB5QiKA4WYPwtB0SDV/EmsNZ2RQtbtTkGXRtvnFkErQ2kWkyRcZeM/IP3T5cd+Hw081UxFMWIlrNKKmrebQdLbYDav18Lsophs3tdbyXlhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFG5MrgeQAjFMMS6Ed5LaSQcXXJDmt4xMqebqojxpsA=; b=f/MX9ssn4V0de0nHfOZlxtpeL5wWC/tD3DM5GMEuCCSfL9fUAEZEm4gA7cxFOHAyqlsnk734rlDWF+1bUyKYGNUxQjeEz+qt54e3/pYhaATBvkXN0Rm+PDLLfr0yzP3dv9t2K6sxqJL2qD/KgZhhaI33wO2GlZHRDoMGa0dV24M6sTqrNOJjruEsZZ0KTqYcs/A9q/tDA6nMwjECEEcE+zkvDL29GCtAwXFgigjLkTSt08DELwwJLcl445eBPWReCn2BsbZqfc0xAcajNrbwY+0gjQpIX0xo99l2rdqbpaAJAJacg59eMS1cbEQ02C5QAOfVofZNW7wR9idIDp3pRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kococonnector.com; dmarc=pass action=none header.from=kococonnector.com; dkim=pass header.d=kococonnector.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=KoCoConnector.onmicrosoft.com; s=selector2-KoCoConnector-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PFG5MrgeQAjFMMS6Ed5LaSQcXXJDmt4xMqebqojxpsA=; b=N5FzKP7s1HVecL9/mR+UiLBvx/53GshUctk20bg90xx8JlNiSwWT5+QNOdJgAeA8hazEw/UjfRiOSqPcgN5mz5jeH4SCcJh7T/29i1VQlVKYIUDZoyS5G5I99EyB3G4F8l+8BCu/icB9VpZY20PmWcLAoecg2WJE/eY149JkF6A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kococonnector.com; Received: from AM9PR09MB4884.eurprd09.prod.outlook.com (2603:10a6:20b:281::9) by PR3PR09MB5441.eurprd09.prod.outlook.com (2603:10a6:102:17c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr 2022 07:28:10 +0000 Received: from AM9PR09MB4884.eurprd09.prod.outlook.com ([fe80::581b:1a8b:c5c3:294]) by AM9PR09MB4884.eurprd09.prod.outlook.com ([fe80::581b:1a8b:c5c3:294%4]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022 07:28:10 +0000 From: Oliver Graute To: sjg@chromium.org Cc: hs@denx.de, oliver.graute@kococonnector.com, michael@walle.cc, u-boot@lists.denx.de Subject: [PATCH v1] rtc: rv8803: fix off-by-one in month counting Date: Tue, 26 Apr 2022 09:26:12 +0200 Message-Id: <20220426072612.13223-1-oliver.graute@kococonnector.com> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-ClientProxiedBy: AM0PR01CA0126.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::31) To AM9PR09MB4884.eurprd09.prod.outlook.com (2603:10a6:20b:281::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65d59c2d-a923-49b2-5717-08da275650e5 X-MS-TrafficTypeDiagnostic: PR3PR09MB5441:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jnRpyG9Va8ThyWEiCRiRvk46/xqmtU2dABECHisbMXp1FwUshEVkZ8eBQJvyNo94QZNNuxCf5iFEwQQgXsrRH7WuyOCf7hrMlHRhCP1dc2eq/iApg4wmV4Ln2z0584Zq5YFfmq3fg0tAAJRaaXRql1Ezl09rAacnAvQ6y1H3yK86iFJ32PvAQ0VC2xPlCrEkIY5MZqpJr2uRCq1LMsKo7ezlfblbb2LqkjMvPmsW7fvUXcRl1DlkyYNo7KBr7kd+4duxMYqNHpwk8fXChnYGm1NjzEngScrelIPZ+ZxEYkqVVqGgkhyIrAo2ANNWiaIMpja3qzzF6WTgKqdhmfDSz31mwpBW52lmVaXLdTlS6TqkXUALSKJ2c35NsdiJW1UjCKwBC2G3QRvLhnxFBhtjBfoxGkfe9h+xe+Ogk0YL7cmcjuuBvNzdCas5PJ3xXJWXy5l2B7J0dd6Y3F74gmfGs859+BPf0IHnSbCYPDeRayCiKwIGVd/+HekFNf5hE6J63eYaBwN41Z9wSlf6VZZfSA5wxro9bxn+ue5OkdJRNAnEVyAitJSI3G4DYlNBRjF5h7E2cF5WnJynTaqJGKRu5V5yJA94RJellD/dXWdV9XOCAWPbJBdOYPCp8z26d6IPMXpRsNRqoz53s4n02SFRn9B8iCKa1QFbGOPGTkb5Eir+Q+uWYcRk9NZ8OPdNTKfdTh7jl2AAuq1+rnipV7OCTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR09MB4884.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(39840400004)(366004)(376002)(136003)(396003)(346002)(83380400001)(26005)(508600001)(66476007)(6506007)(38350700002)(6916009)(6512007)(8676002)(86362001)(4326008)(316002)(66946007)(66556008)(52116002)(38100700002)(5660300002)(6486002)(44832011)(1076003)(36756003)(2906002)(2616005)(8936002)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IlNEi8TyQ1A+6hJAmP7frw15JWWrp+3bca+gHEk7V0dfdZXEErN1w8FHnLNl?= =?us-ascii?Q?lUN90WpoVxqp3BeTUp8wkYcXd0s93OVvzeovQt7O03KWbq+LkwZ7H3t4ihJN?= =?us-ascii?Q?RVJ9KKZ1TBcj07D8zxznDwpUrhYxE98ywfjc5fw0NvP0Fv9UZRurF6dFBC54?= =?us-ascii?Q?DEG68UIr8U4KlplOywuSkpsoF7rCtDbXD2t20CKapqGvG+pF/Sa81tMHddo+?= =?us-ascii?Q?7Sc27//YIuq1iKyn5Y6aHgeQbT/xFuFdmOf9tRAxbdMa7t4hFDi8LS1pnVEy?= =?us-ascii?Q?xps8o3F6xLj+IvOXbWcmJ5qpxNW3O17cexisuOoGSB2NSw9iSnqWhVYsEqBq?= =?us-ascii?Q?z8rOggsKDy52T9sVaLIWUn7JIV5Vi0ajUOAwiXizU7Uf+l2m3hwb6q7qeAYp?= =?us-ascii?Q?Ez9KyZK/hE5FiBkEckNf2OJTaMGR81amhPI4Gp+Mr36mMBrafppUhtheFTI5?= =?us-ascii?Q?nS2kwEaWYO61GdTuwWCjd24jJmrk0+VnUvDLtVdl2KwDrqm4TdHcoay9LNDu?= =?us-ascii?Q?42uF/RKsgwXQsjVtU6RYqD/sixmgKzWLBxSsNZtOQ+pOhhWddYhKYoL1r3DZ?= =?us-ascii?Q?GyViDVqYPOIijKubvPDfmbpVwCEnQdEPFioFvTVBW7Jn8hMIAq7XWbYuGBU2?= =?us-ascii?Q?VMbEk4UkpfFKVF3T4lAub47aua0mbEdS+JfDgtJk/Kx8qe1kdEzqtTreQinV?= =?us-ascii?Q?IncRyj3R5HluxyO6/rtYE8Hu6IV+TMlGWqfXX0Cop0E5u82BcQg8B9/iwMKM?= =?us-ascii?Q?AvOzQrmjvOuEkMCoLdnLZv8y8etb+MnJ+JumuuJF8w1Oz6tTI7aq0LQBPKik?= =?us-ascii?Q?6ZtIMm05cm6Wc5/vjvnBAsUrol+UrOLb6TY+RoKth87JizzJ2OislSxkkgdm?= =?us-ascii?Q?dMUf9L/QSGj+l1EqQsWMLnrmKwVTj6piDIno2pG1vQdwaVyPt7QtnOfSHIQJ?= =?us-ascii?Q?1o8hltq+R2di0CqtpONF+TlSnOZKhxqKO+WCF2grGShb5W7qbDE8eHrmET/v?= =?us-ascii?Q?0yXA6cHy8IBA0gBHQ5g05U+tHjvCA+EhPLi3j7vLU/dhIE0pbg5yZfZ3H/FU?= =?us-ascii?Q?ktAbckFOC5+KtBpnamQA41sh+US/tZvo8XBOxV2cjDqJQf7C6N1FJYYfh/cw?= =?us-ascii?Q?iowu5FsHYy5kkxNid8lQ84rVHSlx2m8DmnMIwI+vKQSontFusOG2Xtv7Gd7E?= =?us-ascii?Q?HaUaRl+P7KXuWC9TxM0PXqmW8s2YvR2AvcqPYiU3DcEOu/Njyhs/H8322TZ/?= =?us-ascii?Q?YLF46bOhBN/w1/tCdZv54NMBvgbBVUhlcjKanep2idIMcb6QtPPG6VNSLczL?= =?us-ascii?Q?sRLASij/svz/BFiAu4UXELCv/ghy0Gzg4rzSuSdMNBLS0z2pja7C3sCcO9W3?= =?us-ascii?Q?Jr7wHvcSMZQs/ZNnLSbif9D25XsVAbTykqC7nWyjPKJ114QXYW42W1IXaQHT?= =?us-ascii?Q?e567EgkgU+DgwbaKJp9SlNnrkuqQ6DIcFP+GvUinvWL5XreQX8TlHd1XnVnx?= =?us-ascii?Q?BLSy/7HFyyprSZCrQ47Mp8nq56Mcvg4+ZkXKt6JY4oFhiUVB6Ya/rA15yJBq?= =?us-ascii?Q?N+9/H5A05GUVR20B/Q2JsoYIruDREGqvJvsSOH6vaKeHoKba07Is34AC9EXI?= =?us-ascii?Q?ZmiSBMzhC66YBVhdro7wyIqX83i/n4ODM0O6dE6yc/Gsvakhc9zc7g3eBmCu?= =?us-ascii?Q?lf9MHqOfKxLlngKvS4mr11H7AIc3OiVCzq3a2riT3g0em9B7wz6Hd8qFT3zc?= =?us-ascii?Q?mWJ4lNhYhJXeCH9u6Pi3UVHq6jt3UINwu8w4LFkkFmarSHW/jdbZ?= X-OriginatorOrg: kococonnector.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65d59c2d-a923-49b2-5717-08da275650e5 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4884.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 07:28:10.6267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 59845429-0644-4099-bd7e-17fba65a2f2b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1HGgXFSSJaHqRaKhrog+X39aOMu+vtT1siMZFNA3feyVdI9bGWVVIxI+wmUepXOg31eOb1pP+VLHXbaKqxZNojg1VqxzJTgCjD++9tvGTE8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR09MB5441 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean tm_mon has a range from 0..11, but the RTC expects 1..12. So we adapt the month accordingly. This was determined when comparing the driver with the corresponding linux kernel driver. Signed-off-by: Oliver Graute --- drivers/rtc/rv8803.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rv8803.c b/drivers/rtc/rv8803.c index 66b37443de..3e3c50a872 100644 --- a/drivers/rtc/rv8803.c +++ b/drivers/rtc/rv8803.c @@ -49,7 +49,7 @@ static int rv8803_rtc_set(struct udevice *dev, const struct rtc_time *tm) printf("WARNING: year should be between 2000 and 2099!\n"); buf[RTC_YR_REG_ADDR] = bin2bcd(tm->tm_year % 100); - buf[RTC_MON_REG_ADDR] = bin2bcd(tm->tm_mon); + buf[RTC_MON_REG_ADDR] = bin2bcd(tm->tm_mon + 1); buf[RTC_DAY_REG_ADDR] = 1 << (tm->tm_wday & 0x7); buf[RTC_DATE_REG_ADDR] = bin2bcd(tm->tm_mday); buf[RTC_HR_REG_ADDR] = bin2bcd(tm->tm_hour); @@ -90,7 +90,7 @@ static int rv8803_rtc_get(struct udevice *dev, struct rtc_time *tm) tm->tm_min = bcd2bin(buf[RTC_MIN_REG_ADDR] & 0x7F); tm->tm_hour = bcd2bin(buf[RTC_HR_REG_ADDR] & 0x3F); tm->tm_mday = bcd2bin(buf[RTC_DATE_REG_ADDR] & 0x3F); - tm->tm_mon = bcd2bin(buf[RTC_MON_REG_ADDR] & 0x1F); + tm->tm_mon = bcd2bin(buf[RTC_MON_REG_ADDR] & 0x1F) - 1; tm->tm_year = bcd2bin(buf[RTC_YR_REG_ADDR]) + 2000; tm->tm_wday = fls(buf[RTC_DAY_REG_ADDR] & 0x7F) - 1; tm->tm_yday = 0; -- 2.17.1