Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD5AFC433EF for ; Tue, 26 Apr 2022 14:37:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4B4198390C; Tue, 26 Apr 2022 16:37:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650983874; bh=JNs+CtUZqSiSk/hVeaS/8WmPStlADmbI7CMg3z9ODfU=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=AoWv5aFaVkk8TLrwLnReA731Ufm8Mt2QsiqubETUxQzSI79VZYHIfAdcLxnGRSR55 DpqVx6furMoyTN9L2QQAbptm4OxSNi9f/JauE55h5DvKTLFfz9fTYfFpAFqcPftknF 3o4dqQYvXObhb1B5/iWkuQOkrzs4qXDPPhN1X13/ZaPxmSlUJkeHSl8x/dbbSvNh6j IyrOn9rfM/HfCQBDF5eEax04rvUgXWXqfs29e2d4gUB0q4KZS9MohBsPNaFUW7im+4 oKVLY6PvFb2D9FUTR9bYUE5hiKcgQvznzutuvEMEHac04m0zWWSsyGB8UkxcrxhjRA 5Jh+hT2bXKs+w== Received: from tr.lan (ip-86-49-12-201.net.upcbroadband.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1E1C68390C; Tue, 26 Apr 2022 16:37:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650983872; bh=JNs+CtUZqSiSk/hVeaS/8WmPStlADmbI7CMg3z9ODfU=; h=From:To:Cc:Subject:Date:From; b=PdgGecfWwYGBMlzn/RkyhWasMDhZqsBfcXsErM4GUUNalwc7h3yqgN1kKepMCJmjd 6Jpplxs5rjmPgnGbL7USHLa83ZhI1dACvlTcLxsww8whk/XwiEHCTvrvKyl0GiNsMp dHWELY8q/nP8bofJNAwuy1GeVvcKhRzgknaDHYC9EG736/gM7AY2JzqsHYVxgJsmxa LI1HQnGuej/fE+2pB7VGe74bOIUUqlzlzcOz0jRTSmy6VC52S7+8IW67R80rpfn6FJ h3Eg/IZcdF0LDtUxpPE27wr2UfMl7eom93I964TDJ9eRn+iJsavA1lZ4uPUvdTHRPe 5LgtaBIuzOSaQ== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Patrick Delaunay , Patrice Chotard Subject: [PATCH v2] ram: stm32mp1: Conditionally enable ASR Date: Tue, 26 Apr 2022 16:37:41 +0200 Message-Id: <20220426143741.78339-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Enable DRAM ASR, auto self-refresh, conditionally, based on DT PWRCTL register bits. While ASR does save considerable amount of power at runtime automatically, it also causes LTDC underruns on large panels. Let user select whether or not ASR is required or not, generally ASR should be enabled on portable and battery operated devices. Signed-off-by: Marek Vasut Cc: Patrick Delaunay Cc: Patrice Chotard --- V2: Infer ASR settings from DT PWRCTL --- drivers/ram/stm32mp1/stm32mp1_ddr.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/ram/stm32mp1/stm32mp1_ddr.c b/drivers/ram/stm32mp1/stm32mp1_ddr.c index 528a171b454..ab913a68761 100644 --- a/drivers/ram/stm32mp1/stm32mp1_ddr.c +++ b/drivers/ram/stm32mp1/stm32mp1_ddr.c @@ -653,10 +653,14 @@ static void stm32mp1_refresh_restore(struct stm32mp1_ddrctl *ctl, wait_sw_done_ack(ctl); } -static void stm32mp1_asr_enable(struct ddr_info *priv) +static void stm32mp1_asr_enable(struct ddr_info *priv, const u32 pwrctl) { struct stm32mp1_ddrctl *ctl = priv->ctl; + /* SSR is the best we can do. */ + if (!(pwrctl & DDRCTRL_PWRCTL_EN_DFI_DRAM_CLK_DISABLE)) + return; + clrsetbits_le32(priv->rcc + RCC_DDRITFCR, RCC_DDRITFCR_DDRCKMOD_MASK, RCC_DDRITFCR_DDRCKMOD_ASR); @@ -666,8 +670,12 @@ static void stm32mp1_asr_enable(struct ddr_info *priv) writel(DDRCTRL_PWRTMG_POWERDOWN_TO_X32(0x10) | DDRCTRL_PWRTMG_SELFREF_TO_X32(0x01), &ctl->pwrtmg); + + /* HSR we can do. */ setbits_le32(&ctl->pwrctl, DDRCTRL_PWRCTL_EN_DFI_DRAM_CLK_DISABLE); - setbits_le32(&ctl->pwrctl, DDRCTRL_PWRCTL_SELFREF_EN); + + if (pwrctl & DDRCTRL_PWRCTL_SELFREF_EN) /* ASR we can do. */ + setbits_le32(&ctl->pwrctl, DDRCTRL_PWRCTL_SELFREF_EN); setbits_le32(&ctl->dfimisc, DDRCTRL_DFIMISC_DFI_INIT_COMPLETE_EN); wait_sw_done_ack(ctl); @@ -845,7 +853,7 @@ start: config->c_reg.pwrctl); /* Enable auto-self-refresh, which saves a bit of power at runtime. */ - stm32mp1_asr_enable(priv); + stm32mp1_asr_enable(priv, config->c_reg.pwrctl); /* enable uMCTL2 AXI port 0 and 1 */ setbits_le32(&priv->ctl->pctrl_0, DDRCTRL_PCTRL_N_PORT_EN); -- 2.35.1