Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476BAC433F5 for ; Tue, 26 Apr 2022 22:07:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbiDZWKs (ORCPT ); Tue, 26 Apr 2022 18:10:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355645AbiDZWKo (ORCPT ); Tue, 26 Apr 2022 18:10:44 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68B9B1EEFA for ; Tue, 26 Apr 2022 15:07:34 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id e24so7438344wrc.9 for ; Tue, 26 Apr 2022 15:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linexp-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Yy7WWv+wo0N+N8WMs6A4Tlr4aeP0/wiZ8RqZd5hVwfs=; b=cTgTD0SrzGzn63KkZo0AOJqVghLtuvjREiR8Sa/hAZ5d5rVjRNMoLw01/P8wNU1n+A fj84+NZlAKIa0cgAAtvVM8Am2XLv8EwTNgQaPvQr2loaEwTy8ewfTmUWfRwjaYXU62vZ 2vii/2I6UzbdlvyWBJHreTAfuS7gypIPfp0l6VykFqqwbT0CzOAIk99g4NELUIZv+AzW SKmRKxdzxk6vY+D8cNL1RupFjRVwFzwvZZEZY/Ek7VCUKXGcYbexELYWxSkNZy0vnw+n Ln/rvsYMXlp/zrKxcWpck4VhNW9tuw3fXzwrrmRQ2h/w2n/OtM0eHY/TlF2Z/ofLJrwN UlQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Yy7WWv+wo0N+N8WMs6A4Tlr4aeP0/wiZ8RqZd5hVwfs=; b=D86rEGm7x3E2QB1Nz2xS4zaXsr0Y32U9VrvtEQSlKprcfFdGYkyx6uEt5h5r/i4Ktt Y/fUMqULOgTnabfPSDza6AJi/GJXEWBjtH0/6NjB9IIP3QABwYbewFyK/JIVt/8b3elz 5YddVBTvZU/vLLSDD+pZGiIAdgHvGnFbxTKb3aQgYPz93u+QViRYa70D9zF9sBj3ZDyG J+h0zH24sF3Erbh6PV8qpX3anVyOtU3IAeUIdae7VabZisMPYDeQr8wf+y8vQTkrK8Ze VcaHAZvNzUB1r72cT4mD7F9/V/JiTYSvKCCasoq7OkE3oFuNGeS3cpcU5muqOtfuK1L1 SOlw== X-Gm-Message-State: AOAM531qrQbYSelias6QumncZU4YsWwlw8jlKNNE+1sxnNIr3rTql73J FGcNSlnJR65+FydXwgJyf6vE2JCnlefKdYF+cOo= X-Google-Smtp-Source: ABdhPJxvyg9Ld5uTWbOJmcZxbrbTWRxH6ggvKr0Q/daaB+MQ9bPaNy1JlivmRV0FYp/v81fCKvOsCA== X-Received: by 2002:a5d:584e:0:b0:20a:9122:2c3c with SMTP id i14-20020a5d584e000000b0020a91222c3cmr19873724wrf.193.1651010852928; Tue, 26 Apr 2022 15:07:32 -0700 (PDT) Received: from localhost.localdomain (176-182-171-101.abo.bbox.fr. [176.182.171.101]) by smtp.gmail.com with ESMTPSA id z14-20020a7bc14e000000b00392a3e62b66sm202694wmi.33.2022.04.26.15.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 15:07:32 -0700 (PDT) From: Daniel Lezcano To: rafael@kernel.org, daniel.lezcano@linaro.org Cc: khilman@baylibre.com, abailon@baylibre.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 00/15] thermal OF rework Date: Wed, 27 Apr 2022 00:06:54 +0200 Message-Id: <20220426220709.3055703-1-daniel.lezcano@linexp.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The thermal framework initialization with the device tree appears to be complicated and hard to make it to evolve. It contains duplication of almost the same thermal generic structures and has an assymetric initialization making hard any kind of serious changes for more complex features. One of them is the multiple sensors support per thermal zone. In order to set the scene for the aforementioned feature with generic code, we need to cleanup and rework the device tree initialization. However this rework is not obvious because of the multiple components entering in the composition of a thermal zone and being initialized at different moments. For instance, a cooling device can be initialized before a sensor, so the thermal zones must exist before the cooling device as well as the sensor. This asynchonous initialization forces the thermal zone to be created with fake ops because they are mandotory and build a list of cooling devices which is used to lookup afterwards when the cooling device driver is registering itself. Actually, the correct behavior IMHO, would be having a sensor registration resulting in the thermal zone creation. If the cooling device is registered before, it won't find the thermal zone and should return -EPROBE_DEFER. As there could be a large number of changes, this first series provide some steps forward for a simpler device tree initialization. The first patch could appear scary as it touches a big number of files but it is actually just renaming a structure name Daniel Lezcano (15): thermal/core: Rename thermal_zone_device to thermal_zone thermal/core: Change thermal_zone_ops to thermal_sensor_ops thermal/core: Add a thermal sensor structure in the thermal zone thermal/core: Remove duplicate information when an error occurs thermal/of: Replace device node match with device node search thermal/of: Remove the device node pointer for thermal_trip thermal/of: Move thermal_trip structure to thermal.h thermal/core: Remove unneeded EXPORT_SYMBOLS thermal/core: Move thermal_set_delay_jiffies to static thermal/core: Rename trips to ntrips thermal/core: Add thermal_trip in thermal_zone thermal/core: Register with the trip points thermal/of: Store the trips in the thermal zone thermal/of: Use thermal trips stored in the thermal zone thermal/of: Initialize trip points separately .../driver-api/thermal/power_allocator.rst | 10 +- .../driver-api/thermal/sysfs-api.rst | 28 +- drivers/acpi/thermal.c | 46 +-- drivers/gpu/drm/tiny/repaper.c | 2 +- drivers/hwmon/hwmon.c | 6 +- drivers/hwmon/scpi-hwmon.c | 2 +- drivers/iio/adc/sun4i-gpadc-iio.c | 2 +- drivers/input/touchscreen/sun4i-ts.c | 2 +- drivers/mmc/host/sdhci-omap.c | 2 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 2 +- .../ethernet/chelsio/cxgb4/cxgb4_thermal.c | 16 +- .../ethernet/mellanox/mlxsw/core_thermal.c | 78 ++--- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 20 +- drivers/platform/x86/acerhdf.c | 30 +- drivers/platform/x86/gpd-pocket-fan.c | 4 +- drivers/power/supply/power_supply_core.c | 12 +- drivers/regulator/max8973-regulator.c | 6 +- drivers/thermal/amlogic_thermal.c | 2 +- drivers/thermal/armada_thermal.c | 24 +- drivers/thermal/broadcom/bcm2711_thermal.c | 4 +- drivers/thermal/broadcom/bcm2835_thermal.c | 8 +- drivers/thermal/broadcom/brcmstb_thermal.c | 6 +- drivers/thermal/broadcom/ns-thermal.c | 2 +- drivers/thermal/broadcom/sr-thermal.c | 2 +- drivers/thermal/da9062-thermal.c | 22 +- drivers/thermal/db8500_thermal.c | 6 +- drivers/thermal/dove_thermal.c | 16 +- drivers/thermal/gov_bang_bang.c | 12 +- drivers/thermal/gov_fair_share.c | 18 +- drivers/thermal/gov_power_allocator.c | 44 +-- drivers/thermal/gov_step_wise.c | 12 +- drivers/thermal/gov_user_space.c | 6 +- drivers/thermal/hisi_thermal.c | 10 +- drivers/thermal/imx8mm_thermal.c | 2 +- drivers/thermal/imx_sc_thermal.c | 2 +- drivers/thermal/imx_thermal.c | 36 +-- .../intel/int340x_thermal/int3400_thermal.c | 14 +- .../intel/int340x_thermal/int3402_thermal.c | 2 +- .../intel/int340x_thermal/int3403_thermal.c | 4 +- .../int340x_thermal/int340x_thermal_zone.c | 26 +- .../int340x_thermal/int340x_thermal_zone.h | 10 +- .../processor_thermal_device.c | 8 +- .../processor_thermal_device_pci.c | 26 +- .../thermal/intel/intel_bxt_pmic_thermal.c | 4 +- drivers/thermal/intel/intel_menlow.c | 2 +- drivers/thermal/intel/intel_pch_thermal.c | 20 +- .../thermal/intel/intel_quark_dts_thermal.c | 28 +- drivers/thermal/intel/intel_soc_dts_iosf.c | 20 +- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 +- drivers/thermal/intel/x86_pkg_temp_thermal.c | 26 +- drivers/thermal/k3_bandgap.c | 2 +- drivers/thermal/kirkwood_thermal.c | 16 +- drivers/thermal/max77620_thermal.c | 4 +- drivers/thermal/mtk_thermal.c | 2 +- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 6 +- drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 6 +- drivers/thermal/qcom/tsens.c | 6 +- drivers/thermal/qcom/tsens.h | 2 +- drivers/thermal/qoriq_thermal.c | 2 +- drivers/thermal/rcar_gen3_thermal.c | 16 +- drivers/thermal/rcar_thermal.c | 22 +- drivers/thermal/rockchip_thermal.c | 10 +- drivers/thermal/rzg2l_thermal.c | 4 +- drivers/thermal/samsung/exynos_tmu.c | 22 +- drivers/thermal/spear_thermal.c | 20 +- drivers/thermal/sprd_thermal.c | 8 +- drivers/thermal/st/st_thermal.c | 16 +- drivers/thermal/st/st_thermal.h | 2 +- drivers/thermal/st/st_thermal_memmap.c | 2 +- drivers/thermal/st/stm_thermal.c | 6 +- drivers/thermal/sun8i_thermal.c | 4 +- drivers/thermal/tegra/soctherm.c | 38 +-- drivers/thermal/tegra/tegra-bpmp-thermal.c | 6 +- drivers/thermal/tegra/tegra30-tsensor.c | 20 +- drivers/thermal/thermal-generic-adc.c | 2 +- drivers/thermal/thermal_core.c | 246 ++++++++------- drivers/thermal/thermal_core.h | 59 ++-- drivers/thermal/thermal_helpers.c | 51 ++-- drivers/thermal/thermal_hwmon.c | 26 +- drivers/thermal/thermal_hwmon.h | 12 +- drivers/thermal/thermal_mmio.c | 2 +- drivers/thermal/thermal_netlink.c | 18 +- drivers/thermal/thermal_of.c | 286 ++++++++++-------- drivers/thermal/thermal_sysfs.c | 116 +++---- .../ti-soc-thermal/ti-thermal-common.c | 10 +- drivers/thermal/uniphier_thermal.c | 4 +- include/linux/power/charger-manager.h | 2 +- include/linux/power_supply.h | 2 +- include/linux/thermal.h | 144 +++++---- include/trace/events/thermal.h | 4 +- .../trace/events/thermal_power_allocator.h | 4 +- 92 files changed, 988 insertions(+), 938 deletions(-) -- 2.25.1