Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0BF9C433F5 for ; Thu, 28 Apr 2022 19:42:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2F06883EED; Thu, 28 Apr 2022 21:42:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AtvdVNE5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 29A5283EC6; Thu, 28 Apr 2022 21:42:44 +0200 (CEST) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8E00A83ED9 for ; Thu, 28 Apr 2022 21:42:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id hh4so4263284qtb.10 for ; Thu, 28 Apr 2022 12:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uLA52WNQwmUpxiSyBIWiDBYlcnQ12QZyWyeOUumdaqs=; b=AtvdVNE5ltgZeJ0wljqg+QPNmB/Ul7M6wd18b9T59HPP8YBE9ciglmVfd6akffYkKe 4QJANoKjAiJjR8jlUStEjVSVqTjjZ+g5OoYs+mMu6Emo8aWw4/14FMyGrQE2Z6uZ+1JV rM9eyznCBCoUG8ZFC4Il7nAwGuqRqZmNsb1Bw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uLA52WNQwmUpxiSyBIWiDBYlcnQ12QZyWyeOUumdaqs=; b=RSH9bK1V7991KGUkcUKCaHLTjl/6OQ+rA21k029Mo2soYR1NlL3/+8HQv/2U6VvN4j Du6WkX4zOhnD1HG39QFsSavlldaf0irBPsCc/ulHi4CQO7nI+v/F5N5cUZAKQOP/LvbT lYAw7fyKaQn7MIX6EKk5ihYpx2hJzzT2zEcPdacDsABmSsZPvl3wkIgu4M8Hxf56h3HR V1cUPB0/hjfSr2qbxOfalaZ4ooP5uFVeJPinjuP/on2O8tU9lTA0jMthPASkgrOZl6fj OtOLKPrUpzBtW4JFnRlusPISMJrEVWtQ7rV/q3n2kUr6EqLqJkQR7WXiUWhR793Yny+k 3btA== X-Gm-Message-State: AOAM533QUhk2T7MOD4txzNV+EXgsRlpoHD5pVR7rg0m5GDv5UMmxSIJ4 AemXTGEXDpUP0laLiREojYv7fw== X-Google-Smtp-Source: ABdhPJwtsIXzg/bgvI7Ry/6cN+FaTSCf8ddvY79BixeGBVJxcmJeNrA30d2jMVQCu6FVjCGDdbdYSw== X-Received: by 2002:a05:622a:594:b0:2e1:d59e:68ed with SMTP id c20-20020a05622a059400b002e1d59e68edmr24842020qtb.204.1651174959299; Thu, 28 Apr 2022 12:42:39 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-41c8-9db8-25be-eadf.res6.spectrum.com. [2603:6081:7b01:4500:41c8:9db8:25be:eadf]) by smtp.gmail.com with ESMTPSA id cr24-20020a05622a429800b002ed12cea2cdsm405423qtb.96.2022.04.28.12.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 12:42:38 -0700 (PDT) Date: Thu, 28 Apr 2022 15:42:36 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Patrice Chotard , Patrick Delaunay , Sean Anderson , Simon Glass , Steven Lawrance Subject: Re: [PATCH 2/3] led: Mark device instance with DM_FLAG_PROBE_AFTER_BIND Message-ID: <20220428194236.GF1182808@bill-the-cat> References: <20220422131555.123598-1-marex@denx.de> <20220422131555.123598-2-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i3lJ51RuaGWuFYNw" Content-Disposition: inline In-Reply-To: <20220422131555.123598-2-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --i3lJ51RuaGWuFYNw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2022 at 03:15:54PM +0200, Marek Vasut wrote: > Calling device_probe() from uclass .post_bind() callback has all kinds > of odd side-effects, e.g. device instances not being available just yet. > Make use of the DM_FLAG_PROBE_AFTER_BIND instead, mark device instances > which need to be probe()d in order to configure the LED default state > with this flag and let the DM core do the device_probe() at the right > time instead. >=20 > Fixes: 72675b063b6 ("led: Configure LED default-state on boot") > Signed-off-by: Marek Vasut > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Sean Anderson > Cc: Simon Glass > Cc: Steven Lawrance > Reviewed-by: Patrice Chotard > Tested-by: Patrice Chotard Applied to u-boot/master, thanks! --=20 Tom --i3lJ51RuaGWuFYNw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJq7iwACgkQFHw5/5Y0 tywb0gwAunJkphzYOTOjK67VTuoJFnl/IV0kKaAAUi+MmYTsFVNyiY7cI+I/83Au h2My5Bw3UkqvsuqqB3DZluQ4Bz2RInw8pqEaeGPXKi/bGu9vUlEfKkzKN1RESEQ6 qpMyMeUbfnFbNYwcbj6MbI/7u86qqrLzva+CkIjAiuwL/KnLafkAf+b77oswN4nu 6lvrHWEWrY2P4zKVY+jtvkiFnDaTTKNOjLoHn2dQ36c4UAeqn8ZuR9Z6gftF+9iN lLq3O0oi4zqfGGlDh/h8o0qr3uCPVTViP7BfLaNcCohJ2FIpl5b5EusIIGTed2fX 9AOwGPOfczG6rR9rWyVGGHW/K/HgX8opH0vgDo5e+pzHQ+XiaHoJwX9oosTj2yyV lhHNCqBP3gx+lds+A7+TJvDwowQRF573HE0f55PfbdNYL2KTfqnsxc3CRaRUVDac MiRBL35DZ/6wxOqtDitMXkz6uM9mV8qejEjHTkvAEOO4PUK6g0hTAmPR4UDp4w2j jz7394OJ =/gqv -----END PGP SIGNATURE----- --i3lJ51RuaGWuFYNw--