Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F64AC433EF for ; Thu, 28 Apr 2022 19:43:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B9A9F83EDF; Thu, 28 Apr 2022 21:42:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Q8B/35Mb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7758183EDC; Thu, 28 Apr 2022 21:42:49 +0200 (CEST) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 328F183EC6 for ; Thu, 28 Apr 2022 21:42:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id r8so3942878qvx.10 for ; Thu, 28 Apr 2022 12:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CyDM6+GdWjTN7CiUY9CHdvwDF9rZl4GOwLycGYzKL/A=; b=Q8B/35MbPSQ+eMy2gKJiegt7h4y12XbR9ov3BetPKQ91ycp+rIyTESAiKX4JyrBzRF o5KkOKpeuWsblNXbG6xTBmAiCOGDCdfcDHnWZ47lUarKizL40HXZgnt5vVslq2zaBwVq RWTPYBLZHxT+rxJk9c2MLOKZILhFqRvM9a9E8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CyDM6+GdWjTN7CiUY9CHdvwDF9rZl4GOwLycGYzKL/A=; b=r1wSgCmP/Tgbb9a3P7fEEKqzEIDgGATTpPlp9gYLfUlTCb+LGH8Q+JkG0nCEC2Q458 bu8SQyIZmzW/e6QezfTE7Q2rLwRzKuilf/jsVxIWzwI2o7FOqlKudyA/JmBLfLoS4RU8 o/qEnGamXXQcHL8hnn29DwMhXuuOnKx+fXRMjME0n8rWP+rdPyF54hfCBJYmaZNUcd6Z RvjiEUlkhHNqJ5a32CB9N9etYWIBoWfIkdLH6HO1hUuwa8ZfmpoflKPB6d22oynsoQj0 eNmKmogL78GX3jXyGG8JHYWW/S8psuXuSqH2cwo+ib/e7FquwvQ5e0/KCM79aNAzyxfh fT4Q== X-Gm-Message-State: AOAM531GMrRPgABWpvIvKStMX1OnJ5Q4w9++kiu7N/PkUfGx8taVwUua gWRdlUYxuRiy9SpG9PhSoAsiLQ== X-Google-Smtp-Source: ABdhPJxqOU48m26JgC/tbUMnFgvG8qTnkzNDj3Q5iK9HzyBFUwO6xWi6PY+FGrPtTmAD2Go6zGDT7w== X-Received: by 2002:ad4:5ca3:0:b0:456:2f39:dea6 with SMTP id q3-20020ad45ca3000000b004562f39dea6mr19725727qvh.51.1651174965031; Thu, 28 Apr 2022 12:42:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-41c8-9db8-25be-eadf.res6.spectrum.com. [2603:6081:7b01:4500:41c8:9db8:25be:eadf]) by smtp.gmail.com with ESMTPSA id h4-20020ac85844000000b002f38d09d5basm527144qth.47.2022.04.28.12.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 12:42:44 -0700 (PDT) Date: Thu, 28 Apr 2022 15:42:42 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Patrice Chotard , Patrick Delaunay , Sean Anderson , Simon Glass , Steven Lawrance Subject: Re: [PATCH 3/3] led: gpio: Check device compatible string to determine the top level node Message-ID: <20220428194242.GG1182808@bill-the-cat> References: <20220422131555.123598-1-marex@denx.de> <20220422131555.123598-3-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iAL9S67WQOXgEPD9" Content-Disposition: inline In-Reply-To: <20220422131555.123598-3-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --iAL9S67WQOXgEPD9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2022 at 03:15:55PM +0200, Marek Vasut wrote: > Since 2d1deaf88ed ("led: gpio: Drop duplicate OF "label" property parsing= "), > all LED nodes have some sort of label. Use device_is_compatible(..."leds-= gpio") > to determine whether this is a top-level node, since it is only the top > level node which is compatible with "leds-gpio", the GPIO LEDs subnodes > are not. >=20 > Fixes: 2d1deaf88ed ("led: gpio: Drop duplicate OF "label" property parsin= g") > Signed-off-by: Marek Vasut > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Sean Anderson > Cc: Simon Glass > Cc: Steven Lawrance > Reviewed-by: Patrice Chotard > Tested-by: Patrice Chotard Applied to u-boot/master, thanks! --=20 Tom --iAL9S67WQOXgEPD9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJq7jIACgkQFHw5/5Y0 tyxsKwv/U7Y9YbX0zESVr3Lmm/Mv1P1ZwaWbAFN9DPAbIPzlT089xZf9g0IrPl+O Ui0PIQEeF0UsnPjFF39KjWKvATqlVcIcYGSl4S1+Ufmhg3n+5Q5A1FejQ2H1/ujr inV931ZOJQLJfyUjmLjvMF2i8lYGs6vTagqJLRR4CMlHwidGjihJArnhvtdpUg5x 7vFc0uOa646zR/9tJ2V/r0B7k4dp9vlwnLBNqgYrIgz797gbZ4n+XzFANtmfgWT6 DtpbcbZALeZ/GJZ7V3MgZPoprKYexf8o95XR0M4b/MI/W036phlXWSvmKnerqJSz z3Qn1vqV/5i5KnhlwU13Ugt63t5GQPdJnWIlcyGh3+f9p/wVKo7d/diySMy98Z0P WFQoTjj8lf8RjNaacPzs0huF3/eKTrAF/Ee3tuATzX61je9yMeLUsJ8xLoMz5zUH s7HojWBXRBZr1mez6wkjuP7vLtkr2TJ5chvgx9UzUL9tNo5/AHU3ve6s4zSmry2F 1P8PhfLG =c8Ni -----END PGP SIGNATURE----- --iAL9S67WQOXgEPD9--