Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30934C433F5 for ; Fri, 29 Apr 2022 18:05:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 223BF83F2E; Fri, 29 Apr 2022 20:05:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GT4/U55F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E334A83F21; Fri, 29 Apr 2022 20:04:00 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E2B2A83F25 for ; Fri, 29 Apr 2022 20:03:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id s4so6525189qkh.0 for ; Fri, 29 Apr 2022 11:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6yusI9tgLKayqPmnQ8HLh+g2CVZgt+myHnUWK/E8u2Y=; b=GT4/U55FAafJ+8SuYyxrPACYIiuFzKknryq9MM93/yFe7BDFyvxYcUoGGIg98QK6Rg v2FXKzF0CxKpxtWwbFLQPxd4WbhgtnPNBy0DgDQ10DwGyw8E/Mof9tjhMFZvtibBKQvd dTRfw14fJ80PL2vLUMWg2AH24IGgFVimaMR+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6yusI9tgLKayqPmnQ8HLh+g2CVZgt+myHnUWK/E8u2Y=; b=AOatS8fEAemlOsdwaCdTuK0koT7AQodsEN5o/IPkK8LZqCgPQwFEDwdVUW2wPTYDtc ATOAmEb/YLmIYp7g8QAb0eO3O5I/nIafo/kHvmjjsornozdEp/GA2tdJn9tOb/Illf8h HCzWb/w/KM5kPR1Zf+ibpa6NSpmaV9+ifOk5AAlr1I3uqlsrGP46mziKYZXpaJhB1sGc Q8AibRcrkBS1exoicQRyQGbB4f9GQnZtokHdOKDpYOFXFovgAU2M2alc3q8hsOc4IfAb rCHSlaXrdsLE/VW/4zziQnIDSiN3PO7iCh5jOciXx2PFCmihnPWcKzzE0FkRvJ/iff0O yadQ== X-Gm-Message-State: AOAM5302R24dcKplSmf9Y6DuxOE0HwRFPo9CTdJpbh2gvQohm3uOv9qi IDY23uDsMGxCLtXwXHQL3vIP+YijpTAcQA== X-Google-Smtp-Source: ABdhPJwLw2wI43/7g0qZPTOsX7MNEQ49HqBsy73vogDIRX1K0+uT41xf3KFrqTzmgpPKSsweBHOM1w== X-Received: by 2002:a37:a489:0:b0:69f:9f44:2f96 with SMTP id n131-20020a37a489000000b0069f9f442f96mr254977qke.658.1651255435725; Fri, 29 Apr 2022 11:03:55 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-a827-6dbc-a8e1-e6af.res6.spectrum.com. [2603:6081:7b01:4500:a827:6dbc:a8e1:e6af]) by smtp.gmail.com with ESMTPSA id v67-20020a376146000000b0069ec181a0c6sm1778620qkb.10.2022.04.29.11.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 11:03:55 -0700 (PDT) Date: Fri, 29 Apr 2022 14:03:53 -0400 From: Tom Rini To: Andrew Scull Cc: u-boot@lists.denx.de, sjg@chromium.org, seanga2@gmail.com Subject: Re: [PATCH 8/8] test: dm: devres: Remove use-after-free Message-ID: <20220429180353.GD1182808@bill-the-cat> References: <20220403103915.3338027-1-ascull@google.com> <20220403103915.3338027-9-ascull@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4JxvUTD846AMAZAS" Content-Disposition: inline In-Reply-To: <20220403103915.3338027-9-ascull@google.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --4JxvUTD846AMAZAS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 03, 2022 at 10:39:15AM +0000, Andrew Scull wrote: > Use-after-free shouldn't be used, even in tests. It's bad practice and > makes the test brittle. >=20 > Signed-off-by: Andrew Scull > Cc: Simon Glass > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --4JxvUTD846AMAZAS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJsKIkACgkQFHw5/5Y0 tyxhjgv7BqvWOGeHtXktGi+NJARVvpyj1X++jynXN3vj2tIW407LqBR1Roi3uecY ACcKD2NomhByCEU99KxXuhI9lF2S56P1nfegB1e26BM4VwWbNdwR0gvHk1doV44b rzJZfrbm2kUTf0NlD3lUnWA2ZucXu85jl0BVQcHiRMv+p0tM0I5aldz6xgMyJPXC nl+0Iikvn/QowFZZcWfGsPFUscbVF7HJhpzoBLteDaUTQM0z+oahmCLR0R9KkHSW VqD6AYYBfs4nO8GuB0v0aeiB5cQBe0JiCyOyjIEKKekfC4CZxmGJibP02r1LAuBI WkU1cUZCU26YXeHck+tKnt1VoYNyGVF3LGefX/yGds/uk7rewEwfadGvzWdlzkVD 5csHNrp/qhKm9WTWW66hUScI79uvO/lsoPeY2woa204uBNk1gSKa0aS2fuVZYjso RkCmZ9C9RHYgpHoxZDC2eahkNej5epZcCAwxcEBm3sllgW3iYAVb7wjpvwX60XIB CY6Ujx9I =kNXB -----END PGP SIGNATURE----- --4JxvUTD846AMAZAS--