Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A72C433F5 for ; Sun, 1 May 2022 16:43:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1D02A83959; Sun, 1 May 2022 18:43:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1651423424; bh=mAemYwKCjb6D6VaGn2LCod/PGdx9ClWYZBhbfAxdyhs=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=tf3y6dzRC2vX4ITcLgW3F7gfZXhiUVd+ltHBGU1PXUnQD6tq9Ra9oxzlOgw5Vfuop G2PDPBG7tP0WDjktKTfLD29q9fJk3DUpB71PcosbUxdkWmpsskrnrkPrtrOD3Ixws2 9l4aaVxEJo5l2ZPfcckxQ46p1COP91FU0QDMVc0XRJpeVdf7yz/be5hPGQGgFVfQXJ 0fpaKPoDNRAN8yzjKFIVr5oVDB1MPN1ssHFeUt3LD1Ovkz1qMfWxpUE+Rmt0YvOW/4 p1SCyIie8hTY5synV+IGd/8TLw5cFknOSq7mzvVCZ9Fc4Nos7WfYQ+XbPUted75CBg sTUtiTIWT8kow== Received: from tr.lan (ip-86-49-12-201.net.upcbroadband.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 0907C818A3; Sun, 1 May 2022 18:43:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1651423422; bh=mAemYwKCjb6D6VaGn2LCod/PGdx9ClWYZBhbfAxdyhs=; h=From:To:Cc:Subject:Date:From; b=YNFnZq8XRDAXgww1ujZpPcMzB2QaRs7NLySDlIqOXp1HdLYvgliDUZatiuQqdozoT CB9Yp71LJSZBlefWYHD/65qxUlW+f5ePhfNE77G5CiA0rRvWJ598G45L+0WpELsPrs tQGaMbLUBYu0j38vcVENwh9B8ZgKCEdyNmktEVPIMYAl8FUeZgBbFpgwltkcvlzz/2 WdDqbgI4X69pTekVbGgtc/F/AubGQ3Cp/vnU1GtnpZJWThuIh/vPSjrxsS6jeISC9x 0LOnahNsuFW0X+naRkaP3TVr0tOkCQZ0FyHuPcPA1DYbSrbX6ZrGTeOSfNxMhLCjUN qiguCy6LaaEVQ== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Patrick Delaunay , Patrice Chotard , Ramon Fried Subject: [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM Date: Sun, 1 May 2022 18:43:28 +0200 Message-Id: <20220501164329.70028-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM may be extended with other MAC options connected to FMC2 bus, like the DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the packet buffers of such limited MACs, which leads to e.g. TFTP timeouts. This also avoids receiving a short packet fragment at the end of each TFTP block, which led to reduced performance. Signed-off-by: Marek Vasut Cc: Patrick Delaunay Cc: Patrice Chotard Cc: Ramon Fried --- configs/stm32mp15_dhcom_basic_defconfig | 1 - configs/stm32mp15_dhcor_basic_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig index ec955eae200..0ff015cae49 100644 --- a/configs/stm32mp15_dhcom_basic_defconfig +++ b/configs/stm32mp15_dhcom_basic_defconfig @@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SPL_ENV_IS_NOWHERE=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_IP_DEFRAG=y -CONFIG_TFTP_BLOCKSIZE=1536 CONFIG_STM32_ADC=y CONFIG_SPL_BLOCK_CACHE=y CONFIG_DFU_MMC=y diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig index 387e068155e..83614b9fc8e 100644 --- a/configs/stm32mp15_dhcor_basic_defconfig +++ b/configs/stm32mp15_dhcor_basic_defconfig @@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SPL_ENV_IS_NOWHERE=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_IP_DEFRAG=y -CONFIG_TFTP_BLOCKSIZE=1536 CONFIG_STM32_ADC=y CONFIG_SPL_BLOCK_CACHE=y CONFIG_DFU_MMC=y -- 2.35.1