Content-Type: multipart/mixed; boundary="===============6648449574711377210==" MIME-Version: 1.0 From: SeongJae Park To: kbuild-all@lists.01.org Subject: Re: [PATCH] mm/damon/sysfs: fix pid leak under fvaddr ops use case Date: Wed, 04 May 2022 17:16:01 +0000 Message-ID: <20220504171601.106690-1-sj@kernel.org> In-Reply-To: <202205041011.jv6vuDe4-lkp@intel.com> List-Id: --===============6648449574711377210== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, 4 May 2022 10:53:47 +0800 kernel test robot wrote: > Hi SeongJae, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on hnaz-mm/master] This patch is on top of mm-unstable branch of akpm's mm tree. More specifically, this patch depends on a commit[1] on the tree. So, this error shouldn't occur on top of the tree. If I'm missing something, please let me know. [0] git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm [1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h= =3Dmm-unstable&id=3Dcb52aff4ed86a5992309bc7efc228303a7dc084d Thanks, SJ > = > url: https://github.com/intel-lab-lkp/linux/commits/SeongJae-Park/mm-d= am=3D > on-sysfs-fix-pid-leak-under-fvaddr-ops-use-case/20220504-060657 > base: https://github.com/hnaz/linux-mm master > config: hexagon-randconfig-r045-20220501 (https://download.01.org/0day-ci= /a=3D > rchive/20220504/202205041011.jv6vuDe4-lkp(a)intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b= 3a=3D > 645a1e30011cc8da624f13dac5fd915628) > reproduce (this is a W=3D3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/=3D > make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/60cfe4571b04ef4ca= 2e=3D > 34793fbad737bb43dc0c6 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review SeongJae-Park/mm-damon-sysfs-fix= -p=3D > id-leak-under-fvaddr-ops-use-case/20220504-060657 > git checkout 60cfe4571b04ef4ca2e34793fbad737bb43dc0c6 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=3D3D$HOME/0day COMPILER=3D3Dclang make.cros= s W=3D3D=3D > 1 O=3D3Dbuild_dir ARCH=3D3Dhexagon SHELL=3D3D/bin/bash mm/damon/ > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All errors (new ones prefixed by >>): > = > >> mm/damon/sysfs.c:2089:20: error: use of undeclared identifier 'DAMON_O= PS=3D > _FVADDR'; did you mean 'DAMON_OPS_VADDR'? > ctx->ops.id =3D3D=3D3D DAMON_OPS_FVADD= R) > ^~~~~~~~~~~~~~~~ > DAMON_OPS_VADDR > include/linux/damon.h:267:2: note: 'DAMON_OPS_VADDR' declared here > DAMON_OPS_VADDR, > ^ > mm/damon/sysfs.c:2206:55: error: use of undeclared identifier 'DAMON_O= PS=3D > _FVADDR'; did you mean 'DAMON_OPS_VADDR'? > if (ctx->ops.id !=3D3D DAMON_OPS_VADDR && ctx->ops.id !=3D3D D= AMON_O=3D > PS_FVADDR) > ^~~~~~~~~= ~~=3D > ~~~~~ > DAMON_OPS= _V=3D > ADDR > include/linux/damon.h:267:2: note: 'DAMON_OPS_VADDR' declared here > DAMON_OPS_VADDR, > ^ > 2 errors generated. > = > = > vim +2089 mm/damon/sysfs.c > = > 2082 > 2083 static void damon_sysfs_destroy_targets(struct damon_ctx *ctx) > 2084 { > 2085 struct damon_target *t, *next; > 2086 > 2087 damon_for_each_target_safe(t, next, ctx) { > 2088 if (ctx->ops.id =3D3D=3D3D DAMON_OPS_VADDR || > > 2089 ctx->ops.id =3D3D=3D3D DAMON_OPS_= FVADDR=3D > ) > 2090 put_pid(t->pid); > 2091 damon_destroy_target(t); > 2092 } > 2093 } > 2094 > = > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp >=20 --===============6648449574711377210==--