Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6144FC433F5 for ; Fri, 6 May 2022 20:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1392392AbiEFUES (ORCPT ); Fri, 6 May 2022 16:04:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238593AbiEFUER (ORCPT ); Fri, 6 May 2022 16:04:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC60224F37 for ; Fri, 6 May 2022 13:00:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2867621FE for ; Fri, 6 May 2022 20:00:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8483C385AC; Fri, 6 May 2022 20:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651867232; bh=v96SX/IKJerDHD9AOiqmePLyVxcToQXlfEVLW6ntjRw=; h=From:To:Cc:Subject:Date:From; b=jknCyzMcvoCu13hN4aozddigXIWdc48/Dgkx410dzVg0Xc9BxvneHQc18vZR4uJZA zxINdts+tr2/h3PIce36Qw3+5QJqxiL3nHRWdphH7mtS/5tWwSHKa72ujbgZ2Svoyn mLDRKL4+R6vKa4qMWQRCxmVipVjiRTBDBHiKaiV48ZWaY8a2sD8qJgVElWwjx7q7a4 GmKHkA8De5POnTvR1LKRl2XXNJB/A7fmN6lE9laJ8G/PiqYGJI6NAzgksVWcFljIif 3GlkNSyo53rVkjfk7r6zBUAUH8/uaPBk39Kn+fHQ1OJfrPjEoYaNSsnZz5/j4WZkaI +fVYjwzudLaRQ== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, Jakub Kicinski , ioana.ciornei@nxp.com Subject: [PATCH net-next] eth: dpaa2-mac: remove a dead-code NULL check on fwnode parent Date: Fri, 6 May 2022 13:00:29 -0700 Message-Id: <20220506200029.852310-1-kuba@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since commit 4e30e98c4b4c ("dpaa2-mac: return -EPROBE_DEFER from dpaa2_mac_open in case the fwnode is not set") @parent can't be NULL after the if. It's either the address of the ->fwnode of @dpmacs or @fwnode in case of ACPI. Signed-off-by: Jakub Kicinski --- Right, Ioana? Let's clean this up so the of_node_put() bots go away. CC: ioana.ciornei@nxp.com --- drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c index c48811d3bcd5..c9bee9a0c9b2 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c @@ -108,9 +108,6 @@ static struct fwnode_handle *dpaa2_mac_get_node(struct device *dev, return ERR_PTR(-EPROBE_DEFER); } - if (!parent) - return NULL; - fwnode_for_each_child_node(parent, child) { err = -EINVAL; if (is_acpi_device_node(child)) -- 2.34.1