Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73A85C433FE for ; Mon, 9 May 2022 13:49:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACAC710E5E0; Mon, 9 May 2022 13:49:06 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 543FC10E5E0 for ; Mon, 9 May 2022 13:49:05 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9C761480; Mon, 9 May 2022 06:49:04 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5639C3F73D; Mon, 9 May 2022 06:49:03 -0700 (PDT) Date: Mon, 9 May 2022 14:49:01 +0100 From: Andre Przywara To: Rob Herring Subject: Re: [PATCH v2 10/11] dt-bindings: display: convert Arm Mali-DP to DT schema Message-ID: <20220509144901.26707a1d@donnerap.cambridge.arm.com> In-Reply-To: <1651876793.707852.2407424.nullmailer@robh.at.kernel.org> References: <20220506140533.3566431-1-andre.przywara@arm.com> <20220506140533.3566431-11-andre.przywara@arm.com> <1651876793.707852.2407424.nullmailer@robh.at.kernel.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , David Airlie , Will Deacon , Liviu Dudau , dri-devel@lists.freedesktop.org, Rob Herring , Robin Murphy , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 06 May 2022 17:39:53 -0500 Rob Herring wrote: > On Fri, 06 May 2022 15:05:32 +0100, Andre Przywara wrote: > > The Arm Mali Display Processor (DP) 5xx/6xx is a series of IP that scans > > out a framebuffer and hands the pixels over to a digital signal encoder. > > It supports multiple layers, scaling and rotation. > > > > Convert the existing DT binding to DT schema. > > > > Signed-off-by: Andre Przywara > > --- > > .../bindings/display/arm,malidp.txt | 68 ---------- > > .../bindings/display/arm,malidp.yaml | 116 ++++++++++++++++++ > > 2 files changed, 116 insertions(+), 68 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/arm,malidp.txt > > create mode 100644 Documentation/devicetree/bindings/display/arm,malidp.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > display@f080000: 'arm,malidp-arqos-value' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb Ah, good point, I missed that directory when testing. I came up with the following change on top: ============================== diff --git a/Documentation/devicetree/bindings/display/arm,malidp.yaml b/Documentation/devicetree/bindings/display/arm,malidp.yaml index ea7b7100548bf..bc0d3f3ab2b75 100644 --- a/Documentation/devicetree/bindings/display/arm,malidp.yaml +++ b/Documentation/devicetree/bindings/display/arm,malidp.yaml @@ -76,6 +76,14 @@ properties: description: integer describing the ARQoS levels of DP500's QoS signaling + arm,malidp-arqos-value: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Quality-of-Service value for the display engine FIFOs, to write + into the RQOS register of the DP500. + See the ARM Mali-DP500 TRM for details on the encoding. + If omitted, the RQOS register will not be changed. + port: $ref: /schemas/graph.yaml#/properties/port unevaluatedProperties: false ============================== Cheers, Andre