Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947E3C433F5 for ; Thu, 12 May 2022 06:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350178AbiELGNS (ORCPT ); Thu, 12 May 2022 02:13:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350173AbiELGNR (ORCPT ); Thu, 12 May 2022 02:13:17 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 742B270934 for ; Wed, 11 May 2022 23:13:16 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id s10-20020a5b074a000000b0064b5176b9b1so1376912ybq.9 for ; Wed, 11 May 2022 23:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc:content-transfer-encoding; bh=f+e4pvMpvZ5FD8KZvOjUh4XoOW7Z6kreH9FTFgJ4ipI=; b=FjsXibDunA+Dx5EV7EM1Jq8yd6LDr220wmrdKWi6QRiQgd+r61DfTxp0ijxQQON9Z2 4pEA/4bd+PSqwIeuQ2ltxwo32q7MAPuk01Zup0Yd9+haDMRPSoKNs+UNL+8em6C/lS46 VBTPSC8S83NnQki5HSoAgj+fm9ODAV8lBJfF9jM/5Go+MtV0tXUoB8kenWbIngV3YLUK jZllC0hSseK/MgTh74z5j5n5QwNER06x3bCP1Wh6wkZauXZXI0kL0s8cZEyUs+a2ROir MzXQwQE7T+NZsNR5sQrXRP6MzquqoFIjFB3ZuCB48j1lQLTQ89J6eViOzWcAX2fK6Mb5 6qkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc:content-transfer-encoding; bh=f+e4pvMpvZ5FD8KZvOjUh4XoOW7Z6kreH9FTFgJ4ipI=; b=mo+LSgOPQ6nSDXJ2/m7vzoHwF3M/YSGzeKIz/RFIAEE7lXrxqCtrv9BSedNjE9VOuL B6S7JHuwUkpBwqz7j39ePF262LHxeJwjbSrzyGGa1s73cLTLRYCmfR6BXaix98VcjyqL E/ZJrH5+yaBLOvAGSpdNbV+CITNlmbGRCa4WeGR8nVusVGw3o1xRyKPxJCtuixZYos9L kqWtmGO/6IvfiZAaf/odTi3/OFjQqX90rgaIBv+4KbswOFX3CLjD9Z2ZuYxIdlklUucX +35aF8WBV0WR5DT8d/DBXBJm9fM8iEgbFGvIEeLZ2uL/+szhnBm5NmWhymd0oE5lOA+m gGbA== X-Gm-Message-State: AOAM531M2DiSC7yFgbwBebjT0oB+RlP+52yLeZuaQWOQLjNfC7cVfSwF 5KwwKAqq0Wa/spNoYHXde5bk/95I0NOn X-Google-Smtp-Source: ABdhPJxJ7Z11zeGY8MwMQzcwm2TOvqePLmEMB/wktyCWJdtOg7cn9h9TvTVluTrz8IUg56U5LUsQ8WUMXwbj X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:5993:294b:7b62:54cb]) (user=irogers job=sendgmr) by 2002:a25:44c1:0:b0:64a:94d7:6a5a with SMTP id r184-20020a2544c1000000b0064a94d76a5amr23664672yba.396.1652335995713; Wed, 11 May 2022 23:13:15 -0700 (PDT) Date: Wed, 11 May 2022 23:13:08 -0700 In-Reply-To: <20220512061308.1152233-1-irogers@google.com> Message-Id: <20220512061308.1152233-3-irogers@google.com> Mime-Version: 1.0 References: <20220512061308.1152233-1-irogers@google.com> X-Mailer: git-send-email 2.36.0.512.ge40c2bad7a-goog Subject: [PATCH v2 2/2] perf test: Add basic stat and topdown group test From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Riccardo Mancini , Kim Phillips , Madhavan Srinivasan , Shunsuke Nakamura , Florian Fischer , Andi Kleen , John Garry , Zhengjun Xing , Adrian Hunter , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Add a basic stat test. Add two tests of grouping behavior for topdown events. Topdown events are special as they must be grouped with the slots event first. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/stat.sh | 67 ++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100755 tools/perf/tests/shell/stat.sh diff --git a/tools/perf/tests/shell/stat.sh b/tools/perf/tests/shell/stat.s= h new file mode 100755 index 000000000000..c7894764d4a6 --- /dev/null +++ b/tools/perf/tests/shell/stat.sh @@ -0,0 +1,67 @@ +#!/bin/sh +# perf stat tests +# SPDX-License-Identifier: GPL-2.0 + +set -e + +err=3D0 +test_default_stat() { + echo "Basic stat command test" + if ! perf stat true 2>&1 | egrep -q "Performance counter stats for 'true= ':" + then + echo "Basic stat command test [Failed]" + err=3D1 + return + fi + echo "Basic stat command test [Success]" +} + +test_topdown_groups() { + # Topdown events must be grouped with the slots event first. Test that + # parse-events reorders this. + echo "Topdown event group test" + if ! perf stat -e '{slots,topdown-retiring}' true > /dev/null 2>&1 + then + echo "Topdown event group test [Skipped event parsing failed]" + return + fi + if perf stat -e '{slots,topdown-retiring}' true 2>&1 | egrep -q "" + then + echo "Topdown event group test [Failed events not supported]" + err=3D1 + return + fi + if perf stat -e '{topdown-retiring,slots}' true 2>&1 | egrep -q "" + then + echo "Topdown event group test [Failed slots not reordered first]" + err=3D1 + return + fi + echo "Topdown event group test [Success]" +} + +test_topdown_weak_groups() { + # Weak groups break if the perf_event_open of multiple grouped events + # fails. Breaking a topdown group causes the events to fail. Test a very= large + # grouping to see that the topdown events aren't broken out. + echo "Topdown weak groups test" + ok_grouping=3D"{slots,topdown-bad-spec,topdown-be-bound,topdown-fe-bound= ,topdown-retiring},branch-instructions,branch-misses,bus-cycles,cache-misse= s,cache-references,cpu-cycles,instructions,mem-loads,mem-stores,ref-cycles,= cache-misses,cache-references" + if ! perf stat --no-merge -e "$ok_grouping" true > /dev/null 2>&1 + then + echo "Topdown weak groups test [Skipped event parsing failed]" + return + fi + group_needs_break=3D"{slots,topdown-bad-spec,topdown-be-bound,topdown-fe= -bound,topdown-retiring,branch-instructions,branch-misses,bus-cycles,cache-= misses,cache-references,cpu-cycles,instructions,mem-loads,mem-stores,ref-cy= cles,cache-misses,cache-references}:W" + if perf stat --no-merge -e "$group_needs_break" true 2>&1 | egrep -q "" + then + echo "Topdown weak groups test [Failed events not supported]" + err=3D1 + return + fi + echo "Topdown weak groups test [Success]" +} + +test_default_stat +test_topdown_groups +test_topdown_weak_groups +exit $err --=20 2.36.0.512.ge40c2bad7a-goog