Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VSWYUfdKb47f1Ctp8M5EvyOjUh/+POZHDVSpFR8FCpI=; b=oFFBe2+Qjjza1eZgP94WQEGMH7IXu44CJMLRPp6XljyoggOAiBftzTMGbQHyPR9a02aDIw61M8Zj+/3EGxYbO2Q2U2/0UXYeE07aGGh/lt4ZRgzgbnl+j5HZxkrHyX/FfV2llwIR9mjJ6kJ226th+kvsE8vVQ/eW2x/TYpfgLGk= From: Vladimir Oltean Date: Thu, 12 May 2022 17:50:56 +0000 Message-ID: <20220512175055.65ftcpkig3t3ttsq@skbuf> References: <20220512094743.79f36d81@kernel.org> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <1FBBF271EF790D4EA63BD40553277A08@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Bridge] [PATCH net-next v7 2/2] net: vxlan: Add extack support to vxlan_fdb_delete List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alaa Mohamed Cc: "shshaikh@marvell.com" , "jdenham@redhat.com" , "GR-Linux-NIC-Dev@marvell.com" , "manishc@marvell.com" , "alexandre.belloni@bootlin.com" , "outreachy@lists.linux.dev" , "netdev@vger.kernel.org" , "razor@blackwall.org" , "bridge@lists.linux-foundation.org" , "jesse.brandeburg@intel.com" , "linux-kernel@vger.kernel.org" , "sbrivio@redhat.com" , Claudiu Manoil , "anthony.l.nguyen@intel.com" , Roopa Prabhu , Jakub Kicinski , "pabeni@redhat.com" , "davem@davemloft.net" , "UNGLinuxDriver@microchip.com" , "intel-wired-lan@lists.osuosl.org" On Thu, May 12, 2022 at 10:17:13AM -0700, Roopa Prabhu wrote: >=20 > On 5/12/22 09:47, Jakub Kicinski wrote: > > On Thu, 12 May 2022 09:22:17 -0700 Roopa Prabhu wrote: > > > On 5/12/22 02:55, Alaa Mohamed wrote: > > > > This patch adds extack msg support to vxlan_fdb_delete and vxlan_fd= b_parse. > > > > extack is used to propagate meaningful error msgs to the user of vx= lan > > > > fdb netlink api > > > >=20 > > > > Signed-off-by: Alaa Mohamed > > Also the patches don't apply to net-next, again. >=20 > that's probably because the patches were already applied. Ido just told m= e > abt it also >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commi= t/?id=3D5dd6da25255a9d64622c693b99d7668da939a980 >=20 > I have requested Alaa send an incremental fix (offline). >=20 > thanks > Alaa, when you send the incremental fixup patch requested by Roopa, could you please also: - properly align the extack argument of the ocelot_port_fdb_del() function - properly align the extack argument of the vxlan_fdb_delete() function - properly align the "DST, VNI, ifindex and port are mutually exclusive wit= h NH_ID" string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_p= arse(). - make actual use of the extack in ice_fdb_add() and ice_fdb_del(), and remove the __always_unused from ice_fdb_add(). Thank you.=