Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF763D7A for ; Mon, 23 May 2022 21:12:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F05C4C385AA; Mon, 23 May 2022 21:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653340362; bh=K+0kb+1T6fTwqeaa3p/zFyHwzUXpfYDrhNG6xwL4avs=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=ujWDmo9yI3OajC10rWTa9rn8qtIbPwK0fYx/WHL297tLDIZcNg2zTrgjqNP2FiHQH NhNU5deqlw4xTxVvnnVOXuRDlSm5CIqoLUW5oJTZww7DJYgJbsaOGRla/ZgOiByN9U iCTB8y1QDG4hnEki3sM6odgADVEpHRNI+MSXZ6JDmxm5EXslW7NuaSljXlRDlH+qeb /AysVxYmO1mNAbscoaMKP5pdkIEq+Bo67Q8kXpXezKTsLI4JFNkwtaOV5fJmZL60Zs PexurT76M9idbWriNU2nQFEIBwPZ+5mldJ+n6g1GfEiuPR0hc386lL8HAYvLmvphao LI69ldME5snHg== From: SeongJae Park To: Khalid Masum Cc: linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan , SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/daemon: describe NR_DAMON_OPS in damon_ops_id Date: Mon, 23 May 2022 14:12:25 -0700 Message-Id: <20220523211225.32500-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220523205336.2435-1-khalid.masum.92@gmail.com> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Hi Khalid, On Tue, 24 May 2022 02:53:36 +0600 Khalid Masum wrote: > NR_DAMON_OPS in the enum damon_ops_id is not described. Describe it for > better readability and also to fix a warning generated by make docs. > > "NR" is described as "Total Number" and "DAMON_OPS" is described as > "Monitoring operations" in the same file. Hence describe NR_DAMON_OPS > as "Total number of damon operations". Thank you for this patch! However, same patch has already posted by other and merged in mm-stable[1], sorry. Looking forward to your next patches, though! [1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-stable&id=d4a157f5a26fbf1f1fd5da47a4772a738306348f Thanks, SJ > > Signed-off-by: Khalid Masum > --- > include/linux/damon.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index f23cbfa42..9e9fb4d78 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -262,6 +262,7 @@ struct damos { > * > * @DAMON_OPS_VADDR: Monitoring operations for virtual address spaces > * @DAMON_OPS_PADDR: Monitoring operations for the physical address space > + * @NR_DAMON_OPS: Total number of monitoring operations > */ > enum damon_ops_id { > DAMON_OPS_VADDR, > -- > 2.25.1 >